From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9100DC433E0 for ; Mon, 3 Aug 2020 08:26:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DA24206E2 for ; Mon, 3 Aug 2020 08:26:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vI8cIsUI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DIizX0es" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DA24206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8QxWx+wucSIt+Uq0g5fSjEigb3zPU9w6OjyWtggneuE=; b=vI8cIsUI7+PDldC12jbNeQ42U umgSk8z5SW6jI4rCiNmEYTinaferydLYm/PC0tzLm+gZibmgTPjg+wZlmG94QXIjPrV/TlDMeZi+q 5IZNKKVHLlCvf2n8jrgDLjSkN47rc0sEVtsJQcMSwef3Oe7t4C9nhiFHTa+EOlAqDwW0wrF8Cs2Qc txLLiLGTPan+P02oVNPFlSlQOVK86QyfM2dD6NwplhGLA1a89QY8LWs4a+u6j3UPGxrPfQ3j2j+0+ /etSg5yg0Pdly36YABRT+lq9+DRheFnZkDStue/bM1ecNW/LPTED3f8z3+EtRMXRJTMoTPovMHHXc 2T5Oz91qA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2VmK-0007t8-B5; Mon, 03 Aug 2020 08:25:04 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2VmH-0007rp-OM for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2020 08:25:02 +0000 Received: by mail-wr1-x442.google.com with SMTP id a15so33312414wrh.10 for ; Mon, 03 Aug 2020 01:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=idno4XA8cyFxWToJkaA+wyHL6pf3C4NEsthkMu6eKrE=; b=DIizX0esDlRGwFEkVKmrfd9GB9tB45pOEX3X2zXslub6Z2+O8utOXdqcr5nQ/Oa2Zr qtDmg3vVY5gz7a0B5axSSwjHiudMITKOUM74BbyU9hsICaPu+1LFFu3AYhyE9TyuARBH GvuSes6pSGu2yftPCeqqaMsKqEtQaeiIFz3pk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=idno4XA8cyFxWToJkaA+wyHL6pf3C4NEsthkMu6eKrE=; b=OWFhGufyXVTRiGcuMGXi/Rk2z4RH1Ig0Wg/aCzI5Gjx9FeFVtrH41UtmAI7MAjQqsC lDz7ZcUm7TMTPodIyGcGJvYyyKbIcRarnvFKdFBVqalrPsyUemW6NJ2T28kGZPrd7F0n u8tax+rCz5DYsYsbVqN76bal7ep8oovTez4Y+jJJqdHo1MPOAfKdyjNHqANtmjts/e4t LWR5vIAM9BnBrgjO9F1YbkATF/JmcsrrwQ1e5ef4Ro4PJQmrQgdomvxfCl0ZPo8p4u4t yzhb1d+5S6YFFjowgSAPpl+PdYOP8LNv6OtGUrb+naCgqeFJgtdNFVwFGr+689CoBA+C 3M+Q== X-Gm-Message-State: AOAM530Jy+dgkSE6OLkyBOVm6/2ED327PT9sRzI41DhzpNweDGTAm6sG azuMQBVgbZUOZ7HNZGnUjm+hF67PuzofO8jGKiDXog== X-Google-Smtp-Source: ABdhPJyMr8Qvm79z3JxDUYSbnhyiu1LPeKjwbT1/t95HT7mmACCwcVs3ic5l8CuEVZXehyw2+vldMmejt18EJU2jItw= X-Received: by 2002:adf:e486:: with SMTP id i6mr13791882wrm.258.1596443098745; Mon, 03 Aug 2020 01:24:58 -0700 (PDT) MIME-Version: 1.0 References: <20200731084023.2678931-1-cychiang@chromium.org> <20200731084023.2678931-2-cychiang@chromium.org> <20200731182712.GA531472@bogus> In-Reply-To: <20200731182712.GA531472@bogus> From: Cheng-yi Chiang Date: Mon, 3 Aug 2020 16:24:32 +0800 Message-ID: Subject: Re: [PATCH v3 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_042501_867005_6128038E X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , linux-kernel , Stephan Gerhold , Liam Girdwood , linux-arm-msm , Patrick Lai , Takashi Iwai , Doug Anderson , Tzung-Bi Shih , Bjorn Andersson , Rob Herring , Andy Gross , Srini Kandagatla , Mark Brown , Rohit kumar , Dylan Reid , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 1, 2020 at 2:27 AM Rob Herring wrote: > > On Fri, 31 Jul 2020 16:40:22 +0800, Cheng-Yi Chiang wrote: > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > .../bindings/sound/qcom,sc7180.yaml | 113 ++++++++++++++++++ > > 1 file changed, 113 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/sound/qcom,sc7180.example.dts:32.24-41.15: Warning (unit_address_vs_reg): /example-0/sound/dai-link@0: node has a unit name, but no reg or ranges property > Documentation/devicetree/bindings/sound/qcom,sc7180.example.dts:43.24-52.15: Warning (unit_address_vs_reg): /example-0/sound/dai-link@1: node has a unit name, but no reg or ranges property > > > See https://patchwork.ozlabs.org/patch/1339316 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > I have passed this in v2 patch, but removed reg in v3 patch since it is not used. In v4, I have added back reg = <0> and reg = <1> into the example, and reg property into schema to fix this error. Since reg property is not used in the driver, I am not sure whether I should add it in the schema. Please let me know which is preferred. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel