From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8570CC2BA18 for ; Mon, 6 Apr 2020 08:26:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31E1B20672 for ; Mon, 6 Apr 2020 08:26:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZzPiyg1w"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LNSvxDZj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31E1B20672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GTpbiRgCXbAgQjnKzZ8nkymOv/fEYWgrHjGv8bO23Nk=; b=ZzPiyg1wCfSoAH c6LNvlkuRD+DzkKwTg1z5/NL3OsvcsXgpTgAE9DGu9itLdBL/YHopBqPkIrnr6uSh0XHta2M1r1aG O5UqA8uBmwH+XpOXNoq1JXwz1yMw0UD8sCEOcRJpBrVob61m10Z6vbN9VEWqWcJ0flBHRWATijdja bKRrUIxYeTeEt9uoT1+kbaa0RZfabi47kKyVMVrYyFBOTzR4JKZbnuIbG+QuyF50t8bSNpmegfhSr PFP5NGh7J3u2QRJo7bsVLFf1s9hESdfXmCnr7FD32+gLM0GVy2+BPnQ2z8MVRVgysN2wse6MsLP7O 9BL0ZqZ6d2LoBcO6ZgjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLN56-0002w4-Na; Mon, 06 Apr 2020 08:26:08 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLN52-0002vP-13 for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 08:26:06 +0000 Received: by mail-ot1-x343.google.com with SMTP id 22so14497760otf.0 for ; Mon, 06 Apr 2020 01:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vOURNP/+1sHn2/oMAz9DpyrmfncIc+Lque59yZC/+5w=; b=LNSvxDZjUIJxP4/R0gUjwWEcoIXjaM14W0yLZVSrDlbz182T85YKg9jbdKtsDv4lSw CJiAmks7NsnTkIghjBXK8DlURDeKnUSzJHYlN+12DuAULHbIVlDN8ppxELEfYm4zwqBs aw/ZeWuSYt776wwjblNiwil1Cb3zzS0HMTuWr4qv/qliIlcRDXzDzrT9gX+SGuK3v/KQ SyvKYC+rBZ/4QqGchMam2id0O6G1vGyw3EkfvK4wIoXf3OQ9eMKwadXJfYRiD2FLFq/W QUHuyHh4ngh+RtAjWUyHyUabXwCzTo0oYRE1r8ouVeIQ7FxN8oMye+v/vqt+KJHyEl5z t9mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vOURNP/+1sHn2/oMAz9DpyrmfncIc+Lque59yZC/+5w=; b=ELZkhr51SlP3K5Z99WjzEUg/R+XWjZCr0/9xnPJl7iuklGVJmGKd0jQs4LIML1fGJc 462vVygR1vrFr0I1sTSbiptwUIYPyavEtM/+VapinrVrrl1LiN97JKFkTqwqVcdro47x /jhhCBmWOGAVVoOPtuVzKXrV5DtMwuVeg3fMkrk/5nohMP53FCZAmr/Irsl7I1bJ6g/L 5MfvavijcKKeL/mBVfXl/da3+qiOIF2WVSW1g0cfUADo8fjnZXCtx2nP33ygOQa+HZKi HyBmafms4p4LhBWFDa21CEPSWy4bzsETWgI6MavFNu9imri5xLoDzL/KY1T8Zocsfz5b T13g== X-Gm-Message-State: AGi0PualkPXBQonV8juAL37dN+2HTpQHz2fRFFokY4fYSEnghLKP/IrW DMSWqRO7lXJ/8PYrKGvsWG+ExVZ/USipC+9BQMPUjg== X-Google-Smtp-Source: APiQypIkuoFfBZNbSuH6xY0DqxdXdxWr0AqNxKMHvTzBtHBZP9ZPw+ZzMKWrTKGg9oy2VTppKuGgJcpLQV7RZVDW/2Y= X-Received: by 2002:a4a:e495:: with SMTP id s21mr16488515oov.79.1586161562627; Mon, 06 Apr 2020 01:26:02 -0700 (PDT) MIME-Version: 1.0 References: <20200331133346.372517-1-robert.foss@linaro.org> <20200331133346.372517-2-robert.foss@linaro.org> <20200401080705.j4goeqcqhoswhx4u@gilmour.lan> <20200403232736.GA6127@valkosipuli.retiisi.org.uk> <20200404093446.vuvwrhn5436h4d3s@gilmour.lan> In-Reply-To: <20200404093446.vuvwrhn5436h4d3s@gilmour.lan> From: Robert Foss Date: Mon, 6 Apr 2020 10:25:50 +0200 Message-ID: Subject: Re: [PATCH v6 1/3] media: dt-bindings: ov8856: Document YAML bindings To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_012604_588641_F0FCD441 X-CRM114-Status: GOOD ( 40.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Tomasz Figa , Sakari Ailus , Dongchun Zhu , Andy Shevchenko , Fabio Estevam , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-media Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Maxime, On Sat, 4 Apr 2020 at 11:34, Maxime Ripard wrote: > > Hi, > > On Sat, Apr 04, 2020 at 02:27:36AM +0300, Sakari Ailus wrote: > > Hi Robert, > > > > On Thu, Apr 02, 2020 at 12:10:00PM +0200, Robert Foss wrote: > > > Hey Maxime, > > > > > > On Wed, 1 Apr 2020 at 10:07, Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > On Tue, Mar 31, 2020 at 03:33:44PM +0200, Robert Foss wrote: > > > > > From: Dongchun Zhu > > > > > > > > > > This patch adds documentation of device tree in YAML schema for the > > > > > OV8856 CMOS image sensor. > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > Signed-off-by: Robert Foss > > > > > --- > > > > > > > > > > - Changes since v5: > > > > > * Add assigned-clocks and assigned-clock-rates > > > > > * robher: dt-schema errors > > > > > > > > > > - Changes since v4: > > > > > * Fabio: Change reset-gpio to GPIO_ACTIVE_LOW, explain in description > > > > > * Add clock-lanes property to example > > > > > * robher: Fix syntax error in devicetree example > > > > > > > > > > - Changes since v3: > > > > > * robher: Fix syntax error > > > > > * robher: Removed maxItems > > > > > * Fixes yaml 'make dt-binding-check' errors > > > > > > > > > > - Changes since v2: > > > > > Fixes comments from from Andy, Tomasz, Sakari, Rob. > > > > > * Convert text documentation to YAML schema. > > > > > > > > > > - Changes since v1: > > > > > Fixes comments from Sakari, Tomasz > > > > > * Add clock-frequency and link-frequencies in DT > > > > > > > > > > .../devicetree/bindings/media/i2c/ov8856.yaml | 150 ++++++++++++++++++ > > > > > MAINTAINERS | 1 + > > > > > 2 files changed, 151 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > > > > new file mode 100644 > > > > > index 000000000000..beeddfbb8709 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > > > > @@ -0,0 +1,150 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > +# Copyright (c) 2019 MediaTek Inc. > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/media/i2c/ov8856.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings > > > > > + > > > > > +maintainers: > > > > > + - Ben Kao > > > > > + - Dongchun Zhu > > > > > + > > > > > +description: |- > > > > > + The Omnivision OV8856 is a high performance, 1/4-inch, 8 megapixel, CMOS > > > > > + image sensor that delivers 3264x2448 at 30fps. It provides full-frame, > > > > > + sub-sampled, and windowed 10-bit MIPI images in various formats via the > > > > > + Serial Camera Control Bus (SCCB) interface. This chip is programmable > > > > > + through I2C and two-wire SCCB. The sensor output is available via CSI-2 > > > > > + serial data output (up to 4-lane). > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + const: ovti,ov8856 > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > + clocks: > > > > > + maxItems: 1 > > > > > + > > > > > + clock-names: > > > > > + description: > > > > > + Input clock for the sensor. > > > > > + items: > > > > > + - const: xvclk > > > > > + > > > > > + clock-frequency: > > > > > + description: > > > > > + Frequency of the xvclk clock in Hertz. > > > > > > > > We also had that discussion recently for another omnivision sensor > > > > (ov5645 iirc), but what is clock-frequency useful for? > > > > > > > > It seems that the sensor is passed in clocks, so if you need to > > > > retrieve the clock rate you should use the clock API instead. > > > > > > > > Looking at the driver, it looks like it first retrieves the clock, set > > > > it to clock-frequency, and then checks that this is OV8856_XVCLK_19_2 > > > > (19.2 MHz). > > > > > > As far as I understand it, 19.2MHz is requirement for the sensor mode > > > that currently defaults to. Some modes require higher clock speeds > > > than this however. > > > > It's very system specific. Either way, bindings should not assume a > > particular driver implementation. > > > > > > > > > > > > > The datasheet says that the sensor can have any frequency in the 6 - > > > > 27 MHz range, so this is a driver limitation and should be set in the > > > > driver using the clock API, and you can always bail out if it doesn't > > > > provide a rate that is not acceptable for the drivers assumption. > > > > > > > > In any case, you don't need clock-frequency here... > > > > > > So your suggestion is that we remove all clocks-rate properties, and > > > replace the clk_get_rate() calls in the driver with clk_set_rate() > > > calls for the desired frequencies? > > > > The driver shouldn't set the rate here unless it gets it from DT (but that > > was not the intention). So the driver should get the frequency instead. > > I'm actually saying the opposite :) > > Like you were saying, the binding (or DT, for that matter) shouldn't > assume a particular driver implementation. > > So one corollary is that if the driver has some restrictions in Linux, > it shouldn't be part of the binding, right? > > This binding uses multiple clock properties but as far as I can see, > the driver retrieves a clock using clocks and makes sure that its rate > match its limitation of 19.2MHz using clock-frequency (which is > redundant on a clk_get_rate on the clocks provided earlier). > > I'm suspecting that the parent clock on multiple SoCs can be > configured and is not a fixed rate crystal, so assigned-clocks-rate is > here just to make sure we set the frequency at the one being checked > in the driver's probe so that it all works. > > But that 19.2MHz is not a limitation of the device itself, it's a > limitation of our implementation, so we can instead implement > something equivalent in Linux using a clk_set_rate to 19.2MHz (to make > sure that our parent clock is configured at the right rate) and the > clk_get_rate and compare that to 19.2MHz (to make sure that it's not > been rounded too far apart from the frequency we expect). > > This is doing exactly the same thing, except that we don't encode our > implementation limitations in the DT, but in the driver instead. > Thanks for taking the time to explain this. I'll spin a new revision that moves the clock rate handling into the driver. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel