From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277C0C4338F for ; Fri, 6 Aug 2021 04:41:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4297611C5 for ; Fri, 6 Aug 2021 04:41:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D4297611C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BNtN5+9HQApZJyn8/aeH1Q14v12/ZQUQO+8anZyqUuc=; b=eHviBw9cNvkA9f cJUSj/OXV4vRgLzy3axUSieaiMKbajzpqz27HZ45kD+2KVj2JfGL0NQEDqo+ch+S5pEXWyHcdnNgH zFdBnEY6PZUjvAkh1c1zaUPNLqUSi4b/Hrux9XxCyttyvOa4G9w0enLtiX8UIQ/p+Qot2/cdT1RB+ c0vYUhmvP5ivJC4QbEUt21tlObWiRgtITr4G8D7AhwmgsV0Scn4isoJfm8zgCCs97W8z9qaYMU3CH 6g+bBHHwNBali9tZzlbEkj+CEGgDULKx2hCWfd4mdva9V6dy9PAITpshDXza+RrX3I/LrWteXDPyE o/WlaGbMMJE1D4a5O1oA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBrei-00Bb4H-Ep; Fri, 06 Aug 2021 04:40:24 +0000 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBref-00Bb3S-Bf for linux-arm-kernel@lists.infradead.org; Fri, 06 Aug 2021 04:40:22 +0000 Received: by mail-yb1-xb32.google.com with SMTP id m193so12949939ybf.9 for ; Thu, 05 Aug 2021 21:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H2ihiTBstu/ghfSxcs1f2+pQV6+vs2bf3Mboq2+GrYs=; b=ScQMvNjfYNJSGtjPrCNoRPznDc6d5pMej9Fqm+KRBn8h9amXskzkNXOuipENioI1rq /xS8PGVN/aV9AZYVzrwF27cERRrgSF5TDEoeBdgol4/o9JK7Dw5/t6S9KTwF8X/U3wmR EoVxxBkvxoJyneBURRl7jbEhutyp0m1JlD6MqZvB4GBDtaQHuf4tcHqUMCG9jdVd5jPx wR0HvMaoLS/KFeeOV5MMJm+xwN0TvzgrTtTgMy2Bb1UuH6kDiNbb4crnBddJSO7GTpGL w+YGSP7iSbTd2olgPr2U/2PrGSXPdrrBdbnJYtL4j7yISkbn+Xyx6nOirFw7evWXBqtc xyvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H2ihiTBstu/ghfSxcs1f2+pQV6+vs2bf3Mboq2+GrYs=; b=Hv97Wnu1UZbeuuAuZf/A7Y2EwHyEJ6Wvu0VQ/5Ak4CBtLDb/WsOvtWT4nCmwIy/HHO 8cPweqOcwiTWwxkqZJieo/fct5vqGH60hCPV08GkCDBgzyLNLGiC4FxKBu2H3ViJlxkz xuNY2WvQLbeUqAjByy7uUgZJ3Glh4OBXC8wZVb8qviKhJAQS5layrTsN6Pa95I8lN33N QC8suMnr2mTmBQVLQzAfNyLLNfAEGOQZnYMQuWhepH3Jz3amHvKz6L5CEXqLsi01hpvw KLoHzwSDEywGLbD17ijrGivygFPAMx1R3yUbsdLza1gkkz3okqy3+ZUCJ1G6Z6xT0iBd hppg== X-Gm-Message-State: AOAM532FQAuDYzwXsVc4v4oDiV470Q7tsFTkgwapwtHfVwqeFYfwC+8c nUWIn6Jyso8E/qA01JVo60duH13QttrYhNkpoYAQOA== X-Google-Smtp-Source: ABdhPJwwfzkphKrpb1Q7KfPDzSz4SSbIQ8eSjOWjUnLgCAhafTdZDlZKO6z/PKhjmUf+ShlBNIq223ptUqDafbp7E/Q= X-Received: by 2002:a25:53c9:: with SMTP id h192mr9792706ybb.310.1628224819006; Thu, 05 Aug 2021 21:40:19 -0700 (PDT) MIME-Version: 1.0 References: <20210803113538.560277-1-fido_max@inbox.ru> In-Reply-To: From: Saravana Kannan Date: Thu, 5 Aug 2021 21:39:42 -0700 Message-ID: Subject: Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device To: Maxim Kochetkov Cc: linuxppc-dev@lists.ozlabs.org, qiang.zhao@nxp.com, leoyang.li@nxp.com, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_214021_455416_6F8D62AB X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 5, 2021 at 9:35 PM Maxim Kochetkov wrote: > > 03.08.2021 20:51, Saravana Kannan wrote: > >> So lets convert this driver to simple platform_device with probe(). > >> Also use platform_get_ and devm_ family function to get/allocate > >> resources and drop unused .compatible = "qeic". > > Yes, please! > > Should I totally drop { .type = "qeic"}, or keep? Sorry for the confusion. My "Yes, please"!" was a show of support for switching this to a proper platform driver. Not a response to that specific question. I didn't look at the code/DT close enough to know/care about the "type" part. -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel