Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Saravana Kannan <saravanak@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Heiko Stuebner <heiko@sntech.de>, PCI <linux-pci@vger.kernel.org>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Android Kernel Team <kernel-team@android.com>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT
Date: Tue, 18 Aug 2020 10:48:54 -0700
Message-ID: <CAGETcx-hkz8fyAHuhRi=JhBFu4YUmL2UpHfgs7doLHK-RdKA0A@mail.gmail.com> (raw)
In-Reply-To: <72c10e43023289b9a4c36226fe3fd5d9@kernel.org>

On Tue, Aug 18, 2020 at 10:34 AM Marc Zyngier <maz@kernel.org> wrote:
>
> On 2020-08-18 15:23, Rob Herring wrote:
> > On Tue, Aug 18, 2020 at 1:35 AM Marc Zyngier <maz@kernel.org> wrote:
> >>
> >> On 2020-08-17 17:12, Rob Herring wrote:
> >> > On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier <maz@kernel.org> wrote:
> >> >>
> >> >> On Sun, 16 Aug 2020 00:22:28 +0100,
> >> >> Bjorn Helgaas <helgaas@kernel.org> wrote:
> >> >> >
> >> >> > On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote:
> >> >> > > Recent changes to the DT PCI bus parsing made it mandatory for
> >> >> > > device tree nodes describing a PCI controller to have the
> >> >> > > 'device_type = "pci"' property for the node to be matched.
> >> >> > >
> >> >> > > Although this follows the letter of the specification, it
> >> >> > > breaks existing device-trees that have been working fine
> >> >> > > for years.  Rockchip rk3399-based systems are a prime example
> >> >> > > of such collateral damage, and have stopped discovering their
> >> >> > > PCI bus.
> >> >> > >
> >> >> > > In order to paper over the blunder, let's add a workaround
> >> >> > > to the pcie-rockchip driver, adding the missing property when
> >> >> > > none is found at boot time. A warning will hopefully nudge the
> >> >> > > user into updating their DT to a fixed version if they can, but
> >> >> > > the insentive is obviously pretty small.
> >> >> >
> >> >> > s/insentive/incentive/ (Lorenzo or I can fix this up)
> >> >> >
> >> >> > > Fixes: 2f96593ecc37 ("of_address: Add bus type match for pci ranges parser")
> >> >> > > Suggested-by: Roh Herring <robh+dt@kernel.org>
> >> >> >
> >> >> > s/Roh/Rob/ (similarly)
> >> >>
> >> >> Clearly not my day when it comes to proofreading commit messages.
> >> >> Thanks for pointing this out, and in advance for fixing it up.
> >> >>
> >> >> >
> >> >> > > Signed-off-by: Marc Zyngier <maz@kernel.org>
> >> >> >
> >> >> > This looks like a candidate for v5.9, since 2f96593ecc37 was merged
> >> >> > during the v5.9 merge window, right?
> >> >>
> >> >> Absolutely.
> >> >>
> >> >> > I wonder how many other DTs are similarly broken?  Maybe Rob's DT
> >> >> > checker has already looked?
> >> >>
> >> >> I've just managed to run the checker, which comes up with all kinds of
> >> >> goodies. Apart from the above, it also spots the following:
> >> >>
> >> >> - arch/arm64/boot/dts/mediatek/mt7622.dtsi: Has a device_type property
> >> >>   in its main PCIe node, but not in the child nodes. It isn't obvious
> >> >>   to me whether that's a violation or not (the spec doesn't say
> >> >>   whether the property should be set on a per-port basis). Rob?
> >> >
> >> > The rule is bridge nodes should have 'device_type = "pci"'. But what's
> >> > needed to fix these cases is setting device_type where we are parsing
> >> > ranges or dma-ranges which we're not doing on the child ndes.
> >> > Otherwise, I don't think it matters in this case unless you have child
> >> > (grandchild here) nodes for PCI devices. If you did have child nodes,
> >> > the address translation was already broken before this change.
> >>
> >> Fair enough.
> >>
> >> >> - arch/arm64/boot/dts/qcom/msm8996.dtsi: Only one out of the three
> >> >>   PCIe nodes has the device_type property, probably broken similarly
> >> >>   to rk3399.
> >> >
> >> > The only upstream board is DB820c, so probably not as wide an impact...
> >> >
> >> > There are also 92 (lots of duplicates due to multiple boards) more
> >> > cases in arch/arm/. A log is here[1].
> >>
> >> Mostly Broadcom stuff, apparently. I'll see if I can have a stab
> >> at it (although someone will have to test it).
> >>
> >> >
> >> >> I could move the workaround to drivers/pci/of.c, and have it called
> >> >> from the individual drivers. I don't have the HW to test those though.
> >> >>
> >> >> Thoughts?
> >> >
> >> > I think we should go with my other suggestion of looking at the node
> >> > name. Looks like just checking 'pcie' is enough. We can skip 'pci' as
> >> > I don't see any cases.
> >>
> >> I really dislike it.
> >>
> >> Once we put this node name matching in, there is no incentive for
> >> people to write their DT correctly at all. It also sound pretty
> >> fragile (what if the PCIe node is named something else?).
> >
> > That would require 2 wrongs. Both missing device_type and wrong node
> > name. You could still warn if we matched on node name.
>
> OK. So how about something like this?
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 590493e04b01..a7a6ee599b14 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -134,9 +134,13 @@ static int of_bus_pci_match(struct device_node *np)
>          * "pciex" is PCI Express
>          * "vci" is for the /chaos bridge on 1st-gen PCI powermacs
>          * "ht" is hypertransport
> +        *
> +        * If none of the device_type match, and that the node name is
> +        * "pcie", accept the device as PCI (with a warning).
>          */
>         return of_node_is_type(np, "pci") || of_node_is_type(np, "pciex") ||
> -               of_node_is_type(np, "vci") || of_node_is_type(np, "ht");
> +               of_node_is_type(np, "vci") || of_node_is_type(np, "ht") ||
> +               WARN_ON_ONCE(of_node_name_eq(np, "pcie"));

I don't think we need the _ONCE. Otherwise, it'd warn only for the
first device that has this problem.

How about?
WARN(of_node_name_eq(np, "pcie"), "Missing device type in %pOF", np)

That'll even tell them which node is bad.

-Saravana

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-15 12:51 [PATCH 0/2] PCI: rockchip: Fix PCIe probing in 5.9 Marc Zyngier
2020-08-15 12:51 ` [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT Marc Zyngier
2020-08-15 23:22   ` Bjorn Helgaas
2020-08-16 10:39     ` Marc Zyngier
2020-08-17 16:12       ` Rob Herring
2020-08-18  7:35         ` Marc Zyngier
2020-08-18 14:23           ` Rob Herring
2020-08-18 17:34             ` Marc Zyngier
2020-08-18 17:48               ` Saravana Kannan [this message]
2020-08-18 19:02                 ` Marc Zyngier
2020-08-18 19:06                   ` Rob Herring
2020-08-15 12:51 ` [PATCH 2/2] arm64: dts: rockchip: Fix PCIe DT properties Marc Zyngier
2021-01-09 15:39 ` (subset) [PATCH 0/2] PCI: rockchip: Fix PCIe probing in 5.9 Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGETcx-hkz8fyAHuhRi=JhBFu4YUmL2UpHfgs7doLHK-RdKA0A@mail.gmail.com' \
    --to=saravanak@google.com \
    --cc=bhelgaas@google.com \
    --cc=heiko@sntech.de \
    --cc=helgaas@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=maz@kernel.org \
    --cc=robh@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git