From: Alim Akhtar <alim.akhtar@gmail.com>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
andy.teng@mediatek.com,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
chun-hung.wu@mediatek.com,
Kuohong Wang <kuohong.wang@mediatek.com>,
open list <linux-kernel@vger.kernel.org>,
Avri Altman <avri.altman@wdc.com>, Can Guo <cang@codeaurora.org>,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
Alim Akhtar <alim.akhtar@samsung.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
asutoshd@codeaurora.org, Bart Van Assche <bvanassche@acm.org>,
linux-arm-kernel@lists.infradead.org,
"Bean Huo \(beanhuo\)" <beanhuo@micron.com>
Subject: Re: [PATCH v3 1/4] scsi: ufs-mediatek: ensure UniPro is not powered down before linkup
Date: Sun, 2 Feb 2020 20:04:55 +0530 [thread overview]
Message-ID: <CAGOxZ521Vz4EcmWApZLqcDwkwa-XHLFLDx2n1HRht0Pf0fFkmw@mail.gmail.com> (raw)
In-Reply-To: <20200129073902.5786-2-stanley.chu@mediatek.com>
HI Stanley
On Wed, Jan 29, 2020 at 1:09 PM Stanley Chu <stanley.chu@mediatek.com> wrote:
>
> MediaTek Chipsets can enter proprietary UniPro low-power mode during
> suspend while link is in hibern8 state. Make sure leaving low-power
> mode before every link startup to prevent lockup in any possible error recovery
> path.
>
> In the same time, re-factor related funcitons to improve code readability.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 53eae5fe2ade..7ac838cc15d1 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -30,6 +30,11 @@
> #define ufs_mtk_device_reset_ctrl(high, res) \
> ufs_mtk_smc(UFS_MTK_SIP_DEVICE_RESET, high, res)
>
> +#define ufs_mtk_unipro_powerdown(hba, powerdown) \
> + ufshcd_dme_set(hba, \
> + UIC_ARG_MIB_SEL(VS_UNIPROPOWERDOWNCONTROL, 0), \
> + powerdown)
> +
> static void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
> {
> u32 tmp;
> @@ -290,6 +295,8 @@ static int ufs_mtk_pre_link(struct ufs_hba *hba)
> int ret;
> u32 tmp;
>
> + ufs_mtk_unipro_powerdown(hba, 0);
> +
> /* disable deep stall */
> ret = ufshcd_dme_get(hba, UIC_ARG_MIB(VS_SAVEPOWERCONTROL), &tmp);
> if (ret)
> @@ -390,9 +397,7 @@ static int ufs_mtk_link_set_hpm(struct ufs_hba *hba)
> if (err)
> return err;
>
> - err = ufshcd_dme_set(hba,
> - UIC_ARG_MIB_SEL(VS_UNIPROPOWERDOWNCONTROL, 0),
> - 0);
> + err = ufs_mtk_unipro_powerdown(hba, 0);
> if (err)
> return err;
>
> @@ -413,14 +418,10 @@ static int ufs_mtk_link_set_lpm(struct ufs_hba *hba)
> {
> int err;
>
> - err = ufshcd_dme_set(hba,
> - UIC_ARG_MIB_SEL(VS_UNIPROPOWERDOWNCONTROL, 0),
> - 1);
> + err = ufs_mtk_unipro_powerdown(hba, 1);
> if (err) {
> /* Resume UniPro state for following error recovery */
> - ufshcd_dme_set(hba,
> - UIC_ARG_MIB_SEL(VS_UNIPROPOWERDOWNCONTROL, 0),
> - 0);
> + ufs_mtk_unipro_powerdown(hba, 0);
> return err;
> }
>
> --
> 2.18.0
--
Regards,
Alim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-02 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 7:38 [PATCH v3 0/4] MediaTek UFS vendor implemenation part III and Auto-Hibern8 fix Stanley Chu
2020-01-29 7:38 ` [PATCH v3 1/4] scsi: ufs-mediatek: ensure UniPro is not powered down before linkup Stanley Chu
2020-02-02 14:34 ` Alim Akhtar [this message]
2020-01-29 7:39 ` [PATCH v3 2/4] scsi: ufs-mediatek: support linkoff state during suspend Stanley Chu
2020-02-02 14:35 ` Alim Akhtar
2020-01-29 7:39 ` [PATCH v3 3/4] scsi: ufs: fix Auto-Hibern8 error detection Stanley Chu
2020-01-29 7:52 ` Greg KH
2020-01-29 10:46 ` Stanley Chu
2020-01-29 7:39 ` [PATCH v3 4/4] scsi: ufs-mediatek: gate ref-clk during Auto-Hibern8 Stanley Chu
2020-02-02 14:36 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGOxZ521Vz4EcmWApZLqcDwkwa-XHLFLDx2n1HRht0Pf0fFkmw@mail.gmail.com \
--to=alim.akhtar@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).