From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 676ACC4338F for ; Mon, 26 Jul 2021 08:36:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2751460C41 for ; Mon, 26 Jul 2021 08:36:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2751460C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Hbn1e4X92agv2VW92GKfOB6nLAr/osPl0PP15SN+XcY=; b=14smcVjiNRruvn ud9os2W8B3Ptua/zI6gkjgke8u5OM3If1J3n1Qy3EiMy+gglYy/laBSPM5yEhWsC/kQoqvBVg9mac tbIyupNV6gs/W/RHx446PbJiR4C6RxaZ6FdO95FNLY4anifxpj8WDjtw3Z8GJKG4TwdI/dCT6s8Pa v123IlnGwLahOzW17Ri/KSZzHE0BaUMwrwdk6GjIorF+fIbfKfvOTWq484ulJQi+X7n6uDoVsL3vG lXP21z/yAGf3xSchII5GhVsVxyRQ4tIDB8QwfksrNZ5i3PGPMljh2GH3hejiUpOVzJR43OQSEGkK0 oJLtsyNyi8DTXY/KWAkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7vqd-00A9so-9D; Mon, 26 Jul 2021 08:20:27 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7vqY-00A9rF-Mk for linux-arm-kernel@lists.infradead.org; Mon, 26 Jul 2021 08:20:24 +0000 Received: by mail-lf1-x133.google.com with SMTP id bp1so14032492lfb.3 for ; Mon, 26 Jul 2021 01:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=91yXb1VgXd5JhIW1bX57GkCbuisDS0fNOG8Fkd81qLY=; b=FygJv0Sm71wlNsHO+sqMNccJlsftKpOA/wgSG/X15ho9In3iyj7q2bEnSLlCtjD12L N/M7zXxrwMCTf3a4UtmdqGojLPb9b7WaJOnty8rww0ORl+tzW8hTdRfEpfRm/BmXKpG4 yCuxashLUeZU1hZS4DgXeoD2PStAB022xLxYc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=91yXb1VgXd5JhIW1bX57GkCbuisDS0fNOG8Fkd81qLY=; b=kclA+sy0LJdFBmCJD++v+KMobiJdMaUMEpGnCcvJtvVZUY6MXKibg5ZRoiLtkjNuEb TGj7CDrSlmXIpHeg+54CUj8eGwzbqAf+rUfFWczrU/8GrdyJIZb/Q9W7rcBNM84OiQ5i eDKJavB20pgD1nc6eU3toxNkInsnnCfH/2nngvBfO9lnYzPtiXULYfbyzw+42C2NKN73 CQUyv0sM4EoPx0+nQnX8KfI4yGa2JJVU5Z02kNanb6xQU1envF+uzg4A10Slo9er9jiS uC90RuNDzQlP0I6JsGBG2o8u6AazVfnDP7UdFhUfuIprrClXDoTsrsBGKBdH16LJRaEW gpSg== X-Gm-Message-State: AOAM533YsgYrk8VWcc+2HSnZacanVWpgvSx9aKKFWwBViz4d8qC16+n5 un/yasiv3XIq9vyJvxTzX/yxsPZTD4vC71pJPxzdrw== X-Google-Smtp-Source: ABdhPJwfbJe3IIQsY3UXhqvOx83qo8udghPA/zhl6SSU23YZpe1JFdaeLb5Lxi5GlOdmAKbpunqhPBD06JXT87jgpNk= X-Received: by 2002:a19:f00c:: with SMTP id p12mr12028038lfc.647.1627287620624; Mon, 26 Jul 2021 01:20:20 -0700 (PDT) MIME-Version: 1.0 From: Chen-Yu Tsai Date: Mon, 26 Jul 2021 16:20:09 +0800 Message-ID: Subject: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values To: Enric Balletbo i Serra , Hsin-Yi Wang , Fabien Parent Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Zhiyong Tao X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_012022_808960_BB0902ED X-CRM114-Status: UNSURE ( 7.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, I was looking at MTK pinctrl stuff upstream, and it seems there are a few `mediatek,pull-*-adv` entries that have invalid values: arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; According to the bindings, the values should 0~3. <10> is probably a incorrect attempt at using binary representation, which is wrong. This probably leads to the pull-up/down getting disabled or ignored. Cound people still working on these two devices take a look? Regards ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel