From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC0E0C6FA82 for ; Wed, 28 Sep 2022 07:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IxwKbPO8bssgieq4wRT2pBFbBA4s4AWXYw+aaC161YY=; b=45fTHuM4/D9uEs rdpnGAL1JzzENaXyDC++Mqg80Ob/oFntCTroA8XYW43niw5Fyi40Q4nRsQ406kSCullEgUKHFsczf Hp1yu05Ukx8419zOICf81VL//Jp5GA6BXS0rVMjTl1tBO9I8s4lKi9SHMs/rF8A3UunKrOrBCRPPS VJQOspv2cWYABwBM0CrMzZmTmW6CkiPoA00eAaGSCsZxidQSVlgO+yYxf3GMa4H3VxzPXHO0olXzb skc7qvvj02nFhsbRB+62Z0GmCPHc83OxY9Bip53vfAQYQTSCuIuBBWC2oSpaDk7lIMkbHcciRxKQp hxx09l0WZmX5YpAaKIVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odRpp-00EfXl-Ok; Wed, 28 Sep 2022 07:50:25 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odRpl-00EfVb-7D for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 07:50:23 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 23so3278661edw.5 for ; Wed, 28 Sep 2022 00:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=QiNIg/zYZ38dNte35yIrwLt22pv5Z8LWSBq+qCcfUtU=; b=NtzNSjvY4vyAUbLC8Ii0LP3f102njHedYSBGeDzF/hkB810Z7nZG7cmefrAHtpFxhe Zp9te2hkWiDhTDlHfjC2QXAsRum0CWIfAidozvY7YrY5zd9bMeLp3BBUkbc21Pm4fwYD bKKKOWtXTMb7XcHcBJO0GQJ2gYygtC4R68NE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=QiNIg/zYZ38dNte35yIrwLt22pv5Z8LWSBq+qCcfUtU=; b=sQfrvhkGPNErcw8nQKO2/fgKn+IaDWFb73oscjMLYH+ZUGT+AMir2+gUh4uc7ozSly 0FQxOO+aW/2MQSPxCIAFXRIFZCwnkIpxZAIVARInFysqvxZ9qNhgpsQERezPHi+04SaI 7lMshHgkr2YuadwC6mrGg4QgVDMJxB9wXIOx0LIkYDQ40Ooed5uZbCYqIJxupTde7l/K 5FjWRUCfpSKRWH9JtqevFAydF78r32VFYI8PMSBhKeGh/RMzDVswa3J3V1i5SEWgl30x M9p0Ej53mdwIGnd8LbvHuaP54uH+ajTB/nFuooX9t7yqgKBysSj05sOjRiqGNkILp09r 1O3Q== X-Gm-Message-State: ACrzQf0yYMdOp2hI+aUxckqwYfe8yygVT5p7zJK9IF1/nLCu4GbPMrUd uTVzJcw/PaGK44BuQCLlckH7wAh6rB9SNEEeLWF00A== X-Google-Smtp-Source: AMsMyM6tdHhfxNIYTWCDrGO48E5DQKirqL+MmjRR/T8+Ih7026PNLiu8XfmJTZnxopqbAP43SYNBrqxzsdSO9XaLHp4= X-Received: by 2002:a05:6402:1298:b0:457:c38a:2f10 with SMTP id w24-20020a056402129800b00457c38a2f10mr6387160edv.264.1664351418958; Wed, 28 Sep 2022 00:50:18 -0700 (PDT) MIME-Version: 1.0 References: <0a1618c4-b808-56bd-e89f-560b0423191d@collabora.com> <20220928015507.17206-1-miles.chen@mediatek.com> In-Reply-To: <20220928015507.17206-1-miles.chen@mediatek.com> From: Chen-Yu Tsai Date: Wed, 28 Sep 2022 15:50:07 +0800 Message-ID: Subject: Re: [PATCH 3/6] clk: mediatek: mt8192: Do not re-register top_early_divs in probe function To: Miles Chen Cc: angelogioacchino.delregno@collabora.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, mturquette@baylibre.com, sboyd@kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_005021_320236_CD6F6232 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 28, 2022 at 9:55 AM Miles Chen wrote: > > >> top_early_divs are registered in the CLK_OF_DECLARE_DRIVER() half of the > >> topckgen clk driver. Don't try to register it again in the actual probe > >> function. This gets rid of the "Trying to register duplicate clock ..." > >> warning. > >> > >> Signed-off-by: Chen-Yu Tsai > > > >Can't we simply remove the CLK_OF_DECLARE_DRIVER() and top_init_early entirely, > >and transfer TOP_CSW_F26M_D2 to top_divs[] instead? > >I get that systimer concern and we have something similar in MT8195, where the > >TOP_CLK26M_D2 is registered "late". > > Another reason for this: > Removing the CLK_OF_DECLARE_DRIVER() is good when we want to build our driver as > kernel modules because it does not work with kernel modules. I agree. But as I mentioned in my other reply, we need to fix the clock user first before dropping that clock. And there's also the matter of DT backward compatibility. So we need to do it incrementally. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel