From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B60BC07E99 for ; Fri, 9 Jul 2021 06:31:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 302AD6144A for ; Fri, 9 Jul 2021 06:31:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 302AD6144A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4uKuNlypj6ISRRqI+8WzWZkPU9vxFvV+ACrH/QPnHoI=; b=xCuVh2v1hWJIkm +akXm3+YRUReYc29V7BllEypM6sySH/bR4nq6kGTR1lEvngdwNgRBtXBY4uR/DRlG2ezXUcHJ16kP JI/9bYNZUfgUumjgGWCPqx4VRz8gYSxWn4lIxW01mccvTYjELw8KLMm3cNfkyR80xn8GV2ZNVFIWl Gbkk/m0agX16yAQagzehOpab2J9o1C/lIljdH4dpN7T/t8qjS1URtWNWpQoKHzpxYDBtqDnZ6I95Q +jxRXgGRXPmRFrrM9MscDwP11CTR7AVdDOJed9A9rDk3GOdNswq66XSze4Vjxvia7mhJ/CaUTKKfR dgcF3YIWelBojzXP1BFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1k1B-000sYX-Mu; Fri, 09 Jul 2021 06:29:45 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1k15-000sXE-Rv for linux-arm-kernel@lists.infradead.org; Fri, 09 Jul 2021 06:29:41 +0000 Received: by mail-lj1-x22b.google.com with SMTP id e20so6326093ljn.8 for ; Thu, 08 Jul 2021 23:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0rx0EbhWByOl6cO2pdh8SAXgIpsICZIPHug/dkp8j8A=; b=K65KQSyKS71qo3hjtjQy+Y3yBhrGXDAuaTt6jzAsnooUZXo2J8oG0tpn5NA01Vm2rK OSs3VphgbYYpymPYEoYMQfNT4+zKaiJSHeGAga2GHPIfhVEIr14FvLQ471ZZm19q2emT whq33uc06EG8sPFqkVKmJgjrar1rTea9O7Kzc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0rx0EbhWByOl6cO2pdh8SAXgIpsICZIPHug/dkp8j8A=; b=NYMUOq9pMXAD8sIexG7ffKTMRfiTDFQVmSAcZ10m/FFaEUMaQnMAME1HeIf6HqRwsi w/dXbQ4knIg9htA6QpqJcLxAj8Y+QP6/BtoEpKU/iJOfFLC3hYjBtb3ZEDuZqMsHJqNC J5NyB79GJpjjlkYythC70YJY/+g1gMUdFVDhhuKtXMXjefMfPj/ErLcgVeG0pXmtwg9+ 2ozyucuvSv1q8Jc59oopRldxo9t1rel1bblcx3h9kNHyiah6MEG+qTlo18sOL7b+5tAb 6RQnznSZcXMaaBpoUBcbqej5RRFdAlI+Q6R0B6aXrnsnAiGd8p+UAPvZGWUsggEiKVCE RaiA== X-Gm-Message-State: AOAM532Lf7U32FvlDi+Oi/pt2DnIamXHO1X1uRvDjid9PVwspId0x8eO G25WyOhgvSxvuSNV7xtMfq5SyMqLqFP7FJyVRUM8IA== X-Google-Smtp-Source: ABdhPJw6yDemUk5wkz0plF6I4pQaqZpW7hTyE9DIQd88yVnnamwNZrem1BKYanDJeNzgbs5JjEnnE681wN8bzDJ+uwo= X-Received: by 2002:a05:651c:2115:: with SMTP id a21mr27409410ljq.185.1625812176116; Thu, 08 Jul 2021 23:29:36 -0700 (PDT) MIME-Version: 1.0 References: <20210616224743.5109-1-chun-jie.chen@mediatek.com> <20210616224743.5109-12-chun-jie.chen@mediatek.com> In-Reply-To: <20210616224743.5109-12-chun-jie.chen@mediatek.com> From: Chen-Yu Tsai Date: Fri, 9 Jul 2021 14:29:24 +0800 Message-ID: Subject: Re: [PATCH 11/22] clk: mediatek: Add MT8195 mfgcfg clock support To: Chun-Jie Chen Cc: Matthias Brugger , Stephen Boyd , Nicolas Boichat , Rob Herring , linux-arm-kernel@lists.infradead.org, LKML , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_232939_950934_C099D6F2 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 17, 2021 at 7:08 AM Chun-Jie Chen wrote: > > Add MT8195 mfgcfg clock provider Same thing about the commit log. More context please. > Signed-off-by: Chun-Jie Chen > --- > drivers/clk/mediatek/Kconfig | 6 ++++ > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8195-mfg.c | 49 +++++++++++++++++++++++++++ > 3 files changed, 56 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt8195-mfg.c > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index ef7d4b433eee..066c14a89cee 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -624,6 +624,12 @@ config COMMON_CLK_MT8195_IPESYS > help > This driver supports MediaTek MT8195 ipesys clocks. > > +config COMMON_CLK_MT8195_MFGCFG > + bool "Clock driver for MediaTek MT8195 mfgcfg" > + depends on COMMON_CLK_MT8195 > + help > + This driver supports MediaTek MT8195 mfgcfg clocks. > + Same thing about the Kconfig option. I don't think it's necessary to have separate Kconfig options for clock controllers within the same SoC. > config COMMON_CLK_MT8516 > bool "Clock driver for MediaTek MT8516" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index 991a9be7ac46..9b09e7f640d1 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -87,5 +87,6 @@ obj-$(CONFIG_COMMON_CLK_MT8195_CAMSYS) += clk-mt8195-cam.o > obj-$(CONFIG_COMMON_CLK_MT8195_CCUSYS) += clk-mt8195-ccu.o > obj-$(CONFIG_COMMON_CLK_MT8195_IMGSYS) += clk-mt8195-img.o > obj-$(CONFIG_COMMON_CLK_MT8195_IPESYS) += clk-mt8195-ipe.o > +obj-$(CONFIG_COMMON_CLK_MT8195_MFGCFG) += clk-mt8195-mfg.o > obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o > obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o > diff --git a/drivers/clk/mediatek/clk-mt8195-mfg.c b/drivers/clk/mediatek/clk-mt8195-mfg.c > new file mode 100644 > index 000000000000..a9b1d337cd01 > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8195-mfg.c Code looks good. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel