From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12788C47078 for ; Fri, 21 May 2021 14:47:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CFBB61057 for ; Fri, 21 May 2021 14:47:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CFBB61057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FmGOec2f4PlfwiOMkCQqlX3/f6IYLRmrfCjuNvxu6kk=; b=CXh7+Nfboyi7p359lkYXUzUaFy HhGNdlPYfOXRsVQBHeLQL5M1Id77q2QiuOBHHsxJXBL3kTTkXt339P6RCe/aez7LbXL19YQM4tiou TEuIyHFOdK1pSidn+695QZOFDs6ZXl++w8nPaggi7BTb6U9PzbaRdx6vhgEuZMB6K8JK5GiyLDWIb 6Hc9E+lklyFF0b6ppKI9c3aoM4MXoCWy10ZAPv4eRv2uTg4Yg02jAyxFtCBWypdMHGdTQ8z++R6fN uCaxt+roqWsWnfrrvG5No8EHgvZtLP1Qv+QEPLosiMufBVqrpvAOWD+kwHumUmoBNl/ULOkSmd2sv rBAnkuPw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk6Ph-005oHM-BV; Fri, 21 May 2021 14:46:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk6PQ-005oDM-Al for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 14:45:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uOsFDhv1c3rYeM/biOU1mt6E1GzqKW1CDuSDPJ87gBg=; b=KYeVi08jYGVdSU0R3rohdfIcCx LI/r7VbS+QVl0ueWBNN4oFruRU5ju0J7lMaFdO0HiuvsGUWyvTSiEe4sz64nGFee2FgboDPG8rNUd Ol9gpetHdcDkkqAemmz4h0pwZlntQmfehHBq04US0Z6k7PBYpMAVKRBiNT6PcA6W2hjp4pcGpeMWo ue3L7YESkVm/LZ5r03qUuRvQB28tmSMkysTW7BsWckl5zRQnJWq1dX/j+8j1qBcNo4mqg225xKERT N09divWL0in6wqJneQ6AQcgpI8Ruis2Hah4kPv3lnRqGx111lr/8OWuqt3kz6Ho3+O4XP+a9hmMGJ hEHkGmhA==; Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk6PN-00HCbW-Aj for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 14:45:51 +0000 Received: by mail-lj1-x22b.google.com with SMTP id s25so24227985ljo.11 for ; Fri, 21 May 2021 07:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uOsFDhv1c3rYeM/biOU1mt6E1GzqKW1CDuSDPJ87gBg=; b=n2qwyuP1LnEDqSwud8bOvkR68TEYaKqXc8oI/yr+qYo1V/9Y7mIX2FSlKzA192fIGi 6R9nTLo1mKi0Z4iB8pCvyOf2RZBFi0wFr/Gg1P73WEDCGXJHPLuCTa2fs3wBjmGZ7oF6 FyjzcW9iyakYrXjWjqP9cRvwkkjeloZ2tUrQ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uOsFDhv1c3rYeM/biOU1mt6E1GzqKW1CDuSDPJ87gBg=; b=OgsqtR74SThaHIVjUaQWTcOxY8itZFMXR6m4GXwI4TUPx7s7Vfh+8gOqE4rxWbGA42 SOFmMFRlmaV0kiZQWbNdk7Esk7Lr34YcLxkMNkLkptStQe8STCgSyryAA8KoAjRl9h27 KLQplhYSe2gkG2mBWkTULNgazePd2gYbkfqCGl61NbqjTUTmvrxb0fFauXeQIhr+itzP vFebJ3Mn/3dgc/P8VnfxmY2VnQcimQQmugiYsDVSbFfwVedQKYJJdeN3WhFFjTso6+TE QPmMRZ0RoJ6v3BoNeZyhJLkdIwddFsSxXTIx5bs8VfdzWAbS4TW2O2RKNEAsDXyokjXp jmwQ== X-Gm-Message-State: AOAM5320Zu5ntQlhBbCUE6JUI5/02vh7jbuzVGDY+egI0tnUI0tFaahj xHFRKpbQopsO35i/xPG+Y8uugnTAdd1iK+3ZCyCO1g== X-Google-Smtp-Source: ABdhPJxANzTqCdHdUqkIIdiznQKltNQSijCrMEhvOw7yhFmeXbFanluhc0vMVcUKNnP3g3gOLA7OjrpUhlHnmL9o4SY= X-Received: by 2002:a2e:a554:: with SMTP id e20mr6930274ljn.23.1621608342766; Fri, 21 May 2021 07:45:42 -0700 (PDT) MIME-Version: 1.0 References: <20210521200038.v14.1.I9f45f5c1f975422d58b5904d11546349e9ccdc94@changeid> In-Reply-To: <20210521200038.v14.1.I9f45f5c1f975422d58b5904d11546349e9ccdc94@changeid> From: Chen-Yu Tsai Date: Fri, 21 May 2021 22:45:31 +0800 Message-ID: Subject: Re: [PATCH v14] arm64: dts: mt8183: Add node for the Mali GPU To: Nicolas Boichat Cc: Matthias Brugger , Rob Herring , Ezequiel Garcia , Steven Price , Neil Armstrong , hoegsberg@chromium.org, Tomeu Vizoso , boris.brezillon@collabora.com, Alyssa Rosenzweig , fshao@chromium.org, hsinyi@chromium.org, Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_074549_378568_794D2F3D X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org (Resent to all recipients) On Fri, May 21, 2021 at 8:01 PM Nicolas Boichat wrote: > > Add a basic GPU node for mt8183, as well as OPP table. > > Note that with the current panfrost driver, devfreq is not > actually functional, as the we do not have platform-specific > support for >1 supplies. Also, we are missing code to handle > frequency change, as the GPU frequency needs to be switched > away to a stable 26Mhz clock during the transition. > > Signed-off-by: Nicolas Boichat > --- > The binding we use with out-of-tree Mali drivers includes more > clocks, this is used for devfreq: the out-of-tree driver switches > clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then > switches clk_mux back to clk_main_parent: > (see https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.19/drivers/gpu/arm/midgard/platform/mediatek/mali_kbase_runtime_pm.c#423) > clocks = > <&topckgen CLK_TOP_MFGPLL_CK>, > <&topckgen CLK_TOP_MUX_MFG>, > <&clk26m>, > <&mfgcfg CLK_MFG_BG3D>; > clock-names = > "clk_main_parent", > "clk_mux", > "clk_sub_parent", > "subsys_mfg_cg"; > (based on discussions, this probably belongs in the clock core) > > This only matters for devfreq, that is disabled anyway as we don't > have platform-specific code to handle >1 supplies. Yes. This can be done with clk_notifiers. See https://elixir.bootlin.com/linux/latest/source/drivers/clk/sunxi-ng/ccu_mux.c#L261 for such an example. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel