From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6802C433F5 for ; Sun, 17 Oct 2021 16:16:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DD0D611AF for ; Sun, 17 Oct 2021 16:16:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8DD0D611AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date :From:In-Reply-To:References:MIME-Version:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W9Cdy1cwRmOCHGVjY5lDmbSmCZZeJTDQEp1Lu8GqMgE=; b=PDN0q1MLzEDMg7 Z+xBg4zdabusUlBGPYq0CBbI7jBbJIbuUcb/Y8DIHuQrEElYllpZkNss65FMBevu3UTQW9pkQjrPi CoNpMcK0BtkIY5zPhgJ2HCNVoNW3dGFMzHe42j0gDqudp77ghmb4K1XbY4IXpLfcS/ia/QVaZULcH 9wupQVVS0XaBnMgWhH+lwrt5P/WYo6fX1UzV3FRwPwyNhtDMI8i0AGgs9v9c/6gmNct9hRMMN+etV 61NewJDwxHAxqxlUQdOgIQw0pLpmJ4Fsw9mf9A2//OWfEmPxIUbY4wgSMS1+Ea9bJwDbew5s/3HnK xeIZtXz9R/rhCDFx8Zkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mc8p1-00CxwD-01; Sun, 17 Oct 2021 16:15:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mc8ox-00Cxvs-Hu for linux-arm-kernel@lists.infradead.org; Sun, 17 Oct 2021 16:15:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A03D961211 for ; Sun, 17 Oct 2021 16:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634487334; bh=NR0i8xuyz21CIQ5+eMJSeLInFgmTs8TjqG5OtNwG/2c=; h=References:In-Reply-To:Reply-To:From:Date:Subject:To:Cc:From; b=pfBleX46C2dXs7nhKTtkOxAY8rRC8Qolc/vNi3JFJtlJ0C4T5lwNG0EoEc/9n9qHh oWXqOCkHtt4NelHbXt4rb6LJ36tP4P0aus1aCT1Q1feFxSmYJaqleuebh0HdCfWOyF I//UVl3xxP7knwvcQwPOqaSwoEbqmHB+KxWnD46bk07VW/VGH3lWEgmdTw/bBPLNRa Cg7aBkeaFpgBjnvnT7/sEhqXzS1Bw36t4E5YnKbf8YtEcn9FWIdseEXmitL1Pr+BUD y8nAsc2TtK0FiO6Jy8UosxV/hG6ks2B6hbHdEPElEslUs/ZEUFAkkyFjDOSUDaa9vM ipFcClwYap95g== Received: by mail-ua1-f49.google.com with SMTP id j8so613690uak.9 for ; Sun, 17 Oct 2021 09:15:34 -0700 (PDT) X-Gm-Message-State: AOAM533SPurwVBjHpA3OcH3Nbgapchue2u7aiJVt0Rx+Utjv5iqF8s3S UMnFGu65URnQvgY1blnDGRHx4XdK5wV9xJBvbdE= X-Google-Smtp-Source: ABdhPJw7jo41DrBPvwc6sU+NQKiYDlVifgGimi3V8dhfLLK78RDA5UW+pWXJIPjKPJKissQrMZXm7WlWc/AKHq2L/js= X-Received: by 2002:a67:d38e:: with SMTP id b14mr24280823vsj.13.1634487333689; Sun, 17 Oct 2021 09:15:33 -0700 (PDT) MIME-Version: 1.0 References: <20211016105022.303413-1-martin.blumenstingl@googlemail.com> <128bdf6e-f613-048b-4397-88f9ba8fd023@gmail.com> In-Reply-To: <128bdf6e-f613-048b-4397-88f9ba8fd023@gmail.com> From: Chen-Yu Tsai Date: Mon, 18 Oct 2021 00:15:21 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH clk-fixes v1 0/2] Fix clk-composite to support .determine_rate To: Alex Bee Cc: Martin Blumenstingl , linux-clk , Stephen Boyd , linux-arm-kernel , Mike Turquette X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211017_091535_661226_AD5CE156 X-CRM114-Status: GOOD ( 20.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wens@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 16, 2021 at 7:51 PM Alex Bee wrote: > > Hi Martin, Hi Stephen, > > Am 16.10.21 um 12:50 schrieb Martin Blumenstingl: > > Alex reports [0] that commit 69a00fb3d69706 ("clk: divider: Implement > > and wire up .determine_rate by default") breaks Rockchip platforms > > because the parent is not considered anymore. This is because > > clk-composite skips the "best parent" selection when > > rate_ops.determine_rate is set. Above commit does this by adding > > clk_divider_ops.determine_rate by default (then the Rockchip platform > > drivers are using clk_divider_ops as rate_ops in clk-composite). > > > > With these two patches a revert of above commit is not needed anymore > > (which would result in a revert of five follow-up commits as well). > > Instead the first patch changes the order so clk_divider_ops which > > has both, .determine_rate and .round_rate are supported by clk-divider > > (again). > > The second patch makes clk-composite use (and even prefer) > > rate_ops.determine_rate when available. > > > > Special thanks to Alex for his patience and helping test these patches > > off-list (since I don't have any board with Rockchip SoC). > > > > At least the first patch should go into -fixes. > > > > > > [0] https://lore.kernel.org/linux-clk/4eb964ac-4fff-b59d-2660-2f84d8af5901@gmail.com/ > > thanks for looking into this and fixing .determine_rate + mux as well > for making this future-proof. > > Both [PATCH 1/2] as a standalone fix, as well as [PATCH 1/2] and [PATCH > 2/2] in combination are > > Tested-by: Alex Bee > Tested-by: Chen-Yu Tsai # on NanoPi M4B and M4V2 showing SDIO back at around 150 MHz. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel