Re: [linux-sunxi] [PATCH 3/3] ARM: dts: sun8i: s3: switch PineCube to use OHCI/EHCI only - Chen-Yu Tsai

From: Chen-Yu Tsai <wens@csie.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: devicetree <devicetree@vger.kernel.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	inux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] [PATCH 3/3] ARM: dts: sun8i: s3: switch PineCube to use OHCI/EHCI only
Date: Mon, 23 Nov 2020 11:29:41 +0800	[thread overview]
Message-ID: <CAGb2v64SW7fh0ManX59c1Vbq+Etf8QVorwSfxZx4fjDPgcqeOg@mail.gmail.com> (raw)
In-Reply-To: <20201122004011.1957325-2-icenowy@aosc.io>

On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng <icenowy@aosc.io> wrote:
>
> The PineCube board features a USB Type-A connector connected to the
> SoC's USB pins.
>
> As this is not designed for being used as a USB device, disable OTG
> controller and route USB to OHCI/EHCI fixedly.

"Fixedly" does not mean what you likely intended here. "Permanently"
is probably closer.

However since the changes don't actually deal with the routing,
which IIRC is done in the PHY driver, I suggest just dropping
that part.

ChenYu

>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  arch/arm/boot/dts/sun8i-s3-pinecube.dts | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-s3-pinecube.dts b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> index 4aa0ee897a0a..c4177c54ef29 100644
> --- a/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> +++ b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> @@ -78,6 +78,12 @@ csi1_ep: endpoint {
>         };
>  };
>
> +&ehci0 {
> +       phys = <&usbphy 0>;
> +       phy-names = "usb";
> +       status = "okay";
> +};
> +
>  &emac {
>         phy-handle = <&int_mii_phy>;
>         phy-mode = "mii";
> @@ -158,6 +164,12 @@ &mmc1 {
>         status = "okay";
>  };
>
> +&ohci0 {
> +       phys = <&usbphy 0>;
> +       phy-names = "usb";
> +       status = "okay";
> +};
> +
>  &pio {
>         vcc-pd-supply = <&reg_dcdc3>;
>         vcc-pe-supply = <&reg_ldo3>;
> @@ -224,11 +236,6 @@ &uart2 {
>         status = "okay";
>  };
>
> -&usb_otg {
> -       dr_mode = "host";
> -       status = "okay";
> -};
> -
>  &usbphy {
>         usb0_vbus-supply = <&reg_vcc5v0>;
>         status = "okay";
> --
> 2.28.0
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201122004011.1957325-2-icenowy%40aosc.io.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel