From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78904C5519F for ; Mon, 23 Nov 2020 03:31:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12E5320727 for ; Mon, 23 Nov 2020 03:31:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="StLX4sk3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12E5320727 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m3FTFT0kD65Bfy6zjDMDcguIpoxL+NspX6z3XC7uMa4=; b=StLX4sk3d68kq/GqLHNZ28LH5 qvO5Sa/wptnCu/qUdqW0x/aVUa46ElSyiaYmsGv91vovNdQAtNCkeFXdVtU5PaNV5WAOevUIrNbHh 7luyh0hWVpckFfFho4dGcoe2rUiZe3rLMZaY32GMb/p13Rs92/Xmz1JdLqVBOgV0ABRyW+gURqNZ+ u9dNNEQweaoi/P0+hKxqMKYq1hkmgWaFn/TtBrVmz4ccE8cM1lfUN3TybO6dkysJcO7OEk1jJBJls YmR2bNBrxYMtAqncnaTjCADYCi6Apwr4NcDrftrkOG1xZrM61LeshkZbaDpC4jxBykJerUYxdEKRo WA+/2XPeQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh2YB-0008Tn-Am; Mon, 23 Nov 2020 03:29:59 +0000 Received: from mail-ua1-f65.google.com ([209.85.222.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh2Y8-0008TQ-Ie for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 03:29:57 +0000 Received: by mail-ua1-f65.google.com with SMTP id r23so5238301uak.0 for ; Sun, 22 Nov 2020 19:29:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7T2HYgVH3ouZttZmgDKuE4sKyWmEZpHuwuD0BSApWfs=; b=kdyJ2/tXdaraclfMM1I45fZ3hRvDju6jhopDgbRdsC8OOsotq3qAMdZF6kFXf6X1jv PfvW8epQDAB4FYaTXHt13hfSbWI8rQtX8AUj+1MBJm5tQovsSr0Y9AKzTWAi9u7gahhD MzsN7EFVWI3nQHrTfEBOLqBDm98puImOGbpntVKfI6gegzoNNpzTVa2z+OVjxRIl6f99 hXpWusMTZ2vH7dHaEkgHqFKg9gRty1SB1rYxfqhBF5PoXz4tL4yyZSdds4aMHdzyLW6t oiXwb+tMZwdJ5e3E/eIWHFCijqRcwCNY9EbpzsBsIY+pbB/tYrMCTz2gfFjt7Yq2md1h +mLA== X-Gm-Message-State: AOAM530UKOv5RUPov/fMIN5w2UZemY+3tK49JaznMTkUDxAo5X9dZOCB K0MLKJBF6n5YPMCvKgFwBb/8Bkk5aRoFdw== X-Google-Smtp-Source: ABdhPJxVrGN3wss0NErPQ9sg2UFD7/yQ91Wvvu0ALTohWnoBnzw2zZPv4r9xWnsOlHBw+KtRNjeGjA== X-Received: by 2002:ab0:2bd1:: with SMTP id s17mr17163034uar.36.1606102192863; Sun, 22 Nov 2020 19:29:52 -0800 (PST) Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com. [209.85.221.173]) by smtp.gmail.com with ESMTPSA id 187sm1149845vsv.6.2020.11.22.19.29.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Nov 2020 19:29:52 -0800 (PST) Received: by mail-vk1-f173.google.com with SMTP id w67so3656550vke.10 for ; Sun, 22 Nov 2020 19:29:50 -0800 (PST) X-Received: by 2002:a1f:288a:: with SMTP id o132mr17160728vko.2.1606102190747; Sun, 22 Nov 2020 19:29:50 -0800 (PST) MIME-Version: 1.0 References: <20201122003841.1957034-1-icenowy@aosc.io> <20201122004011.1957325-2-icenowy@aosc.io> In-Reply-To: <20201122004011.1957325-2-icenowy@aosc.io> From: Chen-Yu Tsai Date: Mon, 23 Nov 2020 11:29:41 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH 3/3] ARM: dts: sun8i: s3: switch PineCube to use OHCI/EHCI only To: Icenowy Zheng X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201122_222956_624429_ED820F47 X-CRM114-Status: GOOD ( 23.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , inux-kernel@vger.kernel.org, Maxime Ripard , linux-sunxi , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng wrote: > > The PineCube board features a USB Type-A connector connected to the > SoC's USB pins. > > As this is not designed for being used as a USB device, disable OTG > controller and route USB to OHCI/EHCI fixedly. "Fixedly" does not mean what you likely intended here. "Permanently" is probably closer. However since the changes don't actually deal with the routing, which IIRC is done in the PHY driver, I suggest just dropping that part. ChenYu > > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-s3-pinecube.dts | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-s3-pinecube.dts b/arch/arm/boot/dts/sun8i-s3-pinecube.dts > index 4aa0ee897a0a..c4177c54ef29 100644 > --- a/arch/arm/boot/dts/sun8i-s3-pinecube.dts > +++ b/arch/arm/boot/dts/sun8i-s3-pinecube.dts > @@ -78,6 +78,12 @@ csi1_ep: endpoint { > }; > }; > > +&ehci0 { > + phys = <&usbphy 0>; > + phy-names = "usb"; > + status = "okay"; > +}; > + > &emac { > phy-handle = <&int_mii_phy>; > phy-mode = "mii"; > @@ -158,6 +164,12 @@ &mmc1 { > status = "okay"; > }; > > +&ohci0 { > + phys = <&usbphy 0>; > + phy-names = "usb"; > + status = "okay"; > +}; > + > &pio { > vcc-pd-supply = <®_dcdc3>; > vcc-pe-supply = <®_ldo3>; > @@ -224,11 +236,6 @@ &uart2 { > status = "okay"; > }; > > -&usb_otg { > - dr_mode = "host"; > - status = "okay"; > -}; > - > &usbphy { > usb0_vbus-supply = <®_vcc5v0>; > status = "okay"; > -- > 2.28.0 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201122004011.1957325-2-icenowy%40aosc.io. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel