Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Bhushan Shah <bshah@kde.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH 2/2] arm64: allwinner: h6: enable i2c0 in PineH64
Date: Mon, 12 Aug 2019 12:19:17 +0800
Message-ID: <CAGb2v65xDCNywexZGW=EBrsJwm-KwANxpdCv-AM2sgVNbz6qQQ@mail.gmail.com> (raw)
In-Reply-To: <20190811090503.32396-3-bshah@kde.org>

On Sun, Aug 11, 2019 at 5:05 PM Bhushan Shah <bshah@kde.org> wrote:
>
> i2c0 bus is exposed by PI-2 BUS in the PineH64, model B.
>
> Signed-off-by: Bhushan Shah <bshah@kde.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> index 684d1daa3081..a184361bc10d 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> @@ -160,6 +160,14 @@
>         vcc-pg-supply = <&reg_aldo1>;
>  };
>
> +&i2c0 {
> +       status = "okay";

We don't enable interfaces that are exposed on the extension headers
by default. Instead we let the users enable it themselves, by modifying
the device tree either with overlays or through U-boot commands.

Please set this to "disabled", and add a comment mentioning that it is
on the PI-2 BUS. Having it explicitly listed in the source serves as a
pointer to people looking at how to enable stuff.

ChenYu

> +};
> +
> +&i2c0_pins {
> +       bias-pull-up;
> +};
> +
>  &r_i2c {
>         status = "okay";
>
> --
> 2.17.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-11  9:05 [PATCH 0/2] Enable the I2C nodes for Allwinner H6 CPU Bhushan Shah
2019-08-11  9:05 ` [PATCH 1/2] arm64: allwinner: h6: add I2C nodes Bhushan Shah
2019-08-12  4:12   ` Chen-Yu Tsai
2019-08-11  9:05 ` [PATCH 2/2] arm64: allwinner: h6: enable i2c0 in PineH64 Bhushan Shah
2019-08-12  4:19   ` Chen-Yu Tsai [this message]
2019-08-16  6:47 ` [PATCH v2 0/3] Enable the I2C nodes for Allwinner H6 CPU Bhushan Shah
2019-08-16  6:47   ` [PATCH v2 1/3] dt-bindings: i2c: mv64xxx: Add compatible for the H6 i2c node Bhushan Shah
2019-08-16  6:47   ` [PATCH v2 2/3] arm64: allwinner: h6: add I2C nodes Bhushan Shah
2019-08-16  7:50     ` Maxime Ripard
2019-08-16  8:23       ` Bhushan Shah
2019-08-16  6:47   ` [PATCH v2 3/3] arm64: allwinner: h6: add i2c0 node in PineH64 Bhushan Shah
2019-08-16  7:52     ` Maxime Ripard
2019-08-16  8:21       ` Bhushan Shah
2019-08-16  8:43   ` [PATCH v3 0/2] Enable the I2C nodes for Allwinner H6 CPU Bhushan Shah
2019-08-16  8:43     ` [PATCH v3 1/2] dt-bindings: i2c: mv64xxx: Add compatible for the H6 i2c node Bhushan Shah
2019-08-16 19:44       ` Rob Herring
2019-08-16  8:43     ` [PATCH v3 2/2] arm64: allwinner: h6: add I2C nodes Bhushan Shah
2019-08-16 11:33       ` Maxime Ripard

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGb2v65xDCNywexZGW=EBrsJwm-KwANxpdCv-AM2sgVNbz6qQQ@mail.gmail.com' \
    --to=wens@csie.org \
    --cc=bshah@kde.org \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox