From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EE5C32756 for ; Mon, 12 Aug 2019 04:19:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BBCB2085A for ; Mon, 12 Aug 2019 04:19:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Awo6Qm6E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BBCB2085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xeBQjw2d/G6m3+g4uHbt09oKAXJWZ6h08wucnLMd40s=; b=Awo6Qm6ESV7J+L el2EujEjFUDv4nNnwPkZaissRUiJK818S0BJT3jEsgK0yySCYtJVPsg8kXdii9PzE332DxwCtoCSW UvG9gjiBK2ddBiSWc8iJjAF/HRUYZmYXOTUIt+dAjpbkxaORlomiILPiZaiXFVmyivOcepnmN0rFP y4eNWYldBN2PsN3hp7TFT+zFaeqnh0mpu2Vl6/rw0RYhVUYXW0Rn4haDbuNpUV6M6nRxPRdHd9i1n bffPTdzPVDDVf4f2JmalArFu3T/dtsVvYdHD+ynrMJB9n/2RG6kIBQuhebFlDBxJtlSLImLmSvaOd 0ICPQKFXIquCLE6KhdHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hx1nx-0003Iz-EV; Mon, 12 Aug 2019 04:19:33 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hx1nu-0003Ia-Uk for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2019 04:19:32 +0000 Received: by mail-ed1-f66.google.com with SMTP id w5so13962277edl.8 for ; Sun, 11 Aug 2019 21:19:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z4s3JUibN+WGVLqaHsLHxXIi1D8VvPq6c/60ITp5nIA=; b=taLl4DBtF5sBK1raQeooSbh20+yCtVBMOsrbRy0S71Au7dF3GBCN2XjLN+EU35bH6y Pjpqk/oQEhQ1dEDshJmWllXlipIJtIJsG9aveD3/0dnkbzF849/W/CjOP8mU6CAk7TeS kSbqYUq7QOpQvkrv6vq56658hKRw4hYuV3e5KI9MiZm82eHfoog48Lt/yIpnuZQYn3FL KjH6LCc3OOllIB+pqMKKK281ov2JdrftCM8yyrCNgxRMFv4djUmmv3c+lYEcjbn9Qb6J 2PtKUdzOv5Y6jNiFeVtYAXjvIEHlrMWZiNqrAuH2lZs0TL8/A/FNTrhmjVCcT9uI1ovf bwcg== X-Gm-Message-State: APjAAAXKTrSI48rPp3noH+9MuybuwzfkluUI7NuOLZymOKRcq4ujF3tz Qn1TNJp82UxEfxYtFhPui19GFPB7KdM= X-Google-Smtp-Source: APXvYqyGCIRo5IsOmVUvGxUdSAlEfVjfV6ywwV+BO8zBxREG+7krt7dqD6QhtLme3unThNII3/TQuQ== X-Received: by 2002:a17:906:e2c2:: with SMTP id gr2mr29305260ejb.284.1565583569259; Sun, 11 Aug 2019 21:19:29 -0700 (PDT) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com. [209.85.128.48]) by smtp.gmail.com with ESMTPSA id b18sm2006307eju.0.2019.08.11.21.19.28 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 11 Aug 2019 21:19:28 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id e8so9733493wme.1 for ; Sun, 11 Aug 2019 21:19:28 -0700 (PDT) X-Received: by 2002:a05:600c:292:: with SMTP id 18mr25156704wmk.51.1565583568180; Sun, 11 Aug 2019 21:19:28 -0700 (PDT) MIME-Version: 1.0 References: <20190811090503.32396-1-bshah@kde.org> <20190811090503.32396-3-bshah@kde.org> In-Reply-To: <20190811090503.32396-3-bshah@kde.org> From: Chen-Yu Tsai Date: Mon, 12 Aug 2019 12:19:17 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] arm64: allwinner: h6: enable i2c0 in PineH64 To: Bhushan Shah X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190811_211930_992728_81C2B271 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Maxime Ripard , linux-kernel , Rob Herring , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 11, 2019 at 5:05 PM Bhushan Shah wrote: > > i2c0 bus is exposed by PI-2 BUS in the PineH64, model B. > > Signed-off-by: Bhushan Shah > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > index 684d1daa3081..a184361bc10d 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > @@ -160,6 +160,14 @@ > vcc-pg-supply = <®_aldo1>; > }; > > +&i2c0 { > + status = "okay"; We don't enable interfaces that are exposed on the extension headers by default. Instead we let the users enable it themselves, by modifying the device tree either with overlays or through U-boot commands. Please set this to "disabled", and add a comment mentioning that it is on the PI-2 BUS. Having it explicitly listed in the source serves as a pointer to people looking at how to enable stuff. ChenYu > +}; > + > +&i2c0_pins { > + bias-pull-up; > +}; > + > &r_i2c { > status = "okay"; > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel