From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1763C4360C for ; Fri, 4 Oct 2019 06:34:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 749F42084D for ; Fri, 4 Oct 2019 06:34:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J6Ws0jrk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 749F42084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NPLBv5rZ33fGdkaYZmiL4inet6SbG2Q/w2UySGsqHmY=; b=J6Ws0jrkteetQT MtZA6r6HRiZCjsleleRD5F+0Ir37WJkcPtqhJv/l1VPKn17RBXwWucj7M0nCRFT9HDZWScD6g4zJf sqZ6EcgKMwl+E/A6TN4dyppqdvmfYlstjJlMzselkTJbH/RnyghFSn4jsSmse+IBes6QDlwVRefpc B+CalHYcgl07d5jwwQVLgothAY62p9Nb3i1J1oAYYv/2rN2yccMq4/jv464D1PVDVfAA2h4jxIt+6 sT4C48wNo4FZuT50JQ0JfMHvn6KXINst1wymUYB3ii0TvbkFuk5MOmuvHt47PE/Id0sYK9BdhyD/8 OVkuq7+9EEjntx8vInkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGHA7-0000zx-UZ; Fri, 04 Oct 2019 06:33:59 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGHA4-0000yv-Ev for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2019 06:33:58 +0000 Received: by mail-ed1-f65.google.com with SMTP id l21so4801627edr.5 for ; Thu, 03 Oct 2019 23:33:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zVav5b67jOhOUHde3yp5NM10b2GKEryZinKkHvIneDo=; b=XAM5d6Zi6Jkfa6CMPkDnOckVlOEbUJ0nkKbwaazh8vl3NYLM4h2psZJ2E6hU+Ya2YI AEmoFDdoJTZYCM7BHaqn5svrPy3yItID7SNxztakHtaMhWkkPBDf0+A78amJ3DBzF0qJ O+gugu2fhILPKtKacN3vTFRu6mtSRq3cqQ86OnzPQXXPS7BZzAxPP3UeeeBxK/iSzJYc Egnu4Cqbys1NTYRGf44J6R5Udwtd5P9Pia2Uk6IuKhc50zBeaOgbbYYi0eTpeWVHf3pC Ur05v742+ZB2Wq26QATSIjNlGjyQKrpnIHweabbmU7u0ekuxanJwc4FRj0IkQq6DYuwx WfZQ== X-Gm-Message-State: APjAAAUaWDZpBBGppDFBqFrHsftoeD3/MXjzo1IXnDMQ7JU4e7W4rsjG ahMGS6+Np4RiQCPWNzaarTSUVksiEEc= X-Google-Smtp-Source: APXvYqwA+egdCmB1+oYvoeCnFvdz2ipxJL87f0EEb3nK6WFY6aotpEtb6FBQRSVCmgWCjMUXjTvFIA== X-Received: by 2002:a17:906:b204:: with SMTP id p4mr11078913ejz.185.1570170833504; Thu, 03 Oct 2019 23:33:53 -0700 (PDT) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com. [209.85.128.43]) by smtp.gmail.com with ESMTPSA id c15sm913204edl.16.2019.10.03.23.33.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2019 23:33:53 -0700 (PDT) Received: by mail-wm1-f43.google.com with SMTP id i16so4480945wmd.3 for ; Thu, 03 Oct 2019 23:33:52 -0700 (PDT) X-Received: by 2002:a7b:ce91:: with SMTP id q17mr9335703wmj.25.1570170832661; Thu, 03 Oct 2019 23:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20191003154842.248763-1-mripard@kernel.org> <20191003163754.26ciq2ljcbuuvcrx@gilmour> In-Reply-To: <20191003163754.26ciq2ljcbuuvcrx@gilmour> From: Chen-Yu Tsai Date: Fri, 4 Oct 2019 14:33:41 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191003_233356_504184_EE162CEA X-CRM114-Status: GOOD ( 25.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Rob Herring , Sakari Ailus , Mauro Carvalho Chehab , Frank Rowand , linux-arm-kernel , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 4, 2019 at 12:37 AM Maxime Ripard wrote: > > Hi, > > On Thu, Oct 03, 2019 at 11:51:05PM +0800, Chen-Yu Tsai wrote: > > On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > > > > > It turns out that what was thought to be the module clock was actually the > > > clock meant to be used by the sensor, and isn't playing any role with the > > > CSI controller itself. Let's drop that clock from our binding. > > > > > > Fixes: c5e8f4ccd775 ("media: dt-bindings: media: Add Allwinner A10 CSI binding") > > > Reported-by: Chen-Yu Tsai > > > Signed-off-by: Maxime Ripard > > > --- > > > .../devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml | 7 ++----- > > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > > index 5dd1cf490cd9..d3e423fcb6c2 100644 > > > --- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > > @@ -27,14 +27,12 @@ properties: > > > clocks: > > > items: > > > - description: The CSI interface clock > > > - - description: The CSI module clock > > > - description: The CSI ISP clock > > > - description: The CSI DRAM clock > > > > > > clock-names: > > > items: > > > - const: bus > > > - - const: mod > > > - const: isp > > > - const: ram > > > > > > @@ -89,9 +87,8 @@ examples: > > > compatible = "allwinner,sun7i-a20-csi0"; > > > reg = <0x01c09000 0x1000>; > > > interrupts = ; > > > - clocks = <&ccu CLK_AHB_CSI0>, <&ccu CLK_CSI0>, > > > - <&ccu CLK_CSI_SCLK>, <&ccu CLK_DRAM_CSI0>; > > > - clock-names = "bus", "mod", "isp", "ram"; > > > + clocks = <&ccu CLK_AHB_CSI0>, <&ccu CLK_CSI_SCLK>, <&ccu CLK_DRAM_CSI0>; > > > + clock-names = "bus", "isp", "ram"; > > > > I believe what we thought was the ISP clock is actually the module clock > > for the whole CSI subsystem. So we should still use the module clock entry, > > and remove the ISP entry. > > I'm really not sure it is. CSI1 on the A20 (possibly the A10 as well, > I haven't checked), and the one on the A13 don't have any ISP embedded > in the CSI controller. > > It makes some difference, because according to the BSP, you can see > that the ISP clock is taken for CSI0: > https://github.com/linux-sunxi/linux-sunxi/blob/sunxi-3.4/drivers/media/video/sun4i_csi/csi0/sun4i_drv_csi.c#L389 > > While for CSI1, that block is commented out, and the ISP clock never > used: > https://github.com/linux-sunxi/linux-sunxi/blob/sunxi-3.4/drivers/media/video/sun4i_csi/csi1/sun4i_drv_csi.c#L396 > > So I really believe that the ISP clock is here to feed the ISP block > within the CSI controller if there's any. But it's far from always the > case, as opposed to a module clock for the whole CSI controller that > would be here in both cases. I guess we should try to test this with CSI1 one, either on a Cubieboard or OlinuXino with a simple camera like the OV7670? Do you have any hardware on hand for this? I have the Cubieboard but I need to get some proper 2.0mm connector blocks. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel