From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0
Date: Fri, 25 Jul 2014 00:17:20 +0800 [thread overview]
Message-ID: <CAGb2v66jhspz7ornqQ0UXy6cRXptbOvUhQPX6jYttyCqmkZaxA@mail.gmail.com> (raw)
In-Reply-To: <20140724160141.GZ20328@lukather>
On Fri, Jul 25, 2014 at 12:01 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Jul 24, 2014 at 09:19:18PM +0800, Chen-Yu Tsai wrote:
>> > This patch also changes the GPIO bindings for R_PIO:
>> >
>> > gpios = <&r_pio B N flag>;
>> >
>> > Where B originally was the pinbank label (L or M) counted from A,
>> > with this patch it becomes (L or M) counted from its pinbank base (L).
>> >
>> > Thus
>> >
>> > gpios = <&r_pio 10 11 0>; /* PL11 */
>> >
>> > becomes
>> >
>> > gpios = <&r_pio 0 11 0>; /* PL11 */
>> >
>> > IMO this is correct, as the binding shows the bank offset and pin offset
>> > within the bank for the GPIO controller. But I'm worried it might be a
>> > bit confusing.
>>
>> I see you Acked this patch, but also in your reply to my cover letter,
>> you mentioned that you want absolute pin numbers matching the datasheets.
>> What about the GPIO DT bindings, as I explained above?
>>
>> Just double checking. Thanks.
>
> I'd like it to have the absolute numbers in sysfs, but the relative
> one in the DT. But I guess it's already what's happening, right?
That's right. Just checking. :)
ChenYu
next prev parent reply other threads:[~2014-07-24 16:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 17:24 [PATCH 0/2] pinctrl: sunxi: misc improvements for gpio Chen-Yu Tsai
2014-07-14 17:24 ` [PATCH 1/2] pinctrl: sunxi: use gpiolib API to mark a GPIO used as an IRQ Chen-Yu Tsai
2014-07-24 11:46 ` Maxime Ripard
2014-07-28 10:11 ` Linus Walleij
2014-07-14 17:24 ` [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0 Chen-Yu Tsai
2014-07-24 12:48 ` Maxime Ripard
2014-07-24 13:19 ` Chen-Yu Tsai
2014-07-24 16:01 ` Maxime Ripard
2014-07-24 16:17 ` Chen-Yu Tsai [this message]
2014-07-28 10:14 ` Linus Walleij
2014-07-22 16:33 ` [PATCH 0/2] pinctrl: sunxi: misc improvements for gpio Linus Walleij
2014-07-24 12:57 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v66jhspz7ornqQ0UXy6cRXptbOvUhQPX6jYttyCqmkZaxA@mail.gmail.com \
--to=wens@csie.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).