From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC1AC43381 for ; Tue, 19 Mar 2019 03:00:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF7922084F for ; Tue, 19 Mar 2019 03:00:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QTek7e8g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF7922084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PU1YQdtvUq5FYr25Tn4ZCpxT3ucsAcoQUUrTrfup3Qg=; b=QTek7e8gNikxlf t/PzTFFTYwkcUrUZvsnhnJ/vEVnktytqP6Sd6kGhEMZ+U6TRRg/OTmBxuj9mbr69gpzwOwlwObkep 8LaEIRxavwyEJNgJNQIJrgSEdChHzb+xtlmPFdH0+kytUvF0fEeQFf/uO35tQyXV1iqPj4yk2zDnK UZ2rOIkVr1HYOmOCDuVzXqaOMC8kv9NZVoBJyb31vj8Kfg6sn6+GnqePzxc3ZUWlvhfCUMmEdziiC rx0aWNfC6krwyreVpAf1KURS3TbVi59obtypIdFn16xjoQQazTXqXs2GI/chXk05vJ28UWGFx/ruf dl4aiO6D0fDO4VS8BQ1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h64yj-0007OF-Nk; Tue, 19 Mar 2019 02:59:49 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h64yf-0007NM-J8 for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2019 02:59:47 +0000 Received: by mail-ed1-f68.google.com with SMTP id m12so15292122edv.4 for ; Mon, 18 Mar 2019 19:59:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n7ojKRYeZtXOJ5vfzkQgeS1VXXSdZA7o61qO8RoD8FI=; b=UMD2N4TA/2fqIBrgGixoLkPwkEUqbQArqIcrGY9Oh3H40pBsGdvnEPHv9R6DaVt0Pt IaL/BS4sio/h249y1KVZhVKhM56tCOb8ViO1b8OsCoWKQe88lXsCgY/MEGz+4piPPxCF wLVNk1t0vPPUvx3RI61AMAa+FNnCllzGtZ2J9C5wQC+bIgB+Wg/rLtfK3+6EcBvktEE7 hli+g/SaHFMyBNtoPO/gQW/vqCDA2u+BhHBtu76ALYsD7yskguCjNS1v/Qi7tlVvnPcL Y1XkbBpX6NWPURSvFF/d3xefUY5cezwFUZFzx7H6wXf4Yg67CZwYfLs3Cqjgr/i6T/JQ 6d2Q== X-Gm-Message-State: APjAAAVVRmSj7gsHBii+K8AZSrE/8jXBGurZlSpoZyGrSrrl/QSaGIiW Vv1RlMgl65le/6nvNP8GKf7mDA1mj7o= X-Google-Smtp-Source: APXvYqyehu0OP6L0CtYDyPKspFoXVE8RqY/G4fuRUy7XP5DdRJVt1lbS5JlbPbk8U5ITk9JE647/TQ== X-Received: by 2002:a17:906:6b04:: with SMTP id q4mr12918082ejr.88.1552964380006; Mon, 18 Mar 2019 19:59:40 -0700 (PDT) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com. [209.85.221.43]) by smtp.gmail.com with ESMTPSA id i20sm2777951ejv.26.2019.03.18.19.59.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 19:59:39 -0700 (PDT) Received: by mail-wr1-f43.google.com with SMTP id p1so19280596wrs.8 for ; Mon, 18 Mar 2019 19:59:39 -0700 (PDT) X-Received: by 2002:adf:ec87:: with SMTP id z7mr14526153wrn.44.1552964378892; Mon, 18 Mar 2019 19:59:38 -0700 (PDT) MIME-Version: 1.0 References: <20190315130825.9005-1-jagan@amarulasolutions.com> <20190315130825.9005-5-jagan@amarulasolutions.com> <20190315133414.5zwc5qtrivrbrzow@flea> In-Reply-To: From: Chen-Yu Tsai Date: Tue, 19 Mar 2019 10:59:27 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge To: Jagan Teki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_195945_631962_096670E1 X-CRM114-Status: GOOD ( 24.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Maxime Ripard , David Airlie , linux-kernel , dri-devel , Andrzej Hajda , linux-sunxi , Rob Herring , Laurent Pinchart , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2019 at 12:58 AM Jagan Teki wrote: > > On Fri, Mar 15, 2019 at 7:04 PM Maxime Ripard wrote: > > > > On Fri, Mar 15, 2019 at 06:38:23PM +0530, Jagan Teki wrote: > > > ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > > It has a flexible configuration of MIPI DSI signal input > > > and produce RGB565, RGB666, RGB888 output format. > > > > > > Add dt-bingings for it. > > > > > > Signed-off-by: Jagan Teki > > > --- > > > .../display/bridge/chipone,icn6211.txt | 36 +++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > new file mode 100644 > > > index 000000000000..7f13efd7ee7f > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > @@ -0,0 +1,36 @@ > > > +Chipone ICN6211 MIPI-DSI to RGB Convertor Bridge > > > + > > > +ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > > +It has a flexible configuration of MIPI DSI signal input > > > +and produce RGB565, RGB666, RGB888 output format. > > > + > > > +Required properties for RGB: > > > +- compatible: must be "chipone,icn6211" and one of: > > > + * "bananapi,icn6211" > > > > Why is that compatible needed? > > chipone,icn6211 - generic compatible bridge controller IC > bananapi,icn6211 - compatible for icn6211 bridge using on bananapi panel > > I hope this would be proper bindings in terms of controller IC with > associate device, anything wrong? Infact I used similar reference from > Ilitek Bananapi panel from here > Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt > > This is what I understood based on dt-binding, correct if I'm wrong. > > ilitek,ili9881c - generic ilitek,ili9881c compatable > bananapi,lhr050h41 - compatible for bananapi panel associated with > this ilitek IC ili9881c is an LCD driver chip with a MIPI DSI interface. It directly drives the LCD panel, not outputting some RGB stuff. So it is a binding and driver for a panel, not a bridge in your case. > > > > > +- reg: the virtual channel number of a DSI peripheral > > > +- reset-gpios: a GPIO phandle for the reset pin > > > + > > > +The device node can contain following 'port' child nodes, > > > +according to the OF graph bindings defined in [1]: > > > + 0: DSI Input, not required, if the bridge is DSI controlled > > > + 1: RGB Output, mandatory > > > > Your example doesn't have that input port > > Yes, I intentionally did this by referring existing bridge binding. > Documentation/devicetree/bindings/display/bridge/toshiba,tc35876*.txt > > Do we really need? since the input port can be part of panel binding. How could the input port of _your_ _bridge_ be part of the panel binding? ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel