From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EBAC7619B for ; Mon, 17 Feb 2020 03:28:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B623921744 for ; Mon, 17 Feb 2020 03:28:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VMiOu+S4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B623921744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2EBblEucZE48hYo7TuUYU3cRO7TDB6GqLFRainh2Xjk=; b=VMiOu+S4JU/1mB monWzu8td6C4wtfhWTjrIErE016ZFiyRS0sGmxxIN2s+3xa0jeozyPhTROTUEAHgPP0GbSSUDK3Fv aAH17m9XttXlt7xqKZPov9ZIJgP4AwrZ5bIW4LOjmZNYNftWYqIFTQIp90UNEjCmvTw4ujWSgUIpH FOiNOdcT7cCmyVHB2ToG+u8Hzaz0owW0pJovM5b+dD2yWek+tXGP7kIMsYaSEPspMyrgHJopV7COm pY13CxU57hWfjTmFz0wqxV/YDJtN42k4/Nr9RoUkBSLyWZRd+vJeUC7hGLPjErgBGieG0M0VDafmQ gawr4JjL8+BT7vBrq91w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3X5B-0000zf-3b; Mon, 17 Feb 2020 03:28:29 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3X56-0000wM-Sj for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 03:28:26 +0000 Received: by mail-ed1-f68.google.com with SMTP id p3so18978958edx.7 for ; Sun, 16 Feb 2020 19:28:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Vf+s0xiHFIhPppg6jnzm8oEYQMOnPl6UhM4IxCWOkI=; b=JKzwDZwytwv5j6Vk83hFYe5yJ66U+XdhNROcFMpahY7Jys4KsJ78eP0HtKxM1ciFdU wBv0u3DIbCjOVsBDgOTDM9tRQ239Dv8X/Q1/tHP+SejR1J94Cd3JmyhdQrM/VIUEXJB8 6HghmBf7aPU52ce4PCUvDxJcC5WlodyZgKPuiva4HTIIc+6K+BpDhYovf57P7VQlQDzp fKsH6XSvaHI5ekbMlHHnpzHtDCZyQNXFfv/00tDUM/c5hs+4gXzxqeNgXnas8CeXm9XB 2k2e4EsNUer5jo1vw2iMakkqYKUi/3pewqyrtuKzTrHswAmLg+q7GY2opc7lZmB+/d7O j1JA== X-Gm-Message-State: APjAAAWCVjPMelk/9sj4ROE9O00nslTVR/MAnqhIeLCYvnPjRo18SF/9 V5jZK4vmTOe1hA7KJIjjCqRbZ+/pzMY= X-Google-Smtp-Source: APXvYqw6s7wrsEzVak9m7OFEMuAC+6sZU2XOTsBqgjMimMCnibpm/Zi8oOsXyLVz7fS5xGD+txoDlA== X-Received: by 2002:a05:6402:12d2:: with SMTP id k18mr12560640edx.253.1581910102709; Sun, 16 Feb 2020 19:28:22 -0800 (PST) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com. [209.85.128.44]) by smtp.gmail.com with ESMTPSA id m6sm814345ejb.51.2020.02.16.19.28.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Feb 2020 19:28:22 -0800 (PST) Received: by mail-wm1-f44.google.com with SMTP id a9so16808114wmj.3 for ; Sun, 16 Feb 2020 19:28:21 -0800 (PST) X-Received: by 2002:a1c:dc85:: with SMTP id t127mr20681900wmg.16.1581910101671; Sun, 16 Feb 2020 19:28:21 -0800 (PST) MIME-Version: 1.0 References: <20200217021813.53266-1-samuel@sholland.org> <20200217021813.53266-2-samuel@sholland.org> In-Reply-To: <20200217021813.53266-2-samuel@sholland.org> From: Chen-Yu Tsai Date: Mon, 17 Feb 2020 11:28:11 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/8] ASoC: sun50i-codec-analog: Fix duplicate use of ADC enable bits To: Samuel Holland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200216_192824_925129_39F98713 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , Luca Weiss , Linux-ALSA , linux-kernel , Takashi Iwai , Maxime Ripard , Liam Girdwood , Mark Brown , Jaroslav Kysela , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland wrote: > > The same enable bits are currently used for both the "Left/Right ADC" > and the "Left/Right ADC Mixer" widgets. This happens to work in practice > because the widgets are always enabled/disabled at the same time, but > each register bit should only be associated with a single widget. > > To keep symmetry with the DAC widgets, keep the bits on the ADC widgets, > and remove them from the ADC Mixer widgets. > > Fixes: 42371f327df0 ("ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls") > Reported-by: Ondrej Jirman > Signed-off-by: Samuel Holland Acked-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel