From: Chen-Yu Tsai <wens@csie.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
linux-input@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/9] dt-bindings: input: touchscreen: goodix: Document vcc-supply property
Date: Mon, 3 Dec 2018 18:41:39 +0800 [thread overview]
Message-ID: <CAGb2v67ocaKL05yt68F+juBeAq8BRQ49mB4uoHWijGRy8duamw@mail.gmail.com> (raw)
In-Reply-To: <20181203101547.16835-5-jagan@amarulasolutions.com>
On Mon, Dec 3, 2018 at 6:16 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> vcc-supply property is need for some Goodix CTP controller like GT5663
> where 3.3V external pull-up regulator connected via controller VCC pin.
"External pull-up regulator" sounds fishy. Chips have power supply
pins, either combined, or separate rails for analog, digital, and I/O.
For Goodix chips these are AVDD28, AVDD22, DVDD12, amd VDDIO. The name
and description you provide match none of these.
If a regulator is needed for pull-up resistors on the I2C bus, this
should be referenced in either the I2C bus master node, or if the I2C
bus goes through a pin controller, in the pin controller node.
Putting the reference in the slave device node is wrong, since it
doesn't actually use it. It becomes even clearer when you have multiple
slaves on the same bus, and you reference the same regulator in all
of them.
Or, as a last resort, you could mark it as always-on with a TODO note.
ChenYu
> So, document the same as optional property.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index f7e95c52f3c7..604766e347ce 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -23,6 +23,7 @@ Optional properties:
> - touchscreen-inverted-y : Y axis is inverted (boolean)
> - touchscreen-swapped-x-y : X and Y axis are swapped (boolean)
> (swapping is done after inverting the axis)
> + - vcc-supply : 3v3 regulator phandle for controller VCC pin
>
> Example:
>
> --
> 2.18.0.321.gffc6fa0e3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-03 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:15 [PATCH 1/9] dt-bindings: gpio-axp209: Add AXP803 GPIOs compatible (w/ AXP813 fallback) Jagan Teki
2018-12-03 10:15 ` [PATCH 2/9] mfd: axp20x: Add GPIO/pinctrl support for AXP803 Jagan Teki
2018-12-03 10:15 ` [PATCH 3/9] arm64: allwinner: dts: axp803: Add GPIO DT node Jagan Teki
2018-12-03 10:15 ` [PATCH 4/9] arm64: allwinner: dts: axp803: Set GPIO0/1 pinmux for LD0s Jagan Teki
2018-12-03 10:15 ` [PATCH 5/9] dt-bindings: input: touchscreen: goodix: Document vcc-supply property Jagan Teki
2018-12-03 10:41 ` Chen-Yu Tsai [this message]
2018-12-05 19:56 ` Jagan Teki
2018-12-06 3:01 ` Chen-Yu Tsai
2018-12-03 10:15 ` [PATCH 6/9] Input: goodix - Add vcc-supply regulator support Jagan Teki
2018-12-03 19:13 ` Dmitry Torokhov
2018-12-03 10:15 ` [PATCH 7/9] dt-bindings: input: touchscreen: goodix: Add GT5663 compatible Jagan Teki
2018-12-19 17:15 ` Rob Herring
2018-12-03 10:15 ` [PATCH 8/9] Input: goodix - Add GT5663 CTP support Jagan Teki
2018-12-03 10:15 ` [PATCH 9/9] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node Jagan Teki
2018-12-03 10:32 ` [PATCH 1/9] dt-bindings: gpio-axp209: Add AXP803 GPIOs compatible (w/ AXP813 fallback) Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v67ocaKL05yt68F+juBeAq8BRQ49mB4uoHWijGRy8duamw@mail.gmail.com \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).