From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AFFC4338F for ; Wed, 25 Aug 2021 02:16:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CD286101C for ; Wed, 25 Aug 2021 02:16:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CD286101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H2ZCexEkRwkDT4sD2VuJGWA7kziTaHLeu34Pyz5CoZI=; b=or99o6xl4F+s8R qiG7RBpv40Mipnd8LBhBjVWPq9l9i2GDOhnp48Tv5xoi0Hk0IJmP89FliDxGMj+PA0ptVDkAAwEWk xKzSabXATSShOLvwRGAlGroCy/JhgtXMO3zslNcZqQPdRvx4b1EP9edF6LKql/AIu1hcCYwjnMsyH 2DxCyuCfHp41XW3zEZJbPGYMwqscVHSaEwVvo0LU8zSF+dR/0Xng67DJz6kSYAi1j13NdMrx+2dSS o2880DO/8POQ1rrfDzqKjJiA1dhIw8ad5LXWCjA7ViZMpSIEjHzlOdTXpjbAFta3k6g8JJfOniw2V PTr8qK0RO3yyZjMv4+Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIiQz-005CWq-Vk; Wed, 25 Aug 2021 02:14:34 +0000 Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIiQv-005CVQ-2p for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 02:14:30 +0000 Received: by mail-oo1-xc2a.google.com with SMTP id b5-20020a4ac285000000b0029038344c3dso1649380ooq.8 for ; Tue, 24 Aug 2021 19:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EqCJDw6pwwqcA3u963UfsU6r31LKcgwNEuHo0x3pVt4=; b=PHELEcFGD+KCRb+ykFErfan7cTCGvFBynYZyiUM07izhx1J9Dq48E13dItIRSbzf9x mmKfAhGY3hJVqpeCLG7FVGeNzdNi/MugPEQFQqpNWcXzD6B7Ab7VXgW/PicyapTAAyF9 DdnTKClFljT2/ZCX45WzsUVpEA8I0CaevOmLhY9joRwuYZR/jJ3VAevFyest4vAK3eSn 1BXS9KeFieeeVlpfVRdUeYDe1U9Gk9y+zjK+V0TAaeOjhnkDK4SIrWetY4U0kHnQKIZc mFJsFVl8X5oia0wgoD0RwQRu2rVd3CtAVyWR9pr6G5fcbfdN+wNY830dyECo+EuBM7UE CX4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EqCJDw6pwwqcA3u963UfsU6r31LKcgwNEuHo0x3pVt4=; b=OqjQ9obS2Zxiq9fozXYu+Ob0wFhVjSFC8aLAxfkH0S3mlwE72OQEH4x9SPP1FIssIN R2kOk8A6Q3u0MicjfO8gArexvCQNpK2pRbmh0Er0hzPAmqtdHdFrpF7z10jf3IJXOIo9 RSNudz3cWB/mzejHv22gTotE1QI4I8Fl3PCu+eMEw6AuvqHy3AKYT7+7XZp05hyEAuh3 5Q/eGClUF+8BDat0EKb0YHD26lM4kogs8DKz8wBO5jLTihc8zbA9X+BBvUnsoSJrMwA6 htsR7JFwOy55GZyH2CstMzfFojNf8UBoIZpqBknrjjVRgkoNauw3u8MfgoZoPTdni4XN hW4Q== X-Gm-Message-State: AOAM531++c/w7YBslSLcZeQ0xgMmr/fQcO5RmnCWpuya6MzIkTzL1Lga 5g7r4v7NhzaPDGTdTcLi2BVQSVUBA6cfc2bvrHaIJXSLI/ZQN8W+ X-Google-Smtp-Source: ABdhPJwGdyLaOrvtYRVGttPSukOVCRVyx+hg8mPlVBNhC/K0UG/FYc5Wa1O4T8axKx/aN0mDFUp1YoufiSBg5dsuJnI= X-Received: by 2002:a4a:754b:: with SMTP id g11mr32762267oof.10.1629857667201; Tue, 24 Aug 2021 19:14:27 -0700 (PDT) MIME-Version: 1.0 References: <20210617220229.7352-1-zev@bewilderbeest.net> In-Reply-To: <20210617220229.7352-1-zev@bewilderbeest.net> From: Lei Yu Date: Wed, 25 Aug 2021 10:14:16 +0800 Message-ID: Subject: Re: [Phishing Risk] [External] [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled To: Zev Weiss Cc: Eddie James , "moderated list:ARM/ASPEED MACHINE SUPPORT" , openbmc , open list , Mauro Carvalho Chehab , "moderated list:ARM/ASPEED MACHINE SUPPORT" , linux-media@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_191429_228373_42B5BE06 X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 18, 2021 at 6:02 AM Zev Weiss wrote: > > As partially addressed in commit 65d270acb2d6 ("media: aspeed: clear > garbage interrupts"), the ASpeed video engine sometimes asserts > interrupts that the driver hasn't enabled. In addition to the > CAPTURE_COMPLETE and FRAME_COMPLETE interrupts dealt with in that > patch, COMP_READY has also been observed. Instead of playing > whack-a-mole with each one individually, we can instead just blanket > ignore everything we haven't explicitly enabled. > > Signed-off-by: Zev Weiss > --- > > Changes since v2 [1]: > - minor commit message improvements > > Changes since v1 [0]: > - dropped error message > - switched to a blanket-ignore approach as suggested by Ryan > > [0] https://lore.kernel.org/linux-arm-kernel/20201215024542.18888-1-zev@bewilderbeest.net/ > [1] https://lore.kernel.org/openbmc/20210506234048.3214-1-zev@bewilderbeest.net/ > > drivers/media/platform/aspeed-video.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index 7bb6babdcade..77611c296a25 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -563,6 +563,12 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) > struct aspeed_video *video = arg; > u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); > > + /* > + * Hardware sometimes asserts interrupts that we haven't actually > + * enabled; ignore them if so. > + */ > + sts &= aspeed_video_read(video, VE_INTERRUPT_CTRL); > + Without the patch, the driver gets an unhandled IRQ in a few hours after the KVM page is opened. This patch is tested on Bytedance's OpenBMC system and the issue has not been reproduced anymore. Tested-by: Lei YU -- BRs, Lei YU _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel