From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3CF2C31E4C for ; Fri, 14 Jun 2019 13:26:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A09F62133D for ; Fri, 14 Jun 2019 13:26:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S9bJTC2D"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qnmZOrT5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A09F62133D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rFHQH8WZaHvDN6Vdy/R+BfAJ1A6qFT28l75ZepA5cqM=; b=S9bJTC2D9/JR5K OL5nGItY4OtMWA30v6IzLR2rIQHqP11AmCJrV0Cc4HP0y4iyjoGMB4C1Z66RDjIbbITu/lNTOz5DD a8yeKXuf7SD81UpbjM8rw1bRBRMJMIKOPjt2hPACROlBDKsyBOacVMVMP1WAoVssq/fiQtZe1tX6L SkW+CGdnzdN4f8OPyPSXE+CMpHx4mLsEMzFFmndD6rSc5sIwh5KuRsbs6nbXtm9nJgIkBTWGaPrOW ZBqazro40mJjRVIrxKdkAN9sH3lrlFLf4fPHDlQ+Ak/u/tP/SYTNrf63HI9KsyEUmWLMqD9q9aNAi 50UPv6AF6dCkDFZ5Zg0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbmDY-0001x0-Ae; Fri, 14 Jun 2019 13:26:08 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbmDU-0001wT-JB for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2019 13:26:05 +0000 Received: by mail-ot1-x342.google.com with SMTP id n5so2645709otk.1 for ; Fri, 14 Jun 2019 06:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q0OJmGrN/dUckm8xh8/mUqwvTl2m3MsC/Nix3u2EbOo=; b=qnmZOrT55WICaHNRVQwbPhpDLhQ9v0a+iHtcCyaMhVpCyoneH9oAOuBKoqF9Jhg5Y7 fiMHHhBY5xT45QppZFNTXizLTM28cqcVtay4I/KmcB9PBLkZ+3UISDtysaQpGJAUvD8p FaXdCcyrG6eT2aYg9tfbalMYtjbqJO6ymYuutbIQSMpIZKD0DJqly6nfy0IEaOrsFA3s NgsQ40wco1ktUihHcmvXrLk3Mo7Stsqtcde9pZsHaqQA6xnQkosZhas2AFvQcbJi1Dv7 qqxHhuKPtLo4A92pO77eJ27C09s8xT+N2ETINcJ9D2TOdn5BVdmhElSPO+TsokZM19EW cUXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q0OJmGrN/dUckm8xh8/mUqwvTl2m3MsC/Nix3u2EbOo=; b=EpHOPPMnLem3pgNJnd2+/3nMqPgiUz5FxpvKoGuoF/AJucXdR8qrl3K6c3RZZN7L14 Ume5h/N+7cEO4VCEM4xckuzC7NH8LYSOJAyONbCv/k8DBCdnL9Ylyl8s/kJ7nMAVGbAo pQnLzD/FA4fWWTdFsWupRne0NMLkOArhw5RjZeRDjUGGpxnwdKRCyWvJaluDNjO7LYOT OO5CZJmyuEHCpWfwrXyAO6KwmmBIhx6LRHi05pEILMo0eJH7ObYUdtQrHpoJN7mohEJ2 15mFQ8TSQRreatu63y7TT4FDiUArxdmdGK48yLd4xsL8mMY0H6RmEDGX9mWqyqtW3TeF p9pQ== X-Gm-Message-State: APjAAAX4hL2o7sbUI94kf+TGyAQxvqhmcnXlDcQjG0VNdkThGQqrxL5S mQIGZkPLyupzM1G5PD1qDw/ouQ6ZX9HILkQpghI= X-Google-Smtp-Source: APXvYqzZ4yTzZxukuh4ByGQZgpQG6EO0dCIycVqbuDQkexw5XYN6RtEOuxvysNlyk3gw1XEj2+hMGs7NwNxta8Ox7+Q= X-Received: by 2002:a05:6830:16:: with SMTP id c22mr12549596otp.116.1560518762637; Fri, 14 Jun 2019 06:26:02 -0700 (PDT) MIME-Version: 1.0 References: <20190614083959.37944-1-yibin.gong@nxp.com> In-Reply-To: From: Sven Van Asbroeck Date: Fri, 14 Jun 2019 09:25:51 -0400 Message-ID: Subject: Re: [PATCH v1] dmaengine: imx-sdma: remove BD_INTR for channel0 To: Fabio Estevam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_062604_630497_7065ABCB X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sascha Hauer , Vinod , NXP Linux Team , Sascha Hauer , dmaengine@vger.kernel.org, Dan Williams , Robin Gong , Shawn Guo , Michael Olbrich , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14, 2019 at 6:49 AM Fabio Estevam wrote: > > According to the original report from Sven the issue started to happen > on 5.0, so it would be good to add a Fixes tag and Cc stable so that > this fix could be backported to 5.0/5.1 stable trees. Good catch ! However, the issue is highly timing-dependent. It will come and go depending on the kernel version, devicetree and defconfig. If it works for me on 4.19, that doesn't mean the bug is gone on 4.19. Looking at the commit history, I think the commit below possibly introduced the issue. Until this commit, sdma_run_channel() would wait on the interrupt before proceeding. It has been there since 4.8: Fixes: 1d069bfa3c78 ("dmaengine: imx-sdma: ack channel 0 IRQ in the interrupt handler") But my knowledge of imx-sdma is non-existent, so I invite the more knowledgeable people in this thread to take a look at this commit. [Adding Michael Olbrich to the thread] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel