From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F91CC31E57 for ; Mon, 17 Jun 2019 13:28:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F06220657 for ; Mon, 17 Jun 2019 13:28:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RJpVrZHn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MXkyJQB9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F06220657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f+tF+Ns1G6CHC0+adZctx1MJg0qbyezDk+PDddug/1c=; b=RJpVrZHnMJni1i UM2L/12XI2zfwu/2wb0UstuGhjCsugQHIg1H5fpeBm64AIIdE6n2xMeiKp7cJyTWCw8S3WzjWnSjB YNBATW7Dy/b1qnuYYJdzqg7GLWsikgl8FueY6Ef28Fp2E1QJXyYXvI7EFZsYu5F5zPrglpkQ91F5U LJbCnY/P8uIp5ymxcR14i09dTOSybygPcXCLdXwdF3Ldr3LdKO7X0ZGgtJsVDVWwm/S4Mcrt9xbkl WV4qP2sZB39R1HiWXojgIOekb69GsHqnmc5A5mGgAG32K6Fy53HzjeV6DJ9+6n1UPQ9qe1ZMLoIYG wHLAjC36x36n9U1SpUqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcrfz-0008Kl-O1; Mon, 17 Jun 2019 13:27:59 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcrfw-0008KK-73 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 13:27:57 +0000 Received: by mail-ot1-x342.google.com with SMTP id j19so9277625otq.2 for ; Mon, 17 Jun 2019 06:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mJsPsjYAC+D3Ahla1gO6b++R1ySTexA3DFmiKdVNKWo=; b=MXkyJQB9PxauZ8mD4qfnd9cMinYSX8UgPaJCqpc2N6NWAP8Do6zPFB0IrVa9ktAWIt aouaZblOwdUXxA3WA+jdAygJITWcfOAl98fr/H4EDsSZVD/ROYlXL+cWBa9mKzk4vHci NKcp7yaAptskxYFgzG59xEIBPx95gfoDuMpqNfLSYJp2jQydPMrrR6H/tsNRBR3muEl5 iXWL5M5mwD6Rasyt+fAqcbY/Rpm84bJgDFT+ouTQVvwPCALeItlRvcf9MJ1NYAwL+VeR CCoUD2skfkr3YCSTpRB14BPWTTGRtD6fgC3f+/onHzdO37eawrr8zaYsbJRF46MZCO6q ktYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mJsPsjYAC+D3Ahla1gO6b++R1ySTexA3DFmiKdVNKWo=; b=RPJlSFZWSI3eiAbehzzS9un+x29dEaQfVZmufp5Kl7LWz4awZD0sE/2VWnsEL/amD+ yvdSqnkIlMSMxrshlenPfOgN7c9F4Dq56H1v2y5sfJbGMfqBvrlpVY/wLV+kPuGFC1tf JNHkEnOzYHHjZD336JKsYiHGE7v/UTV5ywV7v6MWtG4yik+5ITGOnju9IBqcoR6YdqOW 2QVoaafetmL6KA0QjLPJwtw4XL80bE5R+RELk4Sb3oOZkivxn7q8DdVuhK/NZTWR6NHg aX+ziWjkKPIJsKy7tXaiv6rIZDzh5rZTZ8AEq/vzU7Yc5B0BRz29t7Za0cDg4xMhsQ8b QtNA== X-Gm-Message-State: APjAAAUT5ksN0x0IPIL4gPuABxfLhWSfY9lZQWJgpAc5rhiaKxvfstlc XB/XRLB92THMnTNxPgUj6+on0JcTANpJoAlw1HuD1IwH X-Google-Smtp-Source: APXvYqyhiqkq9CGaDNxwiD6SQeF+F81INxi2lxJi8huCiuSNrRrpuYkOSzLBr6YGnAzUR8mMAtP8t+7zjxH9w00HMOQ= X-Received: by 2002:a9d:7650:: with SMTP id o16mr38379346otl.0.1560778073731; Mon, 17 Jun 2019 06:27:53 -0700 (PDT) MIME-Version: 1.0 References: <20190614083959.37944-1-yibin.gong@nxp.com> <1560765934.30149.26.camel@nxp.com> In-Reply-To: <1560765934.30149.26.camel@nxp.com> From: Sven Van Asbroeck Date: Mon, 17 Jun 2019 09:27:42 -0400 Message-ID: Subject: Re: [PATCH v1] dmaengine: imx-sdma: remove BD_INTR for channel0 To: Robin Gong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_062756_279948_85F8E8CE X-CRM114-Status: GOOD ( 11.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "festevam@gmail.com" , "s.hauer@pengutronix.de" , "vkoul@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "dan.j.williams@intel.com" , "shawnguo@kernel.org" , "m.olbrich@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Robin, On Sun, Jun 16, 2019 at 10:02 PM Robin Gong wrote: > > The default imx defconfig and dts should be ok, because firmware load > is delayed after rootfs mounted where firmware located in and before > that, some driver which use sdma such as spi/uart/audio may have > already enable sdma clock which means channel0 interrupt could be > cleared immediately without interrupt storm. That's why I can't > reproduce your issue at first, but catch it once I sync with your > directly firmware load defconfig. So seems not very must to CC stable > tree? As far as I know, the bug/crash does not happen if you're loading the sdma firmware from a filesystem. So the vast majority of users would never see the crash. I agree that this is not a high-priority bugfix. But it's worthwhile for the stable trees to have it. > Yes, but Michael's patch is the right direction, at least it fix RT > case and meaningless channel0 interrupt storm coming before clearing > channel0 interrupt status in sdma_run_channel0(). Now, this patch could > fix its minor side-effect. I'm not suggesting that we should revert or change Michael's patch. Just that it would be good for the v2 patch to contain: Fixes: 1d069bfa3c78 ("dmaengine: imx-sdma: ack channel 0 IRQ in the interrupt handler") This should allow stable maintainers to pull in your patch if and only if their release already contains 1d069bfa3c78. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel