From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B892C433E0 for ; Mon, 29 Jun 2020 14:38:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6962923E1F for ; Mon, 29 Jun 2020 14:38:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CuI/Dk94"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pUD5GVMv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6962923E1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JH7A7ACTV6iSDi2A1+XEPX/PYjwTgl06WIZDtgDkBtc=; b=CuI/Dk94exOU/7kp2XkVtdD4b mm/uezLeZRx29ohp7jvS+v4884VhO9sOFqsDGZCEV2DHJ2MUb4Rq5mwpEVCS/AUgxMmKKYU7hTK3Q cohjv3kxSUGv5dVd39xriSdhm4sYhCdgtTT6yphXueO8JtiNZ3Tj0lL8ro6BbL1YUxUCPOdb66ZzM 7iinaNP+XSy9AxbeizhCC7SVN4dYXwh1TB0GaAeKes166VdDAhpeNHqDj+j3GM2gesYd6Tvdhi1Cd FTuZWsniUlKH/4W9ExZnBo9V1VRodFOpl4/W/6FSlgeD2RJ1Il0Pp2ESF4lPxeepgC+wzyvbCBLrs KguUnE64w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuui-0005H1-N0; Mon, 29 Jun 2020 14:37:40 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuug-0005GM-3J for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:37:38 +0000 Received: by mail-ot1-x343.google.com with SMTP id d4so15715287otk.2 for ; Mon, 29 Jun 2020 07:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cveXjL+4X4gh1TmXdX8oqUnZgc2Vd1IaF1EU/HiH/po=; b=pUD5GVMvZNlTyNPmyJi9IXsTZfrSpSaM0QY7ebsyC1zCo0OHvFNpbLVF1pJscNAUqe IFyUSK2FgPrznhkiChklKg/G7qoGD7VR+JxDCQ+2fGlXHzsXTAeebGDSbDi+xKb4oeiQ r7TCH5o2rRa9F7dzql1Y0Y4WBuhpBWi1/YxuFjhqYkw3Gk8eneRiedH9eIkkpmhuMVqw oLoc7SDNFwvw9CyUztYOctHv3EI/iIZ6WPxRIm3c+LnISDzu8GPBBQTtWbyUAoIKTPkK TcQTR90pveM86/MHrDr6nAEk9rl3U5f0rwT6CQHlwFY7wh5l0XX7yi+KGFgnVqS4+XCo sevw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cveXjL+4X4gh1TmXdX8oqUnZgc2Vd1IaF1EU/HiH/po=; b=Q3B/3VM0RZLhNbmujDoiwVxlY3XF3iIGcaQFTFz0cUbW8pC1wN8wQMUJJCn+YV6b1b uSCpr93CcJuBc2KNVUZYRYmlIUpyDpSjx4DGUSbj1LtbDaJgJd9jZfNE6pEx3gTcKr47 Gj1LwQ67gCw+BDstDbA9QCMl47KDRn9C0le9UtLmZzFTo/YLWimbf8Z0UqdPdESjwL+0 hEFm8zt/FEmyK9tOJHxjqvhaky1X84cMYuEbdfMwBVmnzGfjaKaYSeAu0GTuwrekXi1z hyTWCkip9ipti4gxH2NxStySaujP/Se5dC9Q8RwTYlVdLlesisFiFDLRHiUteRgdQct8 RprQ== X-Gm-Message-State: AOAM532IRupe9qAfZCCC6ITeyoBJ4VXOYJ0C1KEH+ycsneZ2ts+WZPwU fLiS3wWi4G2l2M0OvRgvlv7PfF6zvdNJguFEqJIz5NpE X-Google-Smtp-Source: ABdhPJxR9g/vuVB4KPn3jdGd9TFAWyi4TL/l19BuOkeMaOra6mdLr30ClOYBUAd6kOsB5YS6iY65MEoC5vi4wUTht3Y= X-Received: by 2002:a9d:2c26:: with SMTP id f35mr14207086otb.232.1593441455928; Mon, 29 Jun 2020 07:37:35 -0700 (PDT) MIME-Version: 1.0 References: <20200625140105.14999-1-TheSven73@gmail.com> <20200625140105.14999-2-TheSven73@gmail.com> In-Reply-To: From: Sven Van Asbroeck Date: Mon, 29 Jun 2020 10:37:25 -0400 Message-ID: Subject: Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible To: Fabio Estevam X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fugang Duan , Sascha Hauer , linux-kernel , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, On Mon, Jun 29, 2020 at 10:26 AM Fabio Estevam wrote: > > Just tested 5.4.24_2.1.0 on an imx6qp sabresd and DHCP also fails there. I think I discovered the problem ! When I compare the sabresd devicetree on mainline with the actual sabresd schematics, the devicetree is incorrect ! Things still work, but only by accident. The sabresd has an AR8131 PHY, which generates the enet ref clock, not the imx6. So on the schematic we see that the clock output of the PHY is wired to imx6 ENET_REF_CLK, so it can be used as a clock source. And GPIO_16 is disconnected, as it should, because the imx6 is not generating the ref clk. But the devicetree is written as if the imx6 is providing the clock ! See here: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/imx6qdl-sabresd.dtsi?h=v5.7.6#n513 Also there is no override of the fec PTP clock: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/imx6qdl-sabresd.dtsi?h=v5.7.6#n202 Although Shawn's mainline patch mandates this? https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.7.6&id=810c0ca879098a993e2ce0a190d24d11c17df748 This will work, but only by accident. So on a plus, when we (incorrectly) switch the bypass bit on, things stop working. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel