From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51CD2C433E0 for ; Wed, 1 Jul 2020 13:53:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C0FD20663 for ; Wed, 1 Jul 2020 13:53:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ofsH1DNB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KlWHBQV/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C0FD20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e8wVVsv7ozkoJwTaQ8QAEKsdQNIdoqlEckTSsRX/oJY=; b=ofsH1DNBZncBb0vppA+wSmKKe ExPBbRl4kzxyuKi2GZqgqk7Zi0vwPrSdtp0wYtPJo4AdCGrbN7qqXxHBg8rtkvJA6YitKy+K39Xsd wfNNHAwmwyHoohGIqdr1ydpLgQJU8bihIca5WweRFOwQG7225gZgw7FPdEMFO8f4DPmevKguS3Q5q ivj5QARt0eOU4Zt4zas2ElZ+y1Fx8NG2gi6hsONulS2U3Relk+olSVwZfEQAIWIfXb5bO6raBzIiJ m1uIUjS8dQKCuXT7zHu55+jk8ndIrbodb7MeEFAcSpbWcxC7xeajzMmwPlfg+4KxAFH4E8uu3AL1g Gw4G906Cg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqd9R-0003rm-L4; Wed, 01 Jul 2020 13:51:49 +0000 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqd9O-0003r4-DM for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 13:51:47 +0000 Received: by mail-oi1-x244.google.com with SMTP id y22so8042057oie.8 for ; Wed, 01 Jul 2020 06:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xj1Lk3VZEMaGF9wl7c7H3our1i602EVg5obbUq2ppYc=; b=KlWHBQV/y+Tis6Ilt/08e+X2Po+9I9X6lFsX+D0PfXHDvGzQLPWYp5J6q1ZYDAvF6i JOw1dCSMqErC9KMgcMPoRUUXw65wifJElvzosNZsPLh5kFawxR3oX2eF+LNP2cVfF85r zSn9dqb/NhZ6zgbalPwsFQW1+N0O3WzCUCKBrG9hG1QMBU3dhk5O7ABfqVWkJcVuiweW WH7kJUMTJkqwM1O+cY+leLTMkTdlITrWFoZImeebn0n3axiiTR0lx6CDMaGL0Ys3Jdla b7kAWY8PLXCTGuqzHsF8FGvY6/gHI3MINMb4sg9WcCdOD6y5iJFgZq+owImhz2ZLCOUQ qwwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xj1Lk3VZEMaGF9wl7c7H3our1i602EVg5obbUq2ppYc=; b=mjHRAWW941WEr51Jqx/4hXssDNf40b5h/ZNSbfGFmU+GLq+LZCijbmyIZz/Fd0z3aG ID9lX0hbnW4JnXj0g7KQ29YLGH56ZhABtU+HWJW7AL5wIX0Hffu1BYdkZg0rpehCtPxV zSK/1bmEJCjRZuDwIEzmZ2hQEw4zfwK3ZyOT+1KL3Y2c2w3tr+98e8x8SSJRPiK6pDso HvYZTgN1Uv+QtjmKt+CtudB737wdQNf7VdM4pGEaSkWm0hgNKuhzgFnpZ053VLnYdZ6i zN85k9mxSDsWbHtfepnolm6ynnwdwzTjz/cLNDI66V5Q7fEOwF+qLxpcHwvvHVQ66BJ9 OcMA== X-Gm-Message-State: AOAM533pQZ++TfGhx9VEEQXo2lqW3yNXANGxxCYA/2+ICPIS4b75CmbC cqLlvsVUiGzowhzr5bk5lApnFNs1s6RfC9OX/gY= X-Google-Smtp-Source: ABdhPJwy8RbrJAOG7TcJUrkCo2N6WVNcYq+jC9yPpRV+bRfwoLzselPY1fC1n2p1IUJ6cDSQ8oaMTabv6rG1Zrtwklg= X-Received: by 2002:aca:b205:: with SMTP id b5mr21158482oif.103.1593611504654; Wed, 01 Jul 2020 06:51:44 -0700 (PDT) MIME-Version: 1.0 References: <20200625140105.14999-1-TheSven73@gmail.com> <20200625140105.14999-2-TheSven73@gmail.com> In-Reply-To: From: Sven Van Asbroeck Date: Wed, 1 Jul 2020 09:51:33 -0400 Message-ID: Subject: Re: [EXT] Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible To: Fabio Estevam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_095146_503883_A68DD276 X-CRM114-Status: UNSURE ( 7.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andy Duan , Sascha Hauer , linux-kernel , dl-linux-imx , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andy, Fabio, Does the following describe the mainline situation? Please correct if not. 1. imx6 ethernet ref_clk can be generated internally (by imx6) or externally (by PHY or oscillator on PCB) 2. if internal, fec's "ptp" clock in devicetree should be <&clks IMX6QDL_CLK_ENET_REF> 3. if external, fec's "ptp" clock should be that external clock, see 810c0ca879098 ("ARM: imx6q: support ptp and rmii clock from pad") 4. sabresd devicetree describes "ptp" clock as IMX6QDL_CLK_ENET_REF, although it's externally supplied (by PHY). This is incorrect. 5. nevertheless sabresd will work, because FEC driver can still work when the PTP clock in devicetree is different from supplied PTP clock 6. sabresd plus believes FEC is clocked internally, so flips the bit which routes the ptp clock internally 7. this breaks sabresd plus, as default internal clock is unsuitable 8. sabresd is sample board, so all boards based on sabresd may have the same issue, and break Solution 1: - describe sabresd ptp clock correctly in devicetree - "clean/correct" solution - may break other imx6q plus boards in mainline - may break out-of-tree (private) imx6q plus devicetrees based on sabresd Solution 2: - on plus, never route PTP clock internally by default use a devicetree property instead - complex solution, hard to understand if newcomer - prevents sabresd / clones breakage Solution 3: - set sabresd ptp clock freq to same as externally supplied clock - may still break designs based on sabresd - hard to understand what's actually happening Other solutions?? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel