From: Sean Wang <sean.wang@kernel.org>
To: "Chuanjia Liu (柳传嘉)" <chuanjia.liu@mediatek.com>
Cc: youlin.pei@mediatek.com, "Zhiyong Tao" <zhiyong.tao@mediatek.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-mediatek@lists.infradead.org, hailong.fan@mediatek.com,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5] pinctrl: mediatek: add EINT support to virtual GPIOs
Date: Fri, 4 Jan 2019 02:26:46 -0800 [thread overview]
Message-ID: <CAGp9Lzop3UaUt8Kx4LsPxkoo_4uZF-7bv2BOqHgwmurmEA9CLA@mail.gmail.com> (raw)
In-Reply-To: <1546486635-16829-1-git-send-email-chuanjia.liu@mediatek.com>
On Wed, Jan 2, 2019 at 7:38 PM <chuanjia.liu@mediatek.com> wrote:
>
> From: "chuanjia.liu" <Chuanjia.Liu@mediatek.com>
>
> Virtual gpio only used inside SOC and not being exported to outside SOC.
> Some modules use virtual gpio as eint and doesn't need SMT.
> So this patch add EINT support to virtual GPIOs.
>
> Signed-off-by: chuanjia.liu <Chuanjia.Liu@mediatek.com>
Acked-by: Sean Wang <sean.wang@kernel.org>
BTW, if you were worried about a patch is lost, you could use RESEND
in the tag is fine.
> ---
> change note:
> v5: This patch is the same as v4,re-upload due to
> mail permissions issues
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 4a9e0d4c2bbc..b1c368455d30 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -290,7 +290,13 @@ static int mtk_xt_set_gpio_as_eint(void *data, unsigned long eint_n)
> return err;
>
> err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_SMT, MTK_ENABLE);
> - if (err)
> + /* SMT is supposed to be supported by every real GPIO and doesn't
> + * support virtual GPIOs, so the extra condition err != -ENOTSUPP
> + * is just for adding EINT support to these virtual GPIOs. It should
> + * add an extra flag in the pin descriptor when more pins with
> + * distinctive characteristic come out.
> + */
> + if (err && err != -ENOTSUPP)
> return err;
>
> return 0;
> --
> 2.19.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-04 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 3:37 [PATCH v5] pinctrl: mediatek: add EINT support to virtual GPIOs chuanjia.liu
2019-01-04 10:26 ` Sean Wang [this message]
2019-01-11 12:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGp9Lzop3UaUt8Kx4LsPxkoo_4uZF-7bv2BOqHgwmurmEA9CLA@mail.gmail.com \
--to=sean.wang@kernel.org \
--cc=chuanjia.liu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=hailong.fan@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=youlin.pei@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).