From: Sean Wang <sean.wang@kernel.org>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
srv_heupstream <srv_heupstream@mediatek.com>,
hui.liu@mediatek.com,
"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
jg_poxu@mediatek.com, "Biao Huang" <biao.huang@mediatek.com>,
"Hongzhou Yang" <hongzhou.yang@mediatek.com>,
"Erin Lo (羅雅齡)" <erin.lo@mediatek.com>,
"Sean Wang (王志亘)" <sean.wang@mediatek.com>,
seiya.wang@mediatek.com, sj.huang@mediatek.com,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: add lock in mtk_rmw function.
Date: Tue, 16 Mar 2021 13:05:44 +0800 [thread overview]
Message-ID: <CAGp9Lzq+NQhguSoc5DE4kyUgi2uSNOkURuAeAFpGuizcaXUXew@mail.gmail.com> (raw)
In-Reply-To: <20210312063502.3685-2-zhiyong.tao@mediatek.com>
Hi Zhiyong,
On Fri, Mar 12, 2021 at 2:35 PM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>
> When multiple threads operate on the same register resource
> which include multiple pin, It will make the register resource
> wrong to control. So we add lock to avoid the case.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 ++
> drivers/pinctrl/mediatek/pinctrl-paris.c | 2 ++
> 3 files changed, 8 insertions(+)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 72f17f26acd8..fcf7c3eeee4a 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -58,10 +58,14 @@ void mtk_rmw(struct mtk_pinctrl *pctl, u8 i, u32 reg, u32 mask, u32 set)
> {
> u32 val;
>
> + mutex_lock(&pctl->lock);
> +
> val = mtk_r32(pctl, i, reg);
> val &= ~mask;
> val |= set;
> mtk_w32(pctl, i, reg, val);
> +
> + mutex_unlock(&pctl->lock);
> }
>
> static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw,
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h
> index e2aae285b5fc..65eac708a3b3 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h
> @@ -251,6 +251,8 @@ struct mtk_pinctrl {
> struct mtk_eint *eint;
> struct mtk_pinctrl_group *groups;
> const char **grp_names;
> + /* lock pin's register resource to avoid multiple threads issue*/
> + struct mutex lock;
> };
>
> void mtk_rmw(struct mtk_pinctrl *pctl, u8 i, u32 reg, u32 mask, u32 set);
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index da1f19288aa6..48e823f6d293 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -970,6 +970,8 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev,
>
> hw->nbase = hw->soc->nbase_names;
>
> + mutex_init(&hw->lock);
> +
Could you help add the mutex initialization into pinctrl-moore.c too?
and then the patch would look good to me.
> err = mtk_pctrl_build_state(pdev);
> if (err) {
> dev_err(&pdev->dev, "build state failed: %d\n", err);
> --
> 2.18.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-16 5:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 6:35 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao
2021-03-12 6:35 ` [PATCH] pinctrl: add lock in mtk_rmw function Zhiyong Tao
2021-03-16 5:05 ` Sean Wang [this message]
2021-03-16 6:10 ` zhiyong tao
2021-03-21 3:31 [PATCH v2 0/1] Mediatek pinctrl patch Zhiyong Tao
2021-03-21 3:31 ` [PATCH] pinctrl: add lock in mtk_rmw function Zhiyong Tao
2021-03-25 9:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGp9Lzq+NQhguSoc5DE4kyUgi2uSNOkURuAeAFpGuizcaXUXew@mail.gmail.com \
--to=sean.wang@kernel.org \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=hongzhou.yang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=jg_poxu@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=seiya.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).