linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Barry Song <baohua@kernel.org>
To: Ma Feng <mafeng.ma@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static
Date: Fri, 10 Jul 2020 18:00:26 +1200	[thread overview]
Message-ID: <CAGsJ_4wmNUF9AO3naJcGc6R-zN9LAiHa_fxWUy7LtTZ7U=sXWg@mail.gmail.com> (raw)
In-Reply-To: <1589200172-12273-1-git-send-email-mafeng.ma@huawei.com>

Ma Feng <mafeng.ma@huawei.com> 于2020年5月12日周二 上午12:23写道：
>
> Fix sparse warning:
>
> arch/arm/mach-prima2/rtciobrg.c:34:6: warning: symbol
> 'sirfsoc_rtc_iobrg_wait_sync' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ma Feng <mafeng.ma@huawei.com>

Acked-by: Barry Song <baohua@kernel.org>

> ---
>  arch/arm/mach-prima2/rtciobrg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-prima2/rtciobrg.c b/arch/arm/mach-prima2/rtciobrg.c
> index 97c0e33..f517721 100644
> --- a/arch/arm/mach-prima2/rtciobrg.c
> +++ b/arch/arm/mach-prima2/rtciobrg.c
> @@ -31,7 +31,7 @@ static DEFINE_SPINLOCK(rtciobrg_lock);
>   * symbols without lock are only used by suspend asm codes
>   * and these symbols are not exported too
>   */
> -void sirfsoc_rtc_iobrg_wait_sync(void)
> +static void sirfsoc_rtc_iobrg_wait_sync(void)
>  {
>         while (readl_relaxed(sirfsoc_rtciobrg_base + SIRFSOC_CPUIOBRG_CTRL))
>                 cpu_relax();
> --
> 2.6.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2020-07-10  6:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 12:29 [PATCH] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static Ma Feng
2020-07-10  6:00 ` Barry Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGsJ_4wmNUF9AO3naJcGc6R-zN9LAiHa_fxWUy7LtTZ7U=sXWg@mail.gmail.com' \
    --to=baohua@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mafeng.ma@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).