From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DF71C433EF for ; Tue, 26 Apr 2022 16:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XwDyD/eNPlXHnltVw1eMrS4xNPKzsnU2oEam7FxCsSo=; b=axt9BzCJtLMxpy fKMFTUxLMcolQ3ulyPoawhP+ei4UI319h7aYyqhlZJXtd1qmnEYdJ+pd1D/tKQ1oeW61Y1MU25E48 rpk3zk56SVZBQcPCPvahIQT2x4N7gIkjQNANqyQrCAk1fwBljrvHgg1QCFgCkbvr/gO1U0XqoyYF9 Ccku6o7axIYcgZ3zwX11ZpEYQ1UmMk6eaqoNspc1SJp6AyDC006XgluvNDa3m73jIFbyyVsOfu6zY YKWLZpz89NDPyzP8Jg0i8mcQUDydnXEX5KWCzqyPj3WNUHcFMElYpe7N4+aMnlXyI9O0SzbaULohs HcsCou9xw0l5fBhUS7og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njOQR-00FR0D-7T; Tue, 26 Apr 2022 16:52:31 +0000 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njOQO-00FQxB-1a for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 16:52:29 +0000 Received: by mail-qk1-x731.google.com with SMTP id q75so13679556qke.6 for ; Tue, 26 Apr 2022 09:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kqUR0c7kIfOD/vD/YKkVpkdvcyQWCmE0JRAtCDl4Ovs=; b=C8hwhh7uEC6m2zOD/nAcUGPqgF3WeHql9lkeJRc6BmxkPieL3Kyc8v4RNJ/vt+iUpN +IgZPwvK7gwiayFEj2jURS6zF080FYWzVTPXDRsSl5OIIhMuckxYGoG2j6euIscZYCye KXkxUy1MgIh++h0q0cQAtPkg4BT/7yNYt4S98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kqUR0c7kIfOD/vD/YKkVpkdvcyQWCmE0JRAtCDl4Ovs=; b=k5YoMWxrVz4DWYYnC47WOJkXaPy/1Zh2OwbQIzAkvsc6FqYmwr4LSu2x2HW94TZmDd pBTWOz9RJ2gaCSAbhI2Rnk6gu7hTekvjl8NWl/1AG6BBVLaP4DOsHunSuKB/8RPlRRss wDK74qDSS6xKovs1qa7UezTKPe71+9crE1ZlEZaEJGDVbJJJLAkfAhPtLHGb6VX2Uo81 cHothWGngLXroelXk7o9Ng9Yh90mhPccinTRLMkW5Xf6EJss/C1CHiee6/u08v9FmSbe XtaX0aYabmhzHmsUrODaJDPyAumTFvnDnXtxrnnKhD6eenZdT7nYXxhwp4qNTO5D0xcF l0Og== X-Gm-Message-State: AOAM530M8UgXvIzhvLjVBEncCK1DM987jM42ZFolu8UJjIY2FKmKC4o+ IRNwDFEA7/0Kh3z58IPdVibZRLUDlTeYPPtS37AbxA== X-Google-Smtp-Source: ABdhPJx1o2mJSh4zS7CrbcgNcsvrnRgihUn9uVOHoVGxS3Rk8p6EoavtaO4OBtVkqYcrSA6ToxZ+4CDS2ZXUCHDL0N4= X-Received: by 2002:a37:b4d:0:b0:69f:7742:9778 with SMTP id 74-20020a370b4d000000b0069f77429778mr2486350qkl.109.1650991936058; Tue, 26 Apr 2022 09:52:16 -0700 (PDT) MIME-Version: 1.0 References: <20220419142859.380566-1-krzysztof.kozlowski@linaro.org> <20220419142859.380566-6-krzysztof.kozlowski@linaro.org> In-Reply-To: <20220419142859.380566-6-krzysztof.kozlowski@linaro.org> From: Markus Mayer Date: Tue, 26 Apr 2022 09:52:05 -0700 Message-ID: Subject: Re: [PATCH 6/7] memory: brcmstb_dpfe: simplify platform_get_resource_byname() To: Krzysztof Kozlowski Cc: Broadcom Kernel Team , Florian Fainelli , Santosh Shilimkar , Thierry Reding , Jonathan Hunter , Linux ARM Kernel , Linux Kernel , linux-tegra@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_095228_236768_59E8D8C4 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Apr 2022 at 07:29, Krzysztof Kozlowski wrote: > > Use devm_platform_ioremap_resource_byname() instead of > platform_get_resource_byname() and devm_ioremap_resource(). > > Signed-off-by: Krzysztof Kozlowski Thanks for the change. Acked-by: Markus Mayer Regards, -Markus > --- > drivers/memory/brcmstb_dpfe.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c > index 14412002775d..76c82e9c8fce 100644 > --- a/drivers/memory/brcmstb_dpfe.c > +++ b/drivers/memory/brcmstb_dpfe.c > @@ -857,7 +857,6 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct brcmstb_dpfe_priv *priv; > - struct resource *res; > int ret; > > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > @@ -869,22 +868,19 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev) > mutex_init(&priv->lock); > platform_set_drvdata(pdev, priv); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-cpu"); > - priv->regs = devm_ioremap_resource(dev, res); > + priv->regs = devm_platform_ioremap_resource_byname(pdev, "dpfe-cpu"); > if (IS_ERR(priv->regs)) { > dev_err(dev, "couldn't map DCPU registers\n"); > return -ENODEV; > } > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-dmem"); > - priv->dmem = devm_ioremap_resource(dev, res); > + priv->dmem = devm_platform_ioremap_resource_byname(pdev, "dpfe-dmem"); > if (IS_ERR(priv->dmem)) { > dev_err(dev, "Couldn't map DCPU data memory\n"); > return -ENOENT; > } > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-imem"); > - priv->imem = devm_ioremap_resource(dev, res); > + priv->imem = devm_platform_ioremap_resource_byname(pdev, "dpfe-imem"); > if (IS_ERR(priv->imem)) { > dev_err(dev, "Couldn't map DCPU instruction memory\n"); > return -ENOENT; > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel