From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DC59C433F5 for ; Wed, 23 Mar 2022 14:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cjKZi33q5TrkyhRRtDezXeImc9ZWcczzlvl8kTjUmVE=; b=oL8cNcTJtv4wxz rkrnANVznDi5LHAVI8wRDGwoUKazeHjLmBlf1Tyl4oavqXNRz4b9YQFj1uprKp8L8uCj4BRn265nv DwWFQ1rsmr7TqDxasUdDDesbo4Q3H7m/kVXcwGEs4OANm9RwsXrxCf5w9yQA60Js1yUx5d8u8Y1DG G+R4SSRIHLgtggtS37EjHn2s2mKNK2R8LQ2zaSb1hoYfaFZWc1oB6aKSgqcqcKOYAYyK0TCecVWa1 mp6XRnG3gyN4Xf7/6XCqAYuorop02fJ9U+hckaqbh9IoUSslMT5D1kcddeYAypZbutok6TePIR47P 3Q78A8UZWYO7jjn5Ihuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX1Y2-00Dp8C-6t; Wed, 23 Mar 2022 14:01:14 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX1Xy-00Dp6o-GK for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 14:01:11 +0000 Received: by mail-ej1-x634.google.com with SMTP id bg10so3046145ejb.4 for ; Wed, 23 Mar 2022 07:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TCVIhfUSnU8IPSagUHAJ0Zv4n7o7gQntDTvbCX+nFt8=; b=juExcyDTlT2UxKk3zCaBuoiQGJhree5ifHR7oGTRpSsDRiZfWhNHEoZbt2uL1Td94d UgBQB/rsoeFcq09aZyEYqUBXv4ocQJxhTOjHBBpvRSiUyznxb30omlPbg7F22O844Ejr Yv4ihxVXOZrftdmtmeQK6hM9H0KB5mUkphorU2Cnphc7xm7grwbmT7m3lfRZxHqi83HA VRjLZyVoWHwrJSl1x+MrYsHb1QwZelcKyDWXAm/A4ZqH6m0/JNGBotpnpgR8R4vbBthF a76LWrQdQ7vwvcJhNQhpu3aGoufB9zv7NN9uedQxRZ0NSY9B/mSXEGp8BX+qoJ4/q0xR bb0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TCVIhfUSnU8IPSagUHAJ0Zv4n7o7gQntDTvbCX+nFt8=; b=Bw2y2b/dZSYVp64DMXYK5mvJAUD8g7jYNTDZ32fAFsaj5OPdLO68VBLWPmTOBXfH/o F3/Co7plPHn9Py7mreKh0KAkWlUoypZBwEHWtkqlZL+bma0EjVDvF7KAOi0NZd3xChTn HkAOzAqTieZegpSRwnc4aK/GUbiizNylFCoH4qt8ryQD7Uynb2+mH00bKCs7odidwLs5 atZiaZZtUOF5kSDC7dC7ZZPf4ZaTHGtCKnNE5fCOZxmcj8h0zYxzN85hqwsJ1VyuL8Ja CSqR5qhon6/fFBxSO4KfLzR7KCVC7jE9XLfHHS+tc6oFuXh4e7pWR6SaWlMRRpn+bs2F yO1A== X-Gm-Message-State: AOAM530ulOz2Y9kho2WZkLmG3vRiPzPZMZ+dbHU+p4FJavjnqL4lcavG Yn1M6uiyyqupTLxXfBz1MG2du+9eZ64ec/Dc2Y11/hGj X-Google-Smtp-Source: ABdhPJyqw2t5SZvLPazfXOr5THRD2EXHKAd2jXnzzMePxhtG4B2gyboCh8jzuJpoks8a2B4rBbdXNqpPs7XxSF/vJi8= X-Received: by 2002:a17:906:9e11:b0:6df:a9d8:cbad with SMTP id fp17-20020a1709069e1100b006dfa9d8cbadmr115397ejc.32.1648044068495; Wed, 23 Mar 2022 07:01:08 -0700 (PDT) MIME-Version: 1.0 References: <20220323134019.3796178-1-aford173@gmail.com> <35f58894-ed6d-0af0-e483-7a161ad6625a@kernel.org> In-Reply-To: <35f58894-ed6d-0af0-e483-7a161ad6625a@kernel.org> From: Adam Ford Date: Wed, 23 Mar 2022 09:00:57 -0500 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: mmc: imx-esdhc: Change imx8mn and imx8mp compatible fallback To: Krzysztof Kozlowski Cc: arm-soc , Adam Ford-BE , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-mmc , devicetree , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_070110_578065_533BE9D7 X-CRM114-Status: GOOD ( 20.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 23, 2022 at 8:56 AM Krzysztof Kozlowski wrote: > > On 23/03/2022 14:40, Adam Ford wrote: > > The SDHC controller in the imx8mn and imx8mp have the same controller > > as the imx8mm which is slightly different than that of the imx7d. > > Using the fallback of the imx8mm enables the controllers to support > > HS400-ES which is not available on the imx7d. > > > > Signed-off-by: Adam Ford > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > index 7dbbcae9485c..d6ea73d76bdd 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > @@ -39,14 +39,14 @@ properties: > > - items: > > - enum: > > - fsl,imx8mm-usdhc > > Your change looks reasonable, but why imx8mm is compatible with imx7d? I saw that, and I wasn't sure the best way to go about fixing it. If I move the 8mm out of the imx7d category, do I need to add it to the enum list associated with the imx8mm, or can I just delete it from the enum leaving the const for imx8mm good enough? I am not very good with YAML files yet, so please forgive my ignorance. adam > > > - - fsl,imx8mn-usdhc > > - - fsl,imx8mp-usdhc > > - fsl,imx8mq-usdhc > > - fsl,imx8qm-usdhc > > - fsl,imx8qxp-usdhc > > - const: fsl,imx7d-usdhc > > - items: > > - enum: > > + - fsl,imx8mn-usdhc > > + - fsl,imx8mp-usdhc > > - fsl,imx93-usdhc > > - fsl,imx8ulp-usdhc > > - const: fsl,imx8mm-usdhc > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel