From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF18C4CEC5 for ; Fri, 13 Sep 2019 21:14:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C4E6208C2 for ; Fri, 13 Sep 2019 21:14:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qCoOafVj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KTZO+mFW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C4E6208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=seKCK47Co3V0YqkGSQJHkfIfkiQaiHLpZzrukUfwEtQ=; b=qCoOafVjp0I1O4 G35a03mv4XsfOrDGU5yrN7ook1oQUUp5CqZ/ks560gscqAjGu8G0MBd2m8qDefCWBGVASm+JfVAop SNcmg3OW/8Ttf5eaMvuo7EmQJKHf6yVong6xUtZuvqznbU0HqKA+jrcpRmK3XKz8Up3cNVsvX5dud 8PTQqlakoNzdQZ9NzxjeZx5J7WWhpjzlIf66tT/9f/QYZe3RVSkgwvUMQRHQ4qpRdD2Fay7MGmm3U BxgblfeXqLuTfWdafuxfpK8BzqN+dBNY39eY8jzKvRCq6gJF1m0H/Y07AxQ1waHb7yMacg6jyzHly Jvi9ba8+6Whzb2ogdhqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8stO-0001Dq-DE; Fri, 13 Sep 2019 21:14:10 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8stL-0001Ci-Ra for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2019 21:14:09 +0000 Received: by mail-io1-xd42.google.com with SMTP id k5so40411858iol.5 for ; Fri, 13 Sep 2019 14:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UskOfSgg386hDT+uq0TXDMPpn1NNITv5aTMpt8d4CVY=; b=KTZO+mFW2Oh+QziZmA+IzJU3e+94+mnT6T1racQjGHE2uMDNbYjP5fICTd+PTf1T0O 89ZtvAqy7spGERQr6pyWt0bInhVfaqM7cYr9nEcDxs3vFv4hlpWsGBeuOdg+GguUZYSJ bbqeOPT7mYQmJu90r9JJUzc1qNfip9Z8r+W2ttzMSo7na/G4+Nmk1bdIF3VPj/Dc6od/ Ek0kziyGcUuD347XXLB1M9Pc2IIUGHy8R/LJydks5GoSHDhsTv/5ZiThLpcI2YBPuZUh UHoU+R1bnjMYHIKQ0+3Kz3Ptw8xP0a7M4AvTuG8tuwis8beY1LHrKv/cDSyHY1Qaf/+w nShQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UskOfSgg386hDT+uq0TXDMPpn1NNITv5aTMpt8d4CVY=; b=QAcQRjtAXbzSbrTEVXjU44I6MBXuUVfGpbIr9qztZWBfbWtJRf6pzIqAOYi/O6sqb6 B59NYWE/HISfy/BSa1lO1NxUMlrCD/kVtDt+J1maTIDhHSyFJoaGT/xl/0j9w9Z7JbUx wS3/8Lj8ilGxpp7W5+Ffj5Ye4dpDy0bLVh7B2c5faXC3ZGtNKpnXNKTbFj9LXMhZwVqR /RsMQtQoS4BGk3cN/FipPGEP9oVSzh4vpuLx6EuK+eLAk6Eh0fVugYF8WkI3XetLtZlB xSp+VrhDlCTn3FDOSzI23miYTNfqNJq6USgkVy89cJGLdfqDOc4q/kSzFZ53npACl8cl oBcA== X-Gm-Message-State: APjAAAV7u7ZTiTe6Fbba8HXqwbL00PE7Johczy6yr/zDFLCWIOwOOJIL f3dL+ShG+gb9JRQpj9inKBqJtb8KfeoOA3xVuk4= X-Google-Smtp-Source: APXvYqxRa4Jg1JIT0wxzuiyNm4qA+JzsRMv754ROCdVMD/vIvOO+svXgd/mShdE0/aAd0y6Ox+BfcYHRmgO1HdAv8ek= X-Received: by 2002:a6b:b78b:: with SMTP id h133mr2158869iof.276.1568409240130; Fri, 13 Sep 2019 14:14:00 -0700 (PDT) MIME-Version: 1.0 References: <59a0f6267c75859c25665548db2e8a9c4229d3b4.1568224033.git.hns@goldelico.com> In-Reply-To: <59a0f6267c75859c25665548db2e8a9c4229d3b4.1568224033.git.hns@goldelico.com> From: Adam Ford Date: Fri, 13 Sep 2019 16:13:49 -0500 Message-ID: Subject: Re: [PATCH v3 6/8] ARM: dts: omap36xx: using OPP1G needs to control the abb_ldo To: "H. Nikolaus Schaller" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190913_141407_898003_DF60A85C X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Discussions about the Letux Kernel , linux-pm@vger.kernel.org, Tony Lindgren , Viresh Kumar , "Rafael J. Wysocki" , Linux Kernel Mailing List , Enric Balletbo i Serra , Rob Herring , =?UTF-8?Q?Andr=C3=A9_Roth?= , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , kernel@pyra-handheld.com, Teresa Remmet , Javier Martinez Canillas , Linux-OMAP , arm-soc , Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 11, 2019 at 12:47 PM H. Nikolaus Schaller wrote: > > See DM3730,DM275 data sheet (SPRS685B) footnote (6) in Table 4-19 > which says that ABB must be switched to FBB mode when using the > OPP1G. > > The LOD definition abb_mpu_iva already exists so that we need > to add plumbing for vbb-supply = <&abb_mpu_iva> > and define two voltage vectors for each OPP so that the abb LDO > is also updated by the ti-cpufreq driver. > > We also must switch the ti_cpufreq_soc_data to multi_regulator. > > Note: reading out the abb reglator voltage to verify that > it does do transitions can be done by > > cat /sys/devices/platform/68000000.ocp/483072f0.regulator-abb-mpu/regulator/regulator.*/microvolts > > Likewise, read the twl4030 provided VDD voltage by > > cat /sys/devices/platform/68000000.ocp/48070000.i2c/i2c-0/0-0048/48070000.i2c:twl@48:regulator-vdd1/regulator/regulator.*/microvolts > > Note: to check if the ABB FBB is enabled/disabled, check > registers > > PRM_LDO_ABB_CTRL 0x483072F4 bit 3:0 1=bypass 5=FBB > PRM_LDO_ABB_SETUP 0x483072F0 0x00=bypass 0x11=FBB > > e.g. > > /dev/mem opened. > Memory mapped at address 0xb6fe4000. > Value at address 0x483072F4 (0xb6fe42f4): 0x3205 > /dev/mem opened. > Memory mapped at address 0xb6f89000. > Value at address 0x483072F4 (0xb6f892f4): 0x3201 > > Note: omap34xx and am3517 have/need no comparable LDO > or mechanism. > > Suggested-by: Adam Ford > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/omap36xx.dtsi | 21 ++++++++++++++++----- > drivers/cpufreq/ti-cpufreq.c | 2 +- > 2 files changed, 17 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi > index cb5bd0969124..4bb4f534afe2 100644 > --- a/arch/arm/boot/dts/omap36xx.dtsi > +++ b/arch/arm/boot/dts/omap36xx.dtsi > @@ -23,6 +23,7 @@ > cpu: cpu@0 { > operating-points-v2 = <&cpu0_opp_table>; > > + vbb-supply = <&abb_mpu_iva>; > clock-latency = <300000>; /* From omap-cpufreq driver */ > }; > }; > @@ -37,9 +38,11 @@ > /* > * we currently only select the max voltage from table > * Table 4-19 of the DM3730 Data sheet (SPRS685B) > - * Format is: > + * Format is: cpu0-supply: > + * vbb-supply: > */ > - opp-microvolt = <1012500 1012500 1012500>; > + opp-microvolt = <1012500 1012500 1012500>, > + <1012500 1012500 1012500>; > /* > * first value is silicon revision bit mask > * second one is "speed binned" bit mask > @@ -50,25 +53,33 @@ > > opp100-600000000 { > opp-hz = /bits/ 64 <600000000>; > - opp-microvolt = <1200000 1200000 1200000>; > + opp-microvolt = <1200000 1200000 1200000>, > + <1200000 1200000 1200000>; > opp-supported-hw = <0xffffffff 3>; > }; > > opp130-800000000 { > opp-hz = /bits/ 64 <800000000>; > - opp-microvolt = <1325000 1325000 1325000>; > + opp-microvolt = <1325000 1325000 1325000>, > + <1325000 1325000 1325000>; > opp-supported-hw = <0xffffffff 3>; > }; > > opp1g-1000000000 { > opp-hz = /bits/ 64 <1000000000>; > - opp-microvolt = <1375000 1375000 1375000>; > + opp-microvolt = <1375000 1375000 1375000>, > + <1375000 1375000 1375000>; > /* only on am/dm37x with speed-binned bit set */ > opp-supported-hw = <0xffffffff 2>; > turbo-mode; If / when the thermal changes I submitted get approved, would you entertain dropping this turbo-mode flag so it's enabled by default? adam > }; > }; > > + opp_supply_mpu_iva: opp_supply { > + compatible = "ti,omap-opp-supply"; > + ti,absolute-max-voltage-uv = <1375000>; > + }; > + > ocp@68000000 { > uart4: serial@49042000 { > compatible = "ti,omap3-uart"; > diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c > index 1a3073a3093e..f4704f9033e0 100644 > --- a/drivers/cpufreq/ti-cpufreq.c > +++ b/drivers/cpufreq/ti-cpufreq.c > @@ -174,7 +174,7 @@ static struct ti_cpufreq_soc_data omap36xx_soc_data = { > .efuse_shift = 9, > .efuse_mask = BIT(9), > .rev_offset = OMAP3_CONTROL_IDCODE - OMAP3_SYSCON_BASE, > - .multi_regulator = false, > + .multi_regulator = true, > }; > > /** > -- > 2.19.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel