From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24DCC2D0C2 for ; Tue, 31 Dec 2019 11:56:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1A3D206E4 for ; Tue, 31 Dec 2019 11:56:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dZHqMmi4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gNuVa9ER" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1A3D206E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tlzIHad7LML882fDMH6R0zjO+XQUMxr+qjCn1zl1BQ4=; b=dZHqMmi4bUU55O ltJYsI9D893ZHCbZI5xGpUWb6hXh+s0o6ItgC9coTuttre4srQTxfevU8Mnq1n15I8BNneOjywBQK FYqp1FXwpJxJtOKARcBKWJ/9nBVM1G72Y/1ifO/2+RMkmgOa+TOI8Sj6h5tnop5eYF4pDbPfLC1qT 79q9FW/oVDoGBHTZ73QyRBQ7u4qHt2ehkLqRxO1xcpQ2zOXcReIMndEvDveo58SKf5qk3djYqMrqx QRZpgP4Xv19x4Pl5bTHK+OsURA5ulFWhCS/IKHhLg9A6ZAdF7dr6jP0hX3wQmI0da9vay1Te0pGyc Axf876fYunSPwjwhlszw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imG88-000294-93; Tue, 31 Dec 2019 11:56:08 +0000 Received: from mail-il1-x141.google.com ([2607:f8b0:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imG85-00028h-Fm for linux-arm-kernel@lists.infradead.org; Tue, 31 Dec 2019 11:56:07 +0000 Received: by mail-il1-x141.google.com with SMTP id c4so30050292ilo.7 for ; Tue, 31 Dec 2019 03:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wRSoVG7cCI8RPd1O5aFFP++WrWKbrAcGftrzygloTqE=; b=gNuVa9ERTruOoBaJxIXpopQR+oQGk+HQhJoOydnBc4Nmwd6xzsOZD71zH7BibY/f4g fKmJ/wttxm4AZkmrTuZkrHUSB1K57WRgvBnB7Wvsz6pwdzHi/lwkOHsgykz99uj/WBiG qMza9bW0MNiYGk4kik5hSoKPveOaJymYPCerMPigFD3JpCkeKKBbntUme7xZW1deKmOb pDsSqUDR05o0ObUeJb7rYZjjusmDYdoY8v8l6z3+kMVdqnDbV6v1KJWD1C/Byaf152E0 c+myf0Rf2GAux1BiBI4QcW0hRr10N3NzGyOQQr8APtdSB66SAwpYqmWEriepPnJcd6pU wSbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wRSoVG7cCI8RPd1O5aFFP++WrWKbrAcGftrzygloTqE=; b=nyWzm5FgnMv8TEaKhe8NECrnknp4xpxFS+HGu9vm8fAjBH4p8f9UteLYRwUcWvv16L SjjJHpQSD+5/raUDdaut3GPHd/nnEHciVev4dfSQkihqZoue8VuHc2FC5BNtgnM+GtNk i59suERarh+YXuBGmhAxkYg55VuTTrvDTyug3CXcrpvsq1P2y8RtBEK49HK3pzM1folL 6xppm8fcn7Em+18tAIUExQG3j9p6qRcL2KDkvq/wLV/YKX3b2DOJ8cy20ihIzJ8SCeKF QYnKxM2pl5NrF5GcwP/riImKJssWIyvjqMjbY9v02ysGpqrGOS+fQB0/RxKt+5dGueUU dKfg== X-Gm-Message-State: APjAAAW9cn9AupGBUygpOtP3yfqeN0rqAPviaz58eLGk7AxzRfOYFoYF L5aMvkvJh9cn69GljKn04AcfjX2no+VAGufmntg= X-Google-Smtp-Source: APXvYqxGi/VsO07u/hy1PTWndLoEFjaXkDuRfYk7YN5TKACSWIbuNO0OWp4ZUtPx1NAtNjv69g5PqA7CLzsYQs588A8= X-Received: by 2002:a92:1547:: with SMTP id v68mr58685041ilk.58.1577793363751; Tue, 31 Dec 2019 03:56:03 -0800 (PST) MIME-Version: 1.0 References: <20191213160542.15757-1-aford173@gmail.com> In-Reply-To: From: Adam Ford Date: Tue, 31 Dec 2019 05:55:50 -0600 Message-ID: Subject: Re: [PATCH V2 0/7] soc: imx: Enable additional functionality of i.MX8M Mini To: Jacky Bai X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191231_035605_527312_5828DEA5 X-CRM114-Status: GOOD ( 46.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Peng Fan , Fabio Estevam , Sascha Hauer , Linux Kernel Mailing List , Rob Herring , dl-linux-imx , Pengutronix Kernel Team , Leonard Crestez , Shawn Guo , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 30, 2019 at 7:06 PM Jacky Bai wrote: > > > -----Original Message----- > > From: Adam Ford > > Sent: Sunday, December 22, 2019 10:58 PM > > To: Jacky Bai > > Cc: arm-soc ; Peng Fan > > ; Rob Herring ; Mark Rutland > > ; Shawn Guo ; Sascha > > Hauer ; Pengutronix Kernel Team > > ; Fabio Estevam ; > > dl-linux-imx ; devicetree ; > > Linux Kernel Mailing List ; Leonard Crestez > > > > Subject: Re: [PATCH V2 0/7] soc: imx: Enable additional functionality of > > i.MX8M Mini > > > > On Sun, Dec 22, 2019 at 2:33 AM Jacky Bai wrote: > > > > > > > -----Original Message----- > > > > From: Adam Ford > > > > Sent: Saturday, December 21, 2019 11:07 PM > > > > To: arm-soc > > > > Cc: Peng Fan ; Jacky Bai ; Rob > > > > Herring ; Mark Rutland ; > > > > Shawn Guo ; Sascha Hauer > > > > ; Pengutronix Kernel Team > > > > ; Fabio Estevam ; > > > > dl-linux-imx ; devicetree > > > > ; Linux Kernel Mailing List > > > > ; Leonard Crestez > > > > > > > > Subject: Re: [PATCH V2 0/7] soc: imx: Enable additional > > > > functionality of i.MX8M Mini > > > > > > > > On Fri, Dec 13, 2019 at 10:05 AM Adam Ford > > wrote: > > > > > > > > > > The GPCv2 controller on the i.MX8M Mini is compatible with the > > > > > driver used for the i.MX8MQ except for the register locations and > > names. > > > > > The GPCv2 controller is used to enable additional periperals > > > > > currently unavailable on the i.MX8M Mini. In order to make them > > > > > function, the > > > > > GPCv2 needs to be adapted so the drivers can associate their power > > > > > domain to the GPCv2 to enable them. > > > > > > > > > > This series makes one include file slightly more generic, adds the > > > > > iMX8M Mini entries, updates the bindings, adds them to the device > > > > > tree, then associates the new power domain to both the OTG and > > > > > PCIe controllers. > > > > > > > > > > Some peripherals may need additional power domain drivers in the > > > > > future due to limitations of the GPC driver, but the drivers for > > > > > VPU and others are not available yet. > > > > > > > > Before I do a V3 to address Rob's comments, I am thinking I'll drop > > > > the items on the GPC that Jacky suggested would not work, and we > > > > don't have drivers for those other peripherals (GPU, VPU, etc.) > > > > anyway. My main goal here was to try and get the USB OTG ports > > > > working, so I'd like to enabled enough of the items on the GPC that > > > > are similar to the i.MX8MQ and leave the more challenging items > > > > until we have either a better driver available and/or actual > > > > peripheral support coming. I haven't seen LCDIF or DSI drivers pushed > > upstream yet, so I doubt we'll see GPU or VPU yet until those are done. > > > > > > > > Does anyone from the NXP team have any other comments/concerns? > > > > > > > > > > If you look into NXP's release code, you will find that it is not easy > > > to handle the power domain more generically in GPCv2 driver for > > > imx8mm. That's the reason why we use SIP service to handle all the > > > power domain in TF-A. we tried to upstream the SIP version power > > > domain that can be reused for all i.MX8M, but rejected by ARM guys. > > > they think we need to use SCMI to implement it. as there is no SCMI over > > SMC available, upstream is on the way, so the power domain for > > i.MX8MM/MN is pending. > > > > > > > Thank you for the background. I appreciate it. > > > > > Actually, I am confused why we can't use SIP service, even if the SCMI > > > over SMC is ready in the future, It seems the SMCC function ID still need to > > choose from SIP service function id bank. > > > > > > Another concern for adding power domain support in GPCv2 is that, each > > > time a new SOC is added, we need to add hundred lines of code in GPCv2 > > > driver. it is not a best way to keep driver reuse. The GPCv2 driver is > > > originally used for i.MX7D, then reused by i.MX8MQ, as i.MX8MQ has > > > very simple power domain design as i.MX7D. But for i.MX8MM, it is not the > > case. > > > > There are some entries on the 8MM which can be used the same way as the > > 8MM. I have been able to get USB OTG working using the 8MQ's GPC table. > > > > Until sometime better is available, would you entertain a limited use of the > > 8MQ's GPC where the device tree nodes only contain a limited number of > > entries (like USB OTG) where we can re-use the similar functions 8MQ > > without expanding the driver functions? I know its not ideal, but it would be > > a temporary solution unless you think the upstream power domain support is > > coming quickly. I looked through the mailing list history and it looked like > > there were some attempts about > > 6 months ago, then it appeared to stop. > > > > Once the newer driver is available upstream, we could then remove GPC > > references from the 8MM device tree and point it to the new driver. > > > > It would increase some limited functionality for the short term. I know > > Leonard has been working on the DDRC modifications and power reduction. > > I have been trying to use them, but unsuccessful so far. > > > > > > There is another concern, we don't want to export GPC module to rich OS > > side, it is not a must. > > > > What about doing it in the U-Boot stage if Linux isn't an option and ATF isn't > > accepting them? > > > I have enabled the USB/PCIE power domain by default early before, if using the community ATF, > I think USB can work well. Can you point me to which repo you're using? When I use a stock U-Boot from their repo with the ATF referenced from there, the board hangs when USB is initialized. Ideally, I'd like to get USB working on the mainline Linux with mainline U-Boot. adam > > BR > Jacky Bai > > > > > adam > > > > > > BR > > > Jacky Bai > > > > > > > adam > > > > > > > > > > > > > Adam Ford (7): > > > > > soc: imx: gpcv2: Rename imx8mq-power.h to imx8m-power.h > > > > > soc: imx: gpcv2: Update imx8m-power.h to include iMX8M Mini > > > > > soc: imx: gpcv2: add support for i.MX8M Mini SoC > > > > > dt-bindings: imx-gpcv2: Update bindings to support i.MX8M Mini > > > > > arm64: dts: imx8mm: add GPC power domains > > > > > ARM64: dts: imx8mm: Fix clocks and power domain for USB OTG > > > > > arm64: dts: imx8mm: Add PCIe support > > > > > > > > > > .../bindings/power/fsl,imx-gpcv2.txt | 6 +- > > > > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 127 ++++++++- > > > > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +- > > > > > drivers/soc/imx/gpcv2.c | 246 > > > > +++++++++++++++++- > > > > > .../power/{imx8mq-power.h => imx8m-power.h} | 14 + > > > > > 5 files changed, 387 insertions(+), 8 deletions(-) rename > > > > > include/dt-bindings/power/{imx8mq-power.h => imx8m-power.h} (57%) > > > > > > > > > > -- > > > > > 2.20.1 > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel