From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF2FC433DB for ; Wed, 10 Mar 2021 22:45:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2DCB64FC6 for ; Wed, 10 Mar 2021 22:45:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2DCB64FC6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FiY035HYgCx8yx90AX+AOIbfTg/5YcyWqs8sjpxiYDA=; b=dqw3iCxXkn1uBawbbkcgZJ4Fe mM9meMwYayvaG1eEQa3Zo7NpgHZfI5CXPw0JkP+8lqObQbXzH+UDwpE9K+V9rqqMEVk1hy9jboI8k 6FD61FMwtx3QmQJCxjEcd0AMeEBVg46w8M/i/mnFG+DfZrA4rKZHq9vy/kp7dwxTmeEaA74btspjW HsBKWrBlKLPlda59/xSX8QJ8GP3rKechmrxNEoSzgyImRsEL4KAq0Ycz8Wdzmfli7WbDhbbQ4hzho HbBlR4Wl/D/z9aHiJh6a7YSoIAOOn+qlwAVlS+4nYF2krhbY79ujL0pedDm6pf5xLTLSzPSfbz12D o26gMIPgA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lK7Yc-007vWk-NP; Wed, 10 Mar 2021 22:43:58 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lK7YW-007vVp-M3 for linux-arm-kernel@lists.infradead.org; Wed, 10 Mar 2021 22:43:55 +0000 Received: by mail-pf1-x431.google.com with SMTP id 16so11635327pfn.5 for ; Wed, 10 Mar 2021 14:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bwrhIWvuCyPUqA19zbMYRHAdlCdbeAUuN+CsJqbOQv0=; b=kRDEIBh+lQkE5kmFar5i8MTsKZ2QhFKC/304ya3oVAQ2mS+G7wBLqQBMGDlg5StUl1 ePXcmu0c3JIdGaPVTXUMZJGKMZXSvkifMYL63tQA7OP6Cb2GkzYPFsVWzOQIq7Etrtdb 7lXpT/7Mrt7aczeMBbnC4VZBGmsYuNQ7jo81Py/rMMNDyWS9J2ohebYYKdCwlnWyH3uH aQ8Ho54m1/oVeQfu0CObuFyxeywl3m2i1JLA8Y36ie2Xz3kJpsaBazYgae4k/FPmRBOK kkcI2z0yY+iUb42MSwqR0iMBk00uT7Clv7sYJuQ7lH6mN81GcKIah580e8AOa7/ylv3l mJwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bwrhIWvuCyPUqA19zbMYRHAdlCdbeAUuN+CsJqbOQv0=; b=LI9zfnvYBT07zlgOdCjIPeNjczSUbcmSsDLost1KUEW9RWxkdDANzB1hF93xbQSe+9 /99rUCPt37FzgTq6CFEu8v4GlWDn4RWLRR+2Bkt9rFHqA69fg/g/QqGYOLfD2aVj6Ypv q5On205fd/CoU02Q+06ngTy/GIOmMh+RuzDBakTaQRSAju3Y5JNt339FJZGLoznLXTqS /SULXj+gH+5PpC3Q1R3uDZy7jRzPvx3NcRw8VZCaxIkz9idedKUMSBzffrvWkl2FUkhr SrzzkZaFfq9QAm5Za4HIREX8lwZoVFv83W+k4WgEZPrjEJ3x9+oqBUJZSUx+Qdi8oFYE IHaA== X-Gm-Message-State: AOAM531UnhTOV5CGCtD/rFaQh+E5X6EywBaZQ4UJcOFs42/vijSzdE9g ik4p+lvhCqklcUeSmiFr/XAK1TpqS0nu9fXk59U= X-Google-Smtp-Source: ABdhPJwxcr8VOckkpTz7GvCtJag+Yb79XB2ukkd8gKDHVAO09UTwIA+EtYX+1bdWF2aSWSJ8snDzShTxv+bNccW3Ajs= X-Received: by 2002:a05:6a00:ad1:b029:1ec:c826:55aa with SMTP id c17-20020a056a000ad1b02901ecc82655aamr4741276pfl.26.1615416230407; Wed, 10 Mar 2021 14:43:50 -0800 (PST) MIME-Version: 1.0 References: <20210120152813.x2pbs5vprevkly23@fsr-ub1664-175> <20210120155001.GD19063@pengutronix.de> <20210120161421.h3yng57m3fetwwih@fsr-ub1664-175> <20210121095617.GI19063@pengutronix.de> <20210121102450.lisl3mzqczdsmzda@fsr-ub1664-175> <20210215130620.3la4bexamozzcvjx@fsr-ub1664-175> <20210303083119.wadme5a7j4zf7vuz@fsr-ub1664-175> In-Reply-To: From: Adam Ford Date: Wed, 10 Mar 2021 16:43:39 -0600 Message-ID: Subject: Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout To: Abel Vesa Cc: Abel Vesa , Sascha Hauer , arm-soc , Adam Ford-BE , Aisheng Dong , Michael Turquette , Stephen Boyd , Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Linus Walleij , Jerome Brunet , linux-clk , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_224352_850678_FC44D505 X-CRM114-Status: GOOD ( 69.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 10, 2021 at 4:25 PM Abel Vesa wrote: > > On 21-03-03 10:31:19, Abel Vesa wrote: > > On 21-03-02 13:03:04, Adam Ford wrote: > > > On Mon, Feb 15, 2021 at 7:06 AM Abel Vesa wrote: > > > > > > > > On 21-02-13 08:44:28, Adam Ford wrote: > > > > > On Wed, Feb 3, 2021 at 3:22 PM Adam Ford wrote: > > > > > > > > > > > > On Thu, Jan 21, 2021 at 4:24 AM Abel Vesa wrote: > > > > > > > > > > > > > > On 21-01-21 10:56:17, Sascha Hauer wrote: > > > > > > > > On Wed, Jan 20, 2021 at 06:14:21PM +0200, Abel Vesa wrote: > > > > > > > > > On 21-01-20 16:50:01, Sascha Hauer wrote: > > > > > > > > > > On Wed, Jan 20, 2021 at 05:28:13PM +0200, Abel Vesa wrote: > > > > > > > > > > > On 21-01-20 16:13:05, Sascha Hauer wrote: > > > > > > > > > > > > Hi Abel, > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Jan 20, 2021 at 04:44:54PM +0200, Abel Vesa wrote: > > > > > > > > > > > > > On 21-01-18 08:00:43, Adam Ford wrote: > > > > > > > > > > > > > > On Mon, Jan 18, 2021 at 6:52 AM Abel Vesa wrote: > > > > > > > > > > > > > > > > > > > > > > ... > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > TBH, I'm against the idea of having to call consumer API from a clock provider driver. > > > > > > > > > > > > > > > I'm still investigating a way of moving the uart clock control calls in drivers/serial/imx, > > > > > > > > > > > > > > > where they belong. > > > > > > > > > > > > > > > > > > > > > > > > > > > > That makes sense. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Just a thought. The uart clock used for console remains on from u-boot, > > > > > > > > > > > > > so maybe it's enough to just add the CLK_IGNORE_UNUSED flag to all the > > > > > > > > > > > > > uart root clocks and remove the prepare/enable calls for uart clocks > > > > > > > > > > > > > for good. I don't really have a way to test it right now, but maybe > > > > > > > > > > > > > you could give it a try. > > > > > > > > > > > > > > > > > > > > > > > > That would mean that UART clocks will never be disabled, regardless of > > > > > > > > > > > > whether they are used for console or not. That doesn't sound very > > > > > > > > > > > > appealing. > > > > > > > > > > > > > > > > > > > > > > AFAIK, the only uart clock that is enabled by u-boot is the one used for > > > > > > > > > > > the console. Later on, when the serial driver probes, it will enable it itself. > > > > > > > > > > > > > > > > > > > > > > Unless I'm missing something, this is exactly what we need. > > > > > > > > > > > > > > > > > > > > It might enable it, but with CLK_IGNORE_UNUSED the clock won't be > > > > > > > > > > disabled again when a port is closed after usage > > > > > > > > > > > > > > > > > > OK, tell me what I'm getting wrong in the following scenario: > > > > > > > > > > > > > > > > > > U-boot leaves the console uart clock enabled. All the other ones are disabled. > > > > > > > > > > > > > > > > > > Kernel i.MX clk driver registers the uart clocks with flag CLK_IGNORE_UNUSED. > > > > > > > > > > > > > > > > I was wrong at that point. I originally thought the kernel will never > > > > > > > > disable these clocks, but in fact it only leaves them enabled during the > > > > > > > > clk_disable_unused call. > > > > > > > > > > > > > > > > However, when CLK_IGNORE_UNUSED becomes relevant it's too late already. > > > > > > > > I just chatted with Lucas and he told me what the original problem was > > > > > > > > that his patch solved. > > > > > > > > > > > > > > > > The problem comes when an unrelated device and the earlycon UART have > > > > > > > > the same parent clocks. The parent clock is enabled, but it's reference > > > > > > > > count is zero. Now when the unrelated device probes and toggles its > > > > > > > > clocks then the shared parent clock will be disabled due to the > > > > > > > > reference count being zero. Next time earlycon prints a character the > > > > > > > > system hangs because the UART gates are still enabled, but their parent > > > > > > > > clocks no longer are. > > > > > > > > > > > > > > > > > > > > > > Hmm, that is indeed a problem. That's why I think there should be some > > > > > > > kind of NOCACHE flag for almost all the types of clocks. For example, > > > > > > > in this case, it makes sense for the core to check the bit in the register > > > > > > > and then disable the parent based on that instead of relying on the refcount. > > > > > > > Anyway, that's something that needs to be added in the CCF. > > > > > > > > > > > > > > > Overall I think Lucas' patches are still valid and relevant and with > > > > > > > > Adams patches we even no longer have to enable all UART clocks, but > > > > > > > > only the ones which are actually needed. > > > > > > > > > > > > > > Yeah, for now, I think we can go with Adam's patches. But longterm, I would > > > > > > > like to remove the special case of the uart clocks we have right now in all > > > > > > > the i.MX clock drivers. > > > > > > > > > > I looked around at other serial drivers, and I found nothing like this > > > > > function for enabling all UART clocks. There are generic functions > > > > > for registering consoles, earlycon etc, and the serial driver fetches > > > > > the per and igp clocks from the device tree, so I attempted to simply > > > > > remove imx_register_uart_clocks(). I booted an i.MX8M Nano from a > > > > > fully-powered off state, and my serial console came up just fine. > > > > > > > > Just because it works, doesn't mean it is safe. To put it simply, the > > > > risk of some driver disabling a clock that is parent of the uart clock > > > > would render the earlycon broken. > > > > > > > > > > > > > > I checked the clk_summary, and the clock parents are set correctly and > > > > > the respective clock rates appear to be correct (ie, the console is > > > > > working at the desired baud rate, and Bluetooth is happy) > > > > > > > > > > Since I don't fully understand the serial driver and the clock > > > > > dependencies, I don't want to just simply remove the function without > > > > > discussing it, because I don't know the ramifications. However, when > > > > > testing on the i.MX8M Nano, things look OK. > > > > > I also tested suspend-resume and the console UART appears to return > > > > > and the Bluetooth UART set to 4Mbps works just fine too. > > > > > > > > > > I'd like to post a V4 which just removes imx_register_uart_clocks and > > > > > the corresponding calls to it. I don't know enough about the older > > > > > 32-bit i.MX SoC's, but I have build-tested it, and I can generate a > > > > > patch. Are there any objections and/or concerns? > > > > > > > > > > > > > Please don't remove the imx_register_uart_clocks for now. As much as I > > > > would like it gone, the way the earlycon could end up broken is > > > > so ugly that it would make it a real pain to debug it later on. > > > > > > I won't do a V4, but where do we go from here? I have a V3 that was > > > waiting for reviews, but there were some concerns. We currently > > > cannot re-parent the UART's on iMX8MM or iMX8MN. Should I resend V3, > > > or are there fixes/changes requested to V3? > > > > > > > The v3 is fine. No need to resend. > > > > Reviewed-by: Abel Vesa > > > > Please add Ahmad's suggestion and resend. Sorry, I have a backlog. I am hoping to get to it this week. Thanks for the reminder. adam > > I'll pick it up then. > > Thanks, > Abel > > > > adam > > > > > > > > > adam > > > > > > > > > > > > > > > > > > > Is the patch I submitted good enough for someone's acked-by or > > > > > > reviewed-by, or are there changes I need to implement? > > > > > > > > > > > > adam > > > > > > > > > > > > > > > > > > > > > > Sascha > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Pengutronix e.K. | | > > > > > > > > Steuerwalder Str. 21 | https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pengutronix.de%2F&data=04%7C01%7Cabel.vesa%40nxp.com%7C900fb6f7dfdf49776eb208d8ddadd7b7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637503086023262296%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ulZnxvilARLN03%2BEr%2BTKmVOPxRTukN%2FDg3oPY8UJ2AU%3D&reserved=0 | > > > > > > > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > > > > > > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel