From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C82C04FF3 for ; Sat, 22 May 2021 02:34:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5C8461261 for ; Sat, 22 May 2021 02:34:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5C8461261 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a7LtMUmpN7JKAPmyo5afoY9cken2jLhHjKCN6R/Q6KU=; b=TxazViEylWrt+aRks/GuGy9+lf i0+cudgWy164VdLpgv0xjdfw+cErn4OYrNmtZU7KyFxQ0ZRXS74nkyMW8YuVPb73v7pXJoNc7cTqc F39Heq5Ka2zwLWLWdbRkD+pQHD5TBPQ8OmXejlPUbfyH6LaStKZWscHBDvd1cL/R4lI9hXe3zed1x gJc6GN/eGoE3fgBQNRZhDhCCfwfUKHsDLxNjVil3eWQdjyEK8eEPRio+YXxiiMhc3D1UupGm8cgAt Skd1XkpkqPqmPSb3YkDmhC25YkAFc2ydAZXmHEdSpDyxvTTagU8zHgNe7ZftX+EweiqtgZpbY/+Sf PiWwZRcg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkHRM-001eaa-Va; Sat, 22 May 2021 02:32:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkHRL-001eaQ-3X for linux-arm-kernel@desiato.infradead.org; Sat, 22 May 2021 02:32:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bHH470bkXqJd95/yYGo/ipPVf6TM8AxakgkU87EHL6U=; b=bSLKjc7qWH5IGdyssOfwGBj8pp 7X9jIBpQVdIxpJTki3LynpjBhG0nEJgGzf6k6aLB4jfcXIcIVi8t+2iYhHYY7JA0N50wiGGaT2/UV FCVbve43WUkxEl08E2DPXTtjXA6SyVXKan5+03NSAnocDhJ0jPZBa/nIZx/6RYTVsqAQwsXbU1oV3 08EfSMoCilHPGfkT5HEmWlr9SvVP4DH80Uk3rB2GIhhgKtW9Ob3lS1JGgEJ5AcF5bV87E3GZFrwEY 0sb72Vu10KPKgsf+FSqSWnriM9E/iELdBIcdIFao8RmoTvPWR3AXWGEHUGI920hGNN1Du+GlMQYRF lGv8l4mQ==; Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkHRH-00HXOW-Oy for linux-arm-kernel@lists.infradead.org; Sat, 22 May 2021 02:32:33 +0000 Received: by mail-ej1-x636.google.com with SMTP id u21so33057471ejo.13 for ; Fri, 21 May 2021 19:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bHH470bkXqJd95/yYGo/ipPVf6TM8AxakgkU87EHL6U=; b=gQdf//VAsShinxC/gEtaq6+VWcE96uebHoGes+gcs+wDpQKvAN/bysCDImZYFZJYBr HgUKFkM3ZzF9CtygsNvy1pFBoQqyfnfORSh2vCdX77ocCNJpjeQaJwVk4Pcf9bWfzPJV 8d+F1X1eTvqspbAs0aq7KNy6wD83FjESxa31jyEiBg/SjuUBlyk1FNA7NW8d/6/MhU/q +PG2WLM7b+8h+aTIcQXk5nmW3Sq7du8m4LOgbZ7W9/+JnaB6N5uX+wyw13qO9mxRKuU3 ytOZa+leZrY2+SzJtoHUTIe602puZKpVAjn1EmZTN2guWucVMDAnXU5DiEeVSb3Pf9wt NtJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bHH470bkXqJd95/yYGo/ipPVf6TM8AxakgkU87EHL6U=; b=ajnZy73jn92c6z0HQH97l4UJj4Jm2IAuexx/mvlUUZ//Xu6eR2XIroq9MV3CBOBKTv fFbn2lK3k2Yvf7uu2+sUWe8y4gsL7F6HgRja8hKD+0F6j9WkUY1Unq9OCeiDsGIL99eU jYr/Rajtl9nEXpZoXSzTu1LPCsdFI/L+hQ1xxqvpJO2hfFdfm9jbzC80o7KBLXEeByBp Gc7Di8QWXyHGbKsY4sXV9BGtpo4A4q2d4dwXTu6wd/dObmoOQr0+ns9eoaMOthh8Naju t79D/W2z+xiSye2fdOZbsDh4mmD15zDk0Fx9N0CI1hN3jxvqRXNEJ6uOI/Ui8UrVBFgq XTMA== X-Gm-Message-State: AOAM531GrJFojNNnCLe7VH7hxWqIVu6BiDxrs4uTaD0gb7kAh5c/4I4p brDPBSnRGs1IeVd6OPoSIl1+cAf33lDb1eHS9wk= X-Google-Smtp-Source: ABdhPJziNsufNd1c6s8I/DiTbQXx9V7K2wIcfqmrmU1OPXr7r3/wOzV46EWNnMiZFWPPbLshDKq+w8lB46HP9LfmuF4= X-Received: by 2002:a17:906:22c6:: with SMTP id q6mr12892230eja.275.1621650749995; Fri, 21 May 2021 19:32:29 -0700 (PDT) MIME-Version: 1.0 References: <20210521105919.20167-1-peng.fan@oss.nxp.com> In-Reply-To: From: Adam Ford Date: Fri, 21 May 2021 21:32:18 -0500 Message-ID: Subject: Re: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support To: Peng Fan Cc: "Peng Fan (OSS)" , Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Philipp Zabel , Lucas Stach , Krzysztof Kozlowski , =?UTF-8?Q?Guido_G=C3=BCnther?= , Marek Vasut , Andrey Smirnov , devicetree , arm-soc , Linux Kernel Mailing List , Jacky Bai , Schrempf Frieder , Abel Vesa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_193231_843264_7758F2B5 X-CRM114-Status: GOOD ( 44.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 7:54 PM Peng Fan wrote: > > > Subject: Re: [PATCH V5 0/4] soc: imx: add i.MX BLK-CTL support > > > > On Fri, May 21, 2021 at 5:27 AM Peng Fan (OSS) > > wrote: > > > > > > From: Peng Fan > > > > > > V5: > > > Rework the blk-ctl driver to let sub-PGC use blk-ctl as parent power > > > domain to fix the potential handshake issue. > > > I still keep R-b/A-b tag for Patch 1,2,4, since very minor changes I > > > only drop R-b tag for Patch 3, since it has big change. > > > An example, the pgc_mipi not take pgc_dispmix as parent: > > > > > > pgc_dispmix: power-domain@10 { > > > #power-domain-cells = <0>; > > > reg = ; > > > clocks = <&clk IMX8MM_CLK_DISP_ROOT>, > > > <&clk IMX8MM_CLK_DISP_AXI_ROOT>, > > > <&clk IMX8MM_CLK_DISP_APB_ROOT>; > > > }; > > > > > > pgc_mipi: power-domain@11 { > > > #power-domain-cells = <0>; > > > reg = ; > > > power-domains = <&dispmix_blk_ctl > > > IMX8MM_BLK_CTL_PD_DISPMIX_BUS>; > > > > With this change, I get a bunch of errors on boot. The list of power-domains > > appear correct on the surface, but it also has trouble waking from sleep. > > > > [ 0.695947] imx8mm-blk-ctl imx-dispmix-blk-ctl.0: invalid resource > > [ 0.702849] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.0 failed > > with error -22 > > [ 0.711259] imx8mm-blk-ctl imx-dispmix-blk-ctl.1: invalid resource > > [ 0.716451] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.1 failed > > with error -22 > > [ 0.724856] imx8mm-blk-ctl imx-dispmix-blk-ctl.2: invalid resource > > [ 0.730097] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.2 failed > > with error -22 > > [ 0.738398] imx8mm-blk-ctl imx-dispmix-blk-ctl.3: invalid resource > > [ 0.743747] imx8mm-blk-ctl: probe of imx-dispmix-blk-ctl.3 failed > > with error -22 > > It is just the imx8mm-blk-ctl driver matches with the new created > child device, because the child device points the of_node of the parent > device. > But this error will not affect functionality. > I'll resolve this issue and send out v6. > > > > If I have a wrong device tree configuration, can you please post an updated > > device tree? I don't think an official patch for original pgc's were pushed as > > part of either series. I used this e-mail as the patch to enable the blk-ctl. > > Do you have an device tree, I could give a look. I have a git repo where I've been collecting the various power domain patches. I have updated the imx8mn blk-ctl and device trees as well in that same repo. https://github.com/aford173/linux/blob/linux-5.13.y-aford/arch/arm64/boot/dts/freescale/imx8mm.dtsi thanks for looking at this. adam > > Regards, > Peng. > > > > > thanks, > > > > adam > > > > > }; > > > > > > dispmix_blk_ctl: clock-controller@32e28000 { > > > compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon"; > > > reg = <0x32e28000 0x100>; > > > #power-domain-cells = <1>; > > > power-domains = <&pgc_dispmix>, <&pgc_mipi>; > > > power-domain-names = "dispmix", "mipi"; > > > clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk > > IMX8MM_CLK_DISP_AXI_ROOT>, > > > <&clk IMX8MM_CLK_DISP_APB_ROOT>; > > > }; > > > > > > V4: > > > Add R-b tag > > > Typo fix > > > Update the power domain macro names Per Abel and Frieder > > > > > > V3: > > > Add explaination for not listing items in patch 2 commit log Per Rob. > > > Addressed comments from Lucas and Frieder on patch [3,4]. > > > A few comments from Jacky was ignored, because following gpcv2 > > > coding style. > > > > > > V2: > > > Fix yaml check failure. > > > > > > Previously there is an effort from Abel that take BLK-CTL as clock > > > provider, but it turns out that there is A/B lock issue and we are not > > > able resolve that. > > > > > > Per discuss with Lucas and Jacky, we made an agreement that take > > > BLK-CTL as a power domain provider and use GPC's domain as parent, the > > > consumer node take BLK-CTL as power domain input. > > > > > > This patchset has been tested on i.MX8MM EVK board, but one hack is > > > not included in the patchset is that the DISPMIX BLK-CTL > > > MIPI_M/S_RESET not implemented. Per Lucas, we will finally have a MIPI > > > DPHY driver, so fine to leave it. > > > > > > Thanks for Lucas's suggestion, Frieder Schrempf for collecting all the > > > patches, Abel's previous BLK-CTL work, Jacky Bai on help debug issues. > > > > > > > > > Peng Fan (4): > > > dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains > > > Documentation: bindings: clk: Add bindings for i.MX BLK_CTL > > > soc: imx: Add generic blk-ctl driver > > > soc: imx: Add blk-ctl driver for i.MX8MM > > > > > > .../bindings/soc/imx/fsl,imx-blk-ctl.yaml | 66 ++++ > > > drivers/soc/imx/Makefile | 2 +- > > > drivers/soc/imx/blk-ctl-imx8mm.c | 139 ++++++++ > > > drivers/soc/imx/blk-ctl.c | 311 > > ++++++++++++++++++ > > > drivers/soc/imx/blk-ctl.h | 85 +++++ > > > include/dt-bindings/power/imx8mm-power.h | 13 + > > > 6 files changed, 615 insertions(+), 1 deletion(-) create mode 100644 > > > Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml > > > create mode 100644 drivers/soc/imx/blk-ctl-imx8mm.c create mode > > > 100644 drivers/soc/imx/blk-ctl.c create mode 100644 > > > drivers/soc/imx/blk-ctl.h > > > > > > -- > > > 2.30.0 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel