From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCACFC6197 for ; Fri, 8 Nov 2019 21:04:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BF52206C3 for ; Fri, 8 Nov 2019 21:04:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kbY/vyme"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="psjPZbKl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BF52206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TfTPoCj26qsHGB8+r4xHbp7oxSfzguwGZTNt3KAp9uY=; b=kbY/vymeXc91yw NvwrhtW+V/XmNc/kndZBK4AAAgXWKhfJNIiUdXc71+4P7N9ulReJcuCxx5b4zNWG6WIa7z7qfaz9m 13O+rGT2ESacaiRla7N7HgJoNjKeMm0Oyw9NrJAaDiUQ2Mg7IXcF62nlazmjRQ4+Kz/0OBaWf8axW cb2U+TsVuG6wKYVQKIJUcomzc3WCXrHxbaznuL7adwMkitT6anYxDFjYf7RF+720BEWB+D+ROLmqH hKyDEVg/WnbvJ+0/CO0XQVVFNpJPuuJn66RD2L8HeYOpvUd4+tcqSRilTu5V1f5QePRLVyupH4Gmv +paHTrPDdMKhoqnEsAiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTBQh-0005Nu-Rx; Fri, 08 Nov 2019 21:04:27 +0000 Received: from mail-il1-x143.google.com ([2607:f8b0:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTBQf-0005N7-0T for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 21:04:26 +0000 Received: by mail-il1-x143.google.com with SMTP id s75so6357079ilc.3 for ; Fri, 08 Nov 2019 13:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=epWM3knefAqrLqDU/OViVdI12EGBGkgWXZubjUR/AtI=; b=psjPZbKl7eoAeg0Hi65pLLJR5aWpIp8eW6QSp222ruy31He0QUvMMPYRhrRTOqbjcO WrX/TkaI+epYVp0RWOutmHRDB0ez/3x3W/DtQUhmHTGuMsMFWlTRxmobphUxVYkH1GBy iP6rc/fL99P860YoSz3EMeZqiawmzLDunBCI4bD7Ncq/HjAmz5O67/kRM5ZT0AcwwNmk jiPY6tFxcV2KphnhWkMrjwTwDlO0oQ6tm3RQVckZcC4XcIuFLLbrQZh8CWC26b+crYD6 hyxIcuO3eoQroLW/0gKKg421M9rGFyZERm73JMS1XJoGYQUODru4xH7rSppwHXCg+057 PNcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=epWM3knefAqrLqDU/OViVdI12EGBGkgWXZubjUR/AtI=; b=EAcNGviDjFcOMU5tk20tmpCOgFZmykeRtr7S6FjcOaqJrEQntLcmC3ECJzAS+2C49v leKHkhoUxNWf+EcL7mM+JL9MPf9c5YptFkLisw3wpq2IwjvQzJTmac7cm6Jm4FMZwtj8 qbcpiX139LN1jyR+KvKtnhumkJEOksu/dPpzaYtm3MQyLKivbuQWkawtg99a9lesgulD Pil7Eo3ETu7LQncWHLQzkr8Rfs+ZB4jis4J95QCWqIQ15tFa9L9Zs0uXvUfaEem6HPta Bsqk9cDDOLfaN14uCX+yP0xUkO0YkYhkQP3FGFt604Xj+Wy9S9NXVqVnEy38JHu4uDzN mTDw== X-Gm-Message-State: APjAAAWubL2bvAD3CzvtdB1GlcpUGxTjMtZgHfTO+DtKJMyxeBsyaZ6A nC+f7ioPrgXWjAVHMMHbm980rIuVpov9fAmBDmk= X-Google-Smtp-Source: APXvYqw6LOuVT9ebBAj+3hLk3gV0PVdz/r5xYLkm8Egl9Vt/40fOFEiRRhDP1HrKXFl8PUTBOhsUrbzSHNJW3GdbLpM= X-Received: by 2002:a05:6e02:c2c:: with SMTP id q12mr15390187ilg.205.1573247063677; Fri, 08 Nov 2019 13:04:23 -0800 (PST) MIME-Version: 1.0 References: <20191007220540.30690-1-aford173@gmail.com> <20191022162223.GU5610@atomide.com> <20191022221919.GF5610@atomide.com> <1CE62E4E-1A38-448C-9197-8FA16747F942@goldelico.com> <20191023143646.GG5610@atomide.com> <20191108205139.GP5610@atomide.com> In-Reply-To: <20191108205139.GP5610@atomide.com> From: Adam Ford Date: Fri, 8 Nov 2019 15:04:12 -0600 Message-ID: Subject: Re: [PATCH 1/2] configs: ARM: omap2plus: Enable OMAP3_THERMAL To: Tony Lindgren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_130425_049207_9B1B6497 X-CRM114-Status: GOOD ( 21.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , "H. Nikolaus Schaller" , Russell King , Linux Kernel Mailing List , Rob Herring , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Linux-OMAP , Adam Ford , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 8, 2019 at 2:51 PM Tony Lindgren wrote: > > * Adam Ford [191108 20:03]: > > On Wed, Oct 23, 2019 at 9:36 AM Tony Lindgren wrote: > > > My guess is we need to call clk_disable() and call > > > ti_bandgap_save_ctxt() on CPU_CLUSTER_PM_ENTER similar to > > > what ti_bandgap_suspend does. And then restore it on > > > CPU_CLUSTER_PM_EXIT. > > > > > > There's a similar example already in gpio_omap_cpu_notifier(). > > > Not sure if there is some related errata to deal with too, > > > probably the old Nokia n900 or n9 would provide some hints > > > on what exactly needs to be done. > > > > I 'think' I have a patch ready that does what you're asking, but I > > will fully admit that I don't completely grasp what's going on. > > > > I'll submit it as an RFC, but I am not even sure I understand what to > > put into the description, so if you're OK with reviewing the RFC, feel > > free to mark up the actual commit message as well. > > > > From what I can see, the changes haven't negatively impact stuff. I > > didn't see the power consumption go up before, so I am not sure I can > > replicate your findings. > > > > It'll be posted shortly. > > Yeah seems to do the job, thanks for fixing this issue. I am glad I could help! I am learning new stuff. :-) Once the other patch to fix the bandgap clock idling, will it be possible to accept this as-is, or do you need me to re-base and submit again? Ideally, once we get the thermal stuff in and we can drop Nikolaus' turbo option on the 1GHz processor and just let the processor scale to 1GHz without having to deal with the boost stuff since it should throttle back when the junction temp hits its threshold. If you want me to re-base, please let me know which branch I should use. Thank you, adam > > Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel