From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96441CA9EA0 for ; Tue, 22 Oct 2019 19:01:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45E1221783 for ; Tue, 22 Oct 2019 19:01:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pUl8AcB5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m6gaYXo+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45E1221783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=akIYNEbdnvuoeGp4JJ2oKWt/cy5Fgi1Q3ZrGKVHlTTI=; b=pUl8AcB5GgRnlp jc84oWUWO+FjXq6H9dKm2dMbGyW1pbLohwnn25lTlba8aarO4KmdMe6fgTgqHLz0DyhU2ENdvA20U dBdqvyeInEbPZwcd/KW0UIdO/1wravaGs/NroxukjavaR4MeTIBbKmxQK9xeTJveg55zfrnt4vq1s G/j9x/CdjyGY4+zMdekm0tD5rViCi3upLf9vsHUVyrJwkXNjHRqU7XnmOuclqcljZfGCABFgLrt0U 8zScdwLPI3RN5Rh1XXIDNAXaoknhpzRRZTjKxFIg2IeXHeHadqb/OPPYH5ce1UOAzWFNRdgyHDHhH KRoLtGmQ9RUVJreeRDLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMzPJ-0008WK-IZ; Tue, 22 Oct 2019 19:01:25 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMzPG-0008VP-2k for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 19:01:23 +0000 Received: by mail-io1-xd41.google.com with SMTP id t18so17658626iog.2 for ; Tue, 22 Oct 2019 12:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VfxSHYvmdEv1sm79e3HTi1RwgAIgEe7zqfMJ263x0xg=; b=m6gaYXo+SBJ6yxQUD50EHP8m/o2zWCUkcm4zfRYWPqsxcCaBtfI4gR70AjPI0kgvRn oCBJaeHHmvWwyrNPxa4K3iZBQtYc/YciryW1xokRbVbPel4OAQ7wD3RdVFT+QbqAs+F5 PNNim372/STeko7kwHy7AUVu0XinaDph2biqSG7OFr66mu66wVP9slSSX6L8361YyVbX OToJI9/0WCGDmYz1T7ylnPlyUNEkU0JcnkGqSYmNelV95xkG9izQyosIY7Lsb5CeSKKA +/XTgAK8JkkRzYT4SgeRBxN3/f6/fF8O8r7Gz0ca473uHMql5bZDE40m1U3Nq0GX1mEe Pi3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VfxSHYvmdEv1sm79e3HTi1RwgAIgEe7zqfMJ263x0xg=; b=T7PCiPACS1kHE/m0y8v4Yq9A50NlXkMx5Y/H2ss+jgAV6u7SqjqD/L8EqzMDDDd656 xuyhzofX5pbPRwNm6Gy9auxv2R8qI4yFq7KR+nTnQJMrNCft+zmZsRp9Z4TbD6qs8bLy sIaa4MH8oUfXCd/VljAIJsxXJ9gwvLSJGknI0R8QAStX2Trb/RVRqEnn9jUPhC5gjEOx ba4MpHUlOjhw/jHpw64/l3w/m4x3BUQjCvG3T6KYgEb7zicx1qAwe5W+hUuP5YnRCQN0 U8BfQl74BFhyb5wyIxP95a1j5ti+fEKqcybszUhEPxii6VnU8YVilJG6t3liIrV4WIcI oVow== X-Gm-Message-State: APjAAAXbiRK15k1BbOzOmNCaLZ5pdWVmCB5E7soynWMcd6r6avmuCEJb TugxsRCnYglUF/5MY2q/TjbkeoSrGD4gIBYP4eO86g== X-Google-Smtp-Source: APXvYqzQASMPJfj+YZm2OBbuJQoz80q16/O9naj7kf1/88RbHylyV8nyZmARfqkPQXvQ0Q9vaSY+MetI2GXnLHntuLQ= X-Received: by 2002:a02:c519:: with SMTP id s25mr5378905jam.3.1571770880220; Tue, 22 Oct 2019 12:01:20 -0700 (PDT) MIME-Version: 1.0 References: <20191007220540.30690-1-aford173@gmail.com> <20191022162223.GU5610@atomide.com> In-Reply-To: <20191022162223.GU5610@atomide.com> From: Adam Ford Date: Tue, 22 Oct 2019 14:01:08 -0500 Message-ID: Subject: Re: [PATCH 1/2] configs: ARM: omap2plus: Enable OMAP3_THERMAL To: Tony Lindgren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_120122_159439_5E8B421B X-CRM114-Status: GOOD ( 24.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , "H. Nikolaus Schaller" , Russell King , Linux Kernel Mailing List , Rob Herring , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Linux-OMAP , Adam Ford , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 22, 2019 at 11:22 AM Tony Lindgren wrote: > > Hi, > > * Adam Ford [191007 15:06]: > > The some in the OMAP3 family have a bandgap thermal sensor, but > > omap2plus has it disabled. > > > > This patch enables the OMAP3_THERMAL by default like the rest of > > the OMAP family. > > Looks like this breaks off mode during idle for omap3, and that's > probably why it never got enabled. The difference in power > consumption during idle is about 7mW vs 32mW for the SoC as > measured from torpedo shunt for main_battery_som. > > I think the right fix might be simply to add handling for > CPU_CLUSTER_PM_ENTER to the related thermal driver to disable > it during idle like we have for gpio-omap.c for example. I am not sure I know where to start on fixing that issue. Would you entertain enabling the driver if we set the device tree to 'disabled' by default? This way if people want to to use it, it can be enabled on a per-device option. Once the power stuff gets resolved, we might be able to enable it by default. For people who are planning on using the DM3730 @ 1GHz in high temp environments, I am not sure they'll care about low power. I'll try to look into it when I have time, but I was hoping a compromise might be a reasonable work-around. adam > > Regards, > > Tony > > > > > Signed-off-by: Adam Ford > > > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > > index 8f1c2b6f9e56..7e14a8c8bb29 100644 > > --- a/arch/arm/configs/omap2plus_defconfig > > +++ b/arch/arm/configs/omap2plus_defconfig > > @@ -292,6 +292,7 @@ CONFIG_THERMAL_GOV_FAIR_SHARE=y > > CONFIG_THERMAL_GOV_USER_SPACE=y > > CONFIG_CPU_THERMAL=y > > CONFIG_TI_THERMAL=y > > +CONFIG_OMAP3_THERMAL=y > > CONFIG_OMAP4_THERMAL=y > > CONFIG_OMAP5_THERMAL=y > > CONFIG_DRA752_THERMAL=y > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel