From: Andrey Smirnov <andrew.smirnov@gmail.com> To: Trent Piepho <tpiepho@impinj.com> Cc: "aisheng.dong@nxp.com" <aisheng.dong@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "robh@kernel.org" <robh@kernel.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "bhelgaas@google.com" <bhelgaas@google.com>, "linux-imx@nxp.com" <linux-imx@nxp.com>, "fabio.estevam@nxp.com" <fabio.estevam@nxp.com>, "leonard.crestez@nxp.com" <leonard.crestez@nxp.com>, "cphealy@gmail.com" <cphealy@gmail.com>, "l.stach@pengutronix.de" <l.stach@pengutronix.de> Subject: Re: [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ Date: Thu, 28 Feb 2019 17:16:21 -0800 Message-ID: <CAHQ1cqHfFivDSwt2Xo7n8qnrnZxSuzmx0he3irYg6Oxp_g=--w@mail.gmail.com> (raw) In-Reply-To: <1551389037.6059.3.camel@impinj.com> On Thu, Feb 28, 2019 at 1:24 PM Trent Piepho <tpiepho@impinj.com> wrote: > > On Tue, 2019-02-12 at 10:36 +0100, Lucas Stach wrote: > > Am Montag, den 11.02.2019, 17:51 -0800 schrieb Andrey Smirnov: > > > PCIe IP block has additional clock, "pcie_aux", that needs to be > > > controlled by the driver. Add code to support that. > > This breaks iMX7d. > Ugh, my bad, sorry about that. > > > > > > @@ -1049,6 +1059,12 @@ static int imx6_pcie_probe(struct platform_device *pdev) > > > dev_err(dev, "Failed to get PCIE APPS reset control\n"); > > > return PTR_ERR(imx6_pcie->apps_reset); > > > } > > > + > > > + imx6_pcie->pcie_aux = devm_clk_get(dev, "pcie_aux"); > > > + if (IS_ERR(imx6_pcie->pcie_aux)) { > > > + dev_err(dev, "pcie_aux clock source missing or invalid\n"); > > > + return PTR_ERR(imx6_pcie->pcie_aux); > > > + } > > > break; > > > default: > > > break; > > One can't see enough context in the patch above, but in linux-next this > section is under > > case IMX7D: > case IMX8MQ: > > It's being applied to imx7d and not just imx8mq and so breaks because > imx7d dts files don't have this clock. Not sure if this is a bug in > this commit or some kind of merge/rebase mistake. > This is just a regular bug, I spaced out and missed the fact that this path is shared between the two. I'll submit a patch moving "pci_aux" clock request into a i.MX8MQ specific patch shortly. Thanks, Andrey Smirnov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-12 1:51 [PATCH 0/2] " Andrey Smirnov 2019-02-12 1:51 ` [PATCH 1/2] dt-bindings: imx6q-pcie: Add "pcie_aux" clock for imx8mq Andrey Smirnov 2019-02-12 8:57 ` Lucas Stach 2019-02-25 23:39 ` Rob Herring 2019-02-12 1:51 ` [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ Andrey Smirnov 2019-02-12 9:36 ` Lucas Stach 2019-02-28 21:23 ` Trent Piepho 2019-03-01 1:16 ` Andrey Smirnov [this message] 2019-02-19 12:42 ` [PATCH 0/2] " Lorenzo Pieralisi 2019-02-19 12:46 ` Lucas Stach
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHQ1cqHfFivDSwt2Xo7n8qnrnZxSuzmx0he3irYg6Oxp_g=--w@mail.gmail.com' \ --to=andrew.smirnov@gmail.com \ --cc=aisheng.dong@nxp.com \ --cc=bhelgaas@google.com \ --cc=cphealy@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=fabio.estevam@nxp.com \ --cc=hongxing.zhu@nxp.com \ --cc=l.stach@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=robh@kernel.org \ --cc=tpiepho@impinj.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git