From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF487C43381 for ; Fri, 1 Mar 2019 01:16:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BA9B2087E for ; Fri, 1 Mar 2019 01:16:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B8e+8D4g"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qrQZzQQf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BA9B2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S0rNR4Ee2u14bHt4nWtFQvdx12puQjI6s7nWlUiXR4M=; b=B8e+8D4glq9cKD h9ydb5/QXU3cQarBWoi57OJL3N2dyjFaybC5SLS4u4uRIE7kEa5qe9swVMvzGp29peKKQzrjI+hAb yk7aER4Fk2v0ca2k4sEJor8MNvzHrnwnvlorcCRET4ZBPJ8p9AXs1aJr+OWOJqZYzz2EZnlfxtE5y sYBi6UQP759ba75ZZSfgG80o+54eH2fw6bcQOC38cnY9m8Ku5t7JQlpe3sefXv6x6nveF/OOQt5fN d5A9YKcF9g5vZ9FNE4gfWRSWtdjtVkRkzoH5Kds3FKjRIeJKCw07yqPMQs/osM+Uqhjw2/379xo5R 4IeIMuJdL/ZQbWAQKepA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzWn0-0006Hs-Ne; Fri, 01 Mar 2019 01:16:38 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzWmx-0006HX-1U for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 01:16:36 +0000 Received: by mail-wm1-x341.google.com with SMTP id y15so10737002wma.0 for ; Thu, 28 Feb 2019 17:16:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i4ygx22LOUdRqlYNAEC5fBDNS9ew8UErJ+sc47ljCzk=; b=qrQZzQQfod1pzn+QvcKzNCVyRV8cQ/0eHZipvWWvznPEp6hZakMcfyiq9cT644tC6C Pza/Sx1CTeP0wiHLZK97Gyue6Lsnq2UlBpmDPCQLkOGknE4rW7XtGdbes793rx9wpsJx ijqnuGikUDqeLxxsfnhtJdh85wasadGh/yHOfBLpg/0dzz/45CtiIqSojMy255GzXbCV Fl6Ss/xVuKT34yM3bknZmGLj51CYq5g54dNWhdDm00jHICearBI91n2WC7WGbdYfBGHH 4DJU4lwYQibc5q/GBUpf1dIosQ4pHmMzqiI8H6cwS5Cp1Y+Q5IgbFV/JzMx5xw7+Xnra iRvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i4ygx22LOUdRqlYNAEC5fBDNS9ew8UErJ+sc47ljCzk=; b=qFevmT6YTcrXLPMF0sTPXRi8cFZvu9AInELHJuoA/FpLukyOQ3a9NK3A3GTUCNmRDp AvynS8mOKLFpU2d/Rx+98C4gkaCJuX/y8D97xWwnuXKN6HCMsNlt4xDjOjEhUFuF7OP0 GBPWvKIyzLGiQVwkrCrWyJ80m5b0OWyAGE2i2Lsi8T61SzqqrMnd43KWWKnJVL+GWvQg WgPDXIR9kcgPWHhQ16cnsds3+ljPHmNHPf3nxO/4Wsp944GpuPPPd6UzHmhL7lmu7esx vpyHLDTqd0iEJ4FdtWvP9p+0LB4kwgXTaJkJpVPZwVf1AmqwiYaWda6iHrJN9vfvKBzT GXIQ== X-Gm-Message-State: AHQUAuZB5AoRxsvogysjQrnBBXOv23hONmtZI3fGXEYZi/iXFZ0oouHD 3O408GficrNYSE+0WNF7yglxWrFs7EFVc1YBL5w= X-Google-Smtp-Source: APXvYqzMRqxZNnv8gdAZk8UO9eAVdBhnWbWJwhsYufyeZXqLrDnA06Cf49zdyH59MrtbQ4KNwiYahEXbR2kfr6zvrmM= X-Received: by 2002:a7b:cf3a:: with SMTP id m26mr1478052wmg.144.1551402993002; Thu, 28 Feb 2019 17:16:33 -0800 (PST) MIME-Version: 1.0 References: <20190212015108.16952-1-andrew.smirnov@gmail.com> <20190212015108.16952-3-andrew.smirnov@gmail.com> <1549964166.2546.21.camel@pengutronix.de> <1551389037.6059.3.camel@impinj.com> In-Reply-To: <1551389037.6059.3.camel@impinj.com> From: Andrey Smirnov Date: Thu, 28 Feb 2019 17:16:21 -0800 Message-ID: Subject: Re: [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ To: Trent Piepho X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_171635_109698_41FC3A46 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "aisheng.dong@nxp.com" , "devicetree@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , "hongxing.zhu@nxp.com" , "linux-arm-kernel@lists.infradead.org" , "robh@kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "linux-imx@nxp.com" , "fabio.estevam@nxp.com" , "leonard.crestez@nxp.com" , "cphealy@gmail.com" , "l.stach@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Archived-At: List-Archive: On Thu, Feb 28, 2019 at 1:24 PM Trent Piepho wrote: > > On Tue, 2019-02-12 at 10:36 +0100, Lucas Stach wrote: > > Am Montag, den 11.02.2019, 17:51 -0800 schrieb Andrey Smirnov: > > > PCIe IP block has additional clock, "pcie_aux", that needs to be > > > controlled by the driver. Add code to support that. > > This breaks iMX7d. > Ugh, my bad, sorry about that. > > > > > > @@ -1049,6 +1059,12 @@ static int imx6_pcie_probe(struct platform_device *pdev) > > > dev_err(dev, "Failed to get PCIE APPS reset control\n"); > > > return PTR_ERR(imx6_pcie->apps_reset); > > > } > > > + > > > + imx6_pcie->pcie_aux = devm_clk_get(dev, "pcie_aux"); > > > + if (IS_ERR(imx6_pcie->pcie_aux)) { > > > + dev_err(dev, "pcie_aux clock source missing or invalid\n"); > > > + return PTR_ERR(imx6_pcie->pcie_aux); > > > + } > > > break; > > > default: > > > break; > > One can't see enough context in the patch above, but in linux-next this > section is under > > case IMX7D: > case IMX8MQ: > > It's being applied to imx7d and not just imx8mq and so breaks because > imx7d dts files don't have this clock. Not sure if this is a bug in > this commit or some kind of merge/rebase mistake. > This is just a regular bug, I spaced out and missed the fact that this path is shared between the two. I'll submit a patch moving "pci_aux" clock request into a i.MX8MQ specific patch shortly. Thanks, Andrey Smirnov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel