From: pullip.cho@samsung.com (KyongHo Cho)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver
Date: Tue, 6 Sep 2011 19:27:59 +0900 [thread overview]
Message-ID: <CAHQjnONHr-Ao_KLjdRKgVQQUKtOmmoyqFwdkSZCDsE6hx1q-Ug@mail.gmail.com> (raw)
In-Reply-To: <1314971786-15140-3-git-send-email-m.szyprowski@samsung.com>
Hi.
On Fri, Sep 2, 2011 at 10:56 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> + *
> + * iova must be aligned on a 4kB, 64kB, 1MB and 16MB boundaries, respectively.
> + */
Actually, iova is just needed to be aligned by 4KiB because it is
minimum requirement.
I think IOMMU driver is capable of mapping a group of page frames that
is aligned
by 1MiB with an iova that is aligned by 4KB
if the iova is large enough to map the given page frames.
> +static int s5p_sysmmu_map(struct iommu_domain *domain, unsigned long iova,
> + ? ? ? ? ? ? ? ? ? ? ? ? phys_addr_t paddr, int gfp_order, int prot)
> +{
> + ? ? ? struct s5p_sysmmu_domain *s5p_domain = domain->priv;
> + ? ? ? int flpt_idx = flpt_index(iova);
> + ? ? ? size_t len = 0x1000UL << gfp_order;
> + ? ? ? void *flpt_va, *slpt_va;
> +
> + ? ? ? if (len != SZ_16M && len != SZ_1M && len != SZ_64K && len != SZ_4K) {
> + ? ? ? ? ? ? ? sysmmu_debug(3, "bad order: %d\n", gfp_order);
> + ? ? ? ? ? ? ? return -EINVAL;
> + ? ? ? }
Likewise, I think this driver need to support mapping 128KiB aligned,
128KiB physical memory, for example.
Otherwise, it is somewhat restrictive than we expect.
Thank you.
Cho KyongHo.
next prev parent reply other threads:[~2011-09-06 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 13:56 [RFC 0/2 v2] ARM: DMA-mapping & IOMMU integration Marek Szyprowski
2011-09-02 13:56 ` [PATCH 1/2] ARM: initial proof-of-concept IOMMU mapper for DMA-mapping Marek Szyprowski
2011-09-08 16:41 ` [Linaro-mm-sig] " Laura Abbott
2011-09-21 14:50 ` Marek Szyprowski
2011-10-10 21:56 ` Krishna Reddy
2011-10-11 8:19 ` Marek Szyprowski
2011-10-11 18:13 ` Krishna Reddy
2011-10-12 1:34 ` Krishna Reddy
2011-10-12 5:49 ` Marek Szyprowski
2011-10-12 7:02 ` Krishna Reddy
2011-10-13 0:18 ` Krishna Reddy
2011-10-17 14:07 ` Marek Szyprowski
2011-09-02 13:56 ` [PATCH 2/2] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver Marek Szyprowski
2011-09-05 18:21 ` Ohad Ben-Cohen
2011-09-06 10:27 ` KyongHo Cho [this message]
2011-09-06 12:35 ` [Linaro-mm-sig] " Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQjnONHr-Ao_KLjdRKgVQQUKtOmmoyqFwdkSZCDsE6hx1q-Ug@mail.gmail.com \
--to=pullip.cho@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).