From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B24C47094 for ; Thu, 10 Jun 2021 09:46:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E92A613E3 for ; Thu, 10 Jun 2021 09:46:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E92A613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=owvGyH8r/Ytw7ji6leR8qQ5pgicxqUXag+FOM+5t9Nk=; b=K1Cugank6SBUm+ kmiehi0CM0728aeGGjVWRZdGmQ58lZuDUL2+lzjg/Mf45Xe8B7yktj++fupxlF4K8ns/ZnDW7QXAR ELnlW3kQqc1H+AhIYd+I1fEBfMrzB2q/HXqZ1tZRU3NLUG2WGZPzIp7c3tusdASmHb9jp+82FDPyn OjQkejd02KS/uc04JRtbK46VxPLwzzKQTVsOVMMk9LvmHYulVFhVSJF7W2xCaD3CLVzob9xaTiQvi 9QI+YKCtwHzPq3ZLahWoTgtzuEkP33jO/XraVXhIyUAqJpxuN1q2/esAbc6XmaDO7lXTrRPmN0xW9 I2TcZ4ldU+Am/Yb3JGbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrHEN-000Fhw-EO; Thu, 10 Jun 2021 09:44:08 +0000 Received: from mail-wm1-f43.google.com ([209.85.128.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrGgr-0006rB-MK for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 09:09:31 +0000 Received: by mail-wm1-f43.google.com with SMTP id s70-20020a1ca9490000b02901a589651424so4401708wme.0 for ; Thu, 10 Jun 2021 02:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9sWa4PTmyAX1nPFLXf55YhYnjMvPUrhFAQy3A/xW4Ro=; b=tcvwXsQcFO4v2O30nFo/+ootpa3l5mnUGTfVmArzpX2Q6gSj6uNQbr/Hq82FdJDy2n QFEysE0lLnnB+vp5iGctu6f+ADXysjN6bJ81UPXfRe67bk2Ufjz69p8B6nobT98v1rxG zX5QasRn4NreeJwvCbtod2288rYVJlI8kr9Il0F6SxuMhT0uDVuXZSHLIRfzNy5oNep4 rGvAV1bcWJhF9yct/An65qa030UVVyd4jhUA5PDbS97uVrpW+Rk5tBDtpmxfl7RIDxgz VtA65n7qkCPaDjQvmJd1sRgWOjyRw7TwC7cZdQZ82q+XB8rJ/7T2VzBtxhCsJt0+w09H 70qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9sWa4PTmyAX1nPFLXf55YhYnjMvPUrhFAQy3A/xW4Ro=; b=L7kmrx93r8ABOMJczQ1ktpeNB8qCTNwx+V2uPAiOFDhzbDdyAqqyHZyAS4akVT0UOP Akiasrb8RevEM18qHwBNreG4iD8w/Hy2Ag4mQyNDEy/sDzZQKjXWtSatQR1mXCIc36CV tofATyjY3AF7r+qZ7jvZJ2Hgc8ffdtLh8pjPWRLnRMP8IJIFPPXd8DwDBcRab+NEaMU7 F1b5Mfqv/mI8BumTSKoX+1EF9nM0zxeqQ2m3CdVHMgTBfx1qAcr7b+DCa/b/00Re21Wf 5nacwpdHwkt5f5MpRQ+qHxvXTbzC32rKrXCQ/9OHr6cHi25GlH8sVmMWzZw6KHdZiiJZ LC5Q== X-Gm-Message-State: AOAM531VJoCP4U1W8aIuGQ4cB+I12aRl69DIQ/cPZQe2Yp7QfdiJVfYu Yn1icMxXZpeFdLIXIu1E+Q3JVSEtSbASHdPo7G/TxQ== X-Google-Smtp-Source: ABdhPJwpgmIUWV3cUSE4xlzYXM+9q5mCegFROUhTel9Rk/3Y5jckv0H6v3ATlSgrFDSyqPt1S1mgLquVq5FkK5BfLhE= X-Received: by 2002:a7b:c853:: with SMTP id c19mr14237840wml.30.1623316107589; Thu, 10 Jun 2021 02:08:27 -0700 (PDT) MIME-Version: 1.0 References: <20210609102324.2222332-1-jens.wiklander@linaro.org> <20210609102324.2222332-7-jens.wiklander@linaro.org> <20210609145811.GJ4910@sequoia> In-Reply-To: <20210609145811.GJ4910@sequoia> From: Jens Wiklander Date: Thu, 10 Jun 2021 11:08:16 +0200 Message-ID: Subject: Re: [PATCH 6/7] firmware: tee_bnxt: use tee_shm_alloc_kernel_buf() To: Tyler Hicks Cc: Linux Kernel Mailing List , Linux ARM , OP-TEE TrustedFirmware , Sumit Garg , Herbert Xu , Sakkinen , Sasha Levin , Thirupathaiah Annapureddy , Vikas Gupta , "David S . Miller" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_020929_826473_85E9647E X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 9, 2021 at 4:58 PM Tyler Hicks wrote: > > On 2021-06-09 12:23:23, Jens Wiklander wrote: > > Uses the new simplified tee_shm_alloc_kernel_buf() function instead of > > the old deprecated tee_shm_alloc() function which required specific > > TEE_SHM-flags. > > > > Signed-off-by: Jens Wiklander > > Since this series is essentially a rewrite of the shm allocation logic, > it is worth pointing out that the rewrite still uses contiguous > allocations (from alloc_pages()). The tee_bnxt_fw driver is performing > an order-10 allocation which is the max, by default. I've only tested > tee_bnxt_fw when it was built-in to the kernel and tee_bnxt_fw_probe() > was called early in boot but I suspect that it might not succeed when > built as a module and loaded later after memory is segmented. I think > this driver would benefit from being able to request a non-contiguous > allocation. > > Is this rewrite a good time to offer drivers a way to perform a > non-contiguous allocation? Good idea, I'll look into that. I'll add it as a separate patch if it works OK. Cheers, Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel