From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F9CC432BE for ; Fri, 27 Aug 2021 09:28:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDE7060FD8 for ; Fri, 27 Aug 2021 09:28:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BDE7060FD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ec9VcYPLrSETa1+3Bx12SNUBnsboK8GSnsX2thC08zg=; b=Cbntr1TmGzHFqj JN2Io17ZmDWVOGNnUxskFzB6xeLNyEJ+ItJCcLfSmXPtiaDTKSUmDB5VeNZwGJXweXp6lMXnV07ay FnrKTLiinwkIcjlBsuxBeOelMJgbzwyj91CyFOC5YyBlPsVm3JvpwYV/FFBnew0XSzhpo2eHPoQ/X E2d65FpL/4f/3x2qglIU52fn7x9+YMBvQeDQr9ErG6jFfjhIBbyRDrSrGKg2PcycP6xUsEeQT4+LJ IRZ+16YvzEbLuQqCM9GO/aMIJCZqVT5flAUg/hog1hXX8BzMIgtE+1lo4suDbCSqR8xTb3LGPMqa8 JaW/yYFkJwEnFQvTHULw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJY8B-00C2YH-3E; Fri, 27 Aug 2021 09:26:35 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJY84-00C2XP-G9 for linux-arm-kernel@lists.infradead.org; Fri, 27 Aug 2021 09:26:32 +0000 Received: by mail-wm1-x32e.google.com with SMTP id j17-20020a05600c1c1100b002e754875260so3866816wms.4 for ; Fri, 27 Aug 2021 02:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J6/pEtsmPXEr0DtFJnmn/n99lBxeuj7y7P+Ae72uWNQ=; b=vZc+T8ZJ5gxdka3g7nbaqKV+ZU6QpU9zFc87THqV1N/i935mxvSXs1i/6uwHXRieOa SjrRUWflUO13YVT8+YN7YwUcrlFNMLI84ElZusvAkRonrkz4FjGnmdXj0SPdbIrzR0nv 4V49QcYGaup0/9vk1+YfuB//5c135qDiZSacEVRCzV6iBRHb60JE9c/yKkTXR5XmDBD8 QRTX8SjWmsQAWuAwox82XN4zVxqbry7RR5S8SWkQ7W3+p0WldKaojovLG4B6/edg2fNK 7HN9MC/CrjdBiMVAojfyWOCFoUraKLEYOzxYzDWhtQPga+SW28llKhg31IvcxOtpkVw3 uM7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J6/pEtsmPXEr0DtFJnmn/n99lBxeuj7y7P+Ae72uWNQ=; b=AZl+uYk1kwH0EJn6CNoXRPMxgEMKKnJvEMN+EPOr37+kpAUTywjKsZT0UlRdibo6zF sD7h/FX7PGKew+ABYvLIukkAH5EQEQ9Fhjijh3N4BhoXPz8a+tQlUNTLB2j0q2NQ3+7R fx4EOvW4T6LDPUZUCk5ajxPdBQw0z1pnZc9TJQr7nUDxf8H0VH1uyTLQskd4EoQ6k88a ioH1q2hlN5LezVjRDW/q7aseksTObXd/J0Lh2Na1L34F/R8UBl1p33G5itrnovjOLlsX kAz1P1yrXg1yiXAWHFWMySS0nLtuI23khga/Gcfsd6jbJdoO2qH7A17vNxbl37ts7cH/ QhgQ== X-Gm-Message-State: AOAM530aWOxLoPDqYYpf4s5c2AMh1K8XIfFuLC1pWrVUT6t4hvnbQKnE gOXXQUK3KohW7wuSdWngA5ymZe0nKncin5XAlj3K2A== X-Google-Smtp-Source: ABdhPJxP25HXbRNWYHpFECApZlJdkZZuMsS8vVNriqMiucQtuEHv3oeceyFUPqFLuy/KFSXL3jIp70xsVV7PNU48G0A= X-Received: by 2002:a1c:3b05:: with SMTP id i5mr7759579wma.136.1630056386806; Fri, 27 Aug 2021 02:26:26 -0700 (PDT) MIME-Version: 1.0 References: <20210826123032.1732926-1-jens.wiklander@linaro.org> <20210826123032.1732926-5-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Fri, 27 Aug 2021 11:26:16 +0200 Message-ID: Subject: Re: [PATCH v5 4/6] tee: add tee_dev_open_helper() primitive To: Sumit Garg Cc: Linux Kernel Mailing List , linux-arm-kernel , OP-TEE TrustedFirmware , Devicetree List , Linux Doc Mailing List , Jerome Forissier , Etienne Carriere , Vincent Guittot , Rob Herring , Jonathan Corbet , Ard Biesheuvel , Marc Zyngier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210827_022628_591569_0754692F X-CRM114-Status: GOOD ( 35.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 27, 2021 at 8:23 AM Sumit Garg wrote: > > On Thu, 26 Aug 2021 at 18:00, Jens Wiklander wrote: > > > > Adds tee_dev_open_helper() and tee_dev_ctx_put() to make it easier to > > create a driver internal struct tee_context without the usual > > tee_device_get() on the struct tee_device as that adds a circular > > reference counter dependency and would prevent the struct tee_device > > from ever being released again. > > Can you elaborate regarding the circular dependency issue you are > referring to? IIUC, lifespan for struct tee_device would look like > below with normal teedev_open(): > > optee_probe() { > ... > tee_device_alloc() <- teedev->num_users = 1 > tee_device_register() > optee_notif_init() <- tee_device_get() > ... > } > > optee_remove() { > ... > optee_notif_uninit() <- tee_device_put() > tee_device_unregister() <- tee_device_put() > ... > } You're right, it works just as well without this patch. teedev_close_context() and teedev_open() must be exported in another patch though. I'll replace this patch with such a patch in the next patch set. Thanks, Jens > > -Sumit > > > > > Signed-off-by: Jens Wiklander > > --- > > drivers/tee/tee_core.c | 33 ++++++++++++++++++++++++--------- > > include/linux/tee_drv.h | 27 +++++++++++++++++++++++++++ > > 2 files changed, 51 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > > index 85102d12d716..3beb682684a8 100644 > > --- a/drivers/tee/tee_core.c > > +++ b/drivers/tee/tee_core.c > > @@ -43,14 +43,11 @@ static DEFINE_SPINLOCK(driver_lock); > > static struct class *tee_class; > > static dev_t tee_devt; > > > > -static struct tee_context *teedev_open(struct tee_device *teedev) > > +struct tee_context *tee_dev_open_helper(struct tee_device *teedev) > > { > > int rc; > > struct tee_context *ctx; > > > > - if (!tee_device_get(teedev)) > > - return ERR_PTR(-EINVAL); > > - > > ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); > > if (!ctx) { > > rc = -ENOMEM; > > @@ -66,10 +63,30 @@ static struct tee_context *teedev_open(struct tee_device *teedev) > > return ctx; > > err: > > kfree(ctx); > > - tee_device_put(teedev); > > return ERR_PTR(rc); > > > > } > > +EXPORT_SYMBOL_GPL(tee_dev_open_helper); > > + > > +void tee_dev_ctx_put(struct tee_context *ctx) > > +{ > > + teedev_ctx_put(ctx); > > +} > > +EXPORT_SYMBOL_GPL(tee_dev_ctx_put); > > + > > +static struct tee_context *teedev_open(struct tee_device *teedev) > > +{ > > + struct tee_context *ctx; > > + > > + if (!tee_device_get(teedev)) > > + return ERR_PTR(-EINVAL); > > + > > + ctx = tee_dev_open_helper(teedev); > > + if (IS_ERR(ctx)) > > + tee_device_put(teedev); > > + > > + return ctx; > > +} > > > > void teedev_ctx_get(struct tee_context *ctx) > > { > > @@ -90,10 +107,8 @@ static void teedev_ctx_release(struct kref *ref) > > > > void teedev_ctx_put(struct tee_context *ctx) > > { > > - if (ctx->releasing) > > - return; > > - > > - kref_put(&ctx->refcount, teedev_ctx_release); > > + if (ctx && !ctx->releasing) > > + kref_put(&ctx->refcount, teedev_ctx_release); > > } > > > > static void teedev_close_context(struct tee_context *ctx) > > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > > index 3ebfea0781f1..00a31ff03049 100644 > > --- a/include/linux/tee_drv.h > > +++ b/include/linux/tee_drv.h > > @@ -458,6 +458,33 @@ static inline int tee_shm_get_id(struct tee_shm *shm) > > */ > > struct tee_shm *tee_shm_get_from_id(struct tee_context *ctx, int id); > > > > +/** > > + * tee_dev_open_helper() - helper function to make a struct tee_context > > + * @teedev: Device to open > > + * > > + * Creates the struct tee_context without increasing the reference counter > > + * on @teedev. This is needed for instance when a driver need an internal > > + * struct tee_context to operate on. By skipping the reference counter > > + * the circular dependency is broken. > > + * > > + * Note that this struct tee_context need special care when freeing in > > + * order to avoid the normal put on the struct tee_device. > > + * tee_dev_ctx_put() is the best choice for this. > > + * > > + * @returns a pointer 'struct tee_context' on success or an ERR_PTR on failure > > + */ > > +struct tee_context *tee_dev_open_helper(struct tee_device *teedev); > > + > > +/** > > + * tee_dev_ctx_put() - helper function to release a struct tee_context > > + * @ctx: The struct tee_context to release > > + * > > + * Note that this function doesn't do a tee_device_put() on the internal > > + * struct tee_device so this function should normal only be used when > > + * releasing a struct tee_context obtained with tee_dev_open_helper(). > > + */ > > +void tee_dev_ctx_put(struct tee_context *ctx); > > + > > /** > > * tee_client_open_context() - Open a TEE context > > * @start: if not NULL, continue search after this context > > -- > > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel