From: Jens Wiklander <jens.wiklander@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: "Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Arve Hjønnevåg" <arve@google.com>,
"Andrew Walbran" <qwandor@google.com>,
"David Hartley" <dhh@qti.qualcomm.com>,
"Achin Gupta" <Achin.Gupta@arm.com>,
"Arunachalam Ganapathy" <arunachalam.ganapathy@arm.com>,
"Marc Bonnici" <marc.bonnici@arm.com>
Subject: Re: [PATCH v7 4/5] firmware: arm_ffa: Setup in-kernel users of FFA partitions
Date: Tue, 25 May 2021 08:29:42 +0200 [thread overview]
Message-ID: <CAHUa44FqpTq87snH+yowQwVXbLE-tzfMCvK01L+uCv=XbPoJJg@mail.gmail.com> (raw)
In-Reply-To: <20210521151033.181846-5-sudeep.holla@arm.com>
On Fri, May 21, 2021 at 5:10 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Parse the FFA nodes from the device-tree and register all the partitions
> whose services will be used in the kernel.
>
> In order to also enable in-kernel users of FFA interface, let us add
> simple set of operations for such devices.
>
> The in-kernel users are registered without the character device interface.
>
> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
> Tested-by: Jens Wiklander <jens.wiklander@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/firmware/arm_ffa/bus.c | 9 ++
> drivers/firmware/arm_ffa/common.h | 3 +
> drivers/firmware/arm_ffa/driver.c | 220 ++++++++++++++++++++++++++++++
> include/linux/arm_ffa.h | 38 +++++-
> 4 files changed, 269 insertions(+), 1 deletion(-)
>
[snip]
> --- a/include/linux/arm_ffa.h
> +++ b/include/linux/arm_ffa.h
> @@ -6,7 +6,6 @@
> #ifndef _LINUX_ARM_FFA_H
> #define _LINUX_ARM_FFA_H
>
> -#include <linux/cdev.h>
> #include <linux/device.h>
> #include <linux/module.h>
> #include <linux/types.h>
> @@ -15,6 +14,7 @@
> /* FFA Bus/Device/Driver related */
> struct ffa_device {
> int vm_id;
> + bool mode_32bit;
> uuid_t uuid;
> struct device dev;
> };
> @@ -48,6 +48,7 @@ int ffa_driver_register(struct ffa_driver *driver, struct module *owner,
> const char *mod_name);
> void ffa_driver_unregister(struct ffa_driver *driver);
> bool ffa_device_is_valid(struct ffa_device *ffa_dev);
> +const struct ffa_dev_ops *ffa_dev_ops_get(struct ffa_device *dev);
>
> #else
> static inline
> @@ -70,6 +71,10 @@ static inline void ffa_driver_unregister(struct ffa_driver *driver) {}
> static inline
> bool ffa_device_is_valid(struct ffa_device *ffa_dev) { return false; }
>
> +const struct ffa_dev_ops *ffa_dev_ops_get(struct ffa_device *dev)
I believe this should be static inline.
Cheers,
Jens
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-25 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 15:10 [PATCH v7 0/5] firmware: Add initial support for Arm FF-A Sudeep Holla
2021-05-21 15:10 ` [PATCH v7 1/5] firmware: arm_ffa: Add initial FFA bus support for device enumeration Sudeep Holla
2021-05-21 15:10 ` [PATCH v7 2/5] firmware: arm_ffa: Add initial Arm FFA driver support Sudeep Holla
2021-05-21 15:10 ` [PATCH v7 3/5] firmware: arm_ffa: Add support for SMCCC as transport to FFA driver Sudeep Holla
2021-05-21 15:10 ` [PATCH v7 4/5] firmware: arm_ffa: Setup in-kernel users of FFA partitions Sudeep Holla
2021-05-25 6:29 ` Jens Wiklander [this message]
2021-05-25 9:02 ` Sudeep Holla
2021-05-21 15:10 ` [PATCH v7 5/5] firmware: arm_ffa: Add support for MEM_* interfaces Sudeep Holla
2021-06-01 16:23 ` [PATCH v7 0/5] firmware: Add initial support for Arm FF-A Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHUa44FqpTq87snH+yowQwVXbLE-tzfMCvK01L+uCv=XbPoJJg@mail.gmail.com' \
--to=jens.wiklander@linaro.org \
--cc=Achin.Gupta@arm.com \
--cc=arunachalam.ganapathy@arm.com \
--cc=arve@google.com \
--cc=dhh@qti.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.bonnici@arm.com \
--cc=qwandor@google.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).