From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C473DC2B9F8 for ; Tue, 25 May 2021 06:32:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 885CE610A5 for ; Tue, 25 May 2021 06:32:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 885CE610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DW0KySs3BlvBv6uvwUGx7hm3ojRymOJ1Uapi8mzwL2U=; b=B5ZrRmFUYXCA7A gONkfsXIvpvVo3eReLRunduhxnYPs2Og4BHEpaQylVo1JF3jjrEwRh+8cuNxaRkYBZkTLQwnbDME3 pvn4r0zvxBsH0ByNADa8pDYAMCtpPuIUbn3xguKrz/5OrdpUroBbw9O0cu+HGnV479hZAUDpvNjuJ p/7wZ/ECcoIiNBctrbZgEWTXCCk70TBM7d2ATvVHd5N0AeeJDZl49gvqlFVHOegmUJUt/q1yXrz2y UfT2Eg/WwcUIiOPMKBPD9vPnT+glQdAImYszSSOjoMaGBxt8+3ALYgBqyy8YVOlOmDdWzzUJC3eQW Cjn0NWISKtEDnzYMg9ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llQaR-003dDu-P1; Tue, 25 May 2021 06:30:45 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llQZf-003d08-9T for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 06:29:56 +0000 Received: by mail-wr1-x436.google.com with SMTP id q5so30830773wrs.4 for ; Mon, 24 May 2021 23:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y+UVp52ieI56Vh7swZhbtZvxJ35LAduhb1XLWBaYnqY=; b=xuRrX4o+Qb1M1SQcsVrsehHwpbLSBoeIWQ2xsoHV25s++/qUVx2gq6fas3aAzyur4y OPt/N7y4boJlSxsGHFtrL0+jjNAL9BjZj1XUY9IYTdTD8l2x9Ngws+831GiZmLQrHS+X gdRJLa3z7K9gaK/JuvPDsic2LAn7SgD+8Mr9ImIcYQz54cWCwsMVyYeoqE4x2+o2Ir31 NYu6onW6BVt/T/nY411gCWIyBU63It1g7Ee5C5CpYSSNZihCZhWawR5g+dcL3v2A/EX7 L9nmgEZyJXSMbMhbbtwWl4GIvNeHWLjj2jzrIWJSjT8abZjt33HLcoFnPA6xt4IsAROV qz6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y+UVp52ieI56Vh7swZhbtZvxJ35LAduhb1XLWBaYnqY=; b=qBZtV2Le4hG4TtVFw2Uidzkc1hKuoBeoEYK2bWjfll66RGDNfw9Ooy2NMH3Dq/IDQ7 uG/4SNWjbH+iZsBH91KaXEM+62Max57TCi6j6hf9zvnCVQi0i8PH0wwyhiVun9lcVI6G xsv5HEVl1cdBRYMokhsTBHvvB519sRO7AwT7NWbAragw8XpIfBEhIvmLxvGx1S306Wsn B2P6qOK1qX/0TsuF3RtcLHRkxYU1nlsMQkT9PgVKVfrto7RlyD/WIpFM+nogQ+pp5HDW YJbD8fx6kTJKLtOa4tdcLIyYSldJfQDKUzpCwIYJ1F8DDmdgjzWbxWTSj634y8ogHZSb OZEA== X-Gm-Message-State: AOAM530oaZmMhCh+4Uf0ZdJx4CRdnXmt68Ity35u6gnnFWNnBAY4MeiP /c9AyVW/afIgyopEZKl+sxKEDsz0BYSkXoYst6Do4A== X-Google-Smtp-Source: ABdhPJxizH5AMdX0bh4SGMdKx07Ofkm1f0fwX4qMmJbEIISnOIqAKQgBCA+dTlQqmoAae6PS0X3NTdte9+8sIle6KGc= X-Received: by 2002:adf:cd8c:: with SMTP id q12mr24665504wrj.43.1621924193091; Mon, 24 May 2021 23:29:53 -0700 (PDT) MIME-Version: 1.0 References: <20210521151033.181846-1-sudeep.holla@arm.com> <20210521151033.181846-5-sudeep.holla@arm.com> In-Reply-To: <20210521151033.181846-5-sudeep.holla@arm.com> From: Jens Wiklander Date: Tue, 25 May 2021 08:29:42 +0200 Message-ID: Subject: Re: [PATCH v7 4/5] firmware: arm_ffa: Setup in-kernel users of FFA partitions To: Sudeep Holla Cc: Linux ARM , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Andrew Walbran , David Hartley , Achin Gupta , Arunachalam Ganapathy , Marc Bonnici X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_232955_400198_EDC91257 X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 5:10 PM Sudeep Holla wrote: > > Parse the FFA nodes from the device-tree and register all the partitions > whose services will be used in the kernel. > > In order to also enable in-kernel users of FFA interface, let us add > simple set of operations for such devices. > > The in-kernel users are registered without the character device interface. > > Reviewed-by: Jens Wiklander > Tested-by: Jens Wiklander > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_ffa/bus.c | 9 ++ > drivers/firmware/arm_ffa/common.h | 3 + > drivers/firmware/arm_ffa/driver.c | 220 ++++++++++++++++++++++++++++++ > include/linux/arm_ffa.h | 38 +++++- > 4 files changed, 269 insertions(+), 1 deletion(-) > [snip] > --- a/include/linux/arm_ffa.h > +++ b/include/linux/arm_ffa.h > @@ -6,7 +6,6 @@ > #ifndef _LINUX_ARM_FFA_H > #define _LINUX_ARM_FFA_H > > -#include > #include > #include > #include > @@ -15,6 +14,7 @@ > /* FFA Bus/Device/Driver related */ > struct ffa_device { > int vm_id; > + bool mode_32bit; > uuid_t uuid; > struct device dev; > }; > @@ -48,6 +48,7 @@ int ffa_driver_register(struct ffa_driver *driver, struct module *owner, > const char *mod_name); > void ffa_driver_unregister(struct ffa_driver *driver); > bool ffa_device_is_valid(struct ffa_device *ffa_dev); > +const struct ffa_dev_ops *ffa_dev_ops_get(struct ffa_device *dev); > > #else > static inline > @@ -70,6 +71,10 @@ static inline void ffa_driver_unregister(struct ffa_driver *driver) {} > static inline > bool ffa_device_is_valid(struct ffa_device *ffa_dev) { return false; } > > +const struct ffa_dev_ops *ffa_dev_ops_get(struct ffa_device *dev) I believe this should be static inline. Cheers, Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel