From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84435C433DB for ; Fri, 8 Jan 2021 19:46:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 168E223A7B for ; Fri, 8 Jan 2021 19:46:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 168E223A7B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jeoZlzbMT+vWpfjJEATuSodphmCb/GowAFglSFV3/Oo=; b=j7oiIhmnAwtaxX6/BGVFvVZ6a FSOjnTu7tbZppdAjgGBNbbZ1i3yPyYUEg7Ls5d+v5iQdf/uwRItOqdeBPAe3yZXZULSiJ7+90SNxS KTE9ZKYmJjwCKJV5Rg9kfKMUbw5MDTzUiDFSopkAjRtpnkOEmnsKrkUqWzCO31bAqpNoAOyP4EqGu amPqKkBpR3Ns6exDWh0PLXxTaMJnCalZJmZ27OmrL9mDk79mS2t49z0vUF92aHWKPll6zWo7Ucqq2 7fKYdZDKPoTpXH77/XpLrA7B9jshc9DhAv/CA7gzbCxt7sxnNrUUD7mtXJdJHM5k1VAwieMfkkYV4 8i4O10wiQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxxf4-00075J-0P; Fri, 08 Jan 2021 19:43:02 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxxf1-00074Q-Di for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 19:43:00 +0000 Received: by mail-lf1-x12e.google.com with SMTP id o10so14725695lfl.13 for ; Fri, 08 Jan 2021 11:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zyk0hmvOCmlf96OHjavNOOWZKXPdqm3y4uCVwGOPVVs=; b=Twey0HfDIE2MlqEURpSvHVkJLmkrIAf1QsDiId4VmSGRbgzqVpRXfv4JuljsdpWkY2 hBMh8AEu5reKfgO15Ne6WbVrqrp5hlLzOCuW0IwkjDbpEB4eLNTnEZXOtFjRixzY+rgU 5G8AG5Ypo8vvd+q3R6RgzYd1DGcjDChC5vVF0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zyk0hmvOCmlf96OHjavNOOWZKXPdqm3y4uCVwGOPVVs=; b=lXxELlBhv7Hc7YStXHlewLmhNphVeMi3QyauLHhVyT0Ll9QGaZnEbPOB0RSFNlKIk8 BMksUfoNJSgBKUX25UoC8wq/YOxoAJeVKXi6J5JTrbdeaytWnj0Q66vo8rS0KOa1uOTO pWMQwCR6710KFa5xzruDOSToyzNGOX6DVTN+r+Cz2m/B2qqZl8g6P3HDYAE++gQHYLiC H+BFoQB4qqJIjxN8wdbyDXlqTth3W6bZs9FNtPOrR7v7tmszkzmfuAt9l3bSWezi2qT7 JrndpgKmcCBm0Aw4xjbTh6gF4sx8i99SWjcCOCTzOGPC48BgB2OYHD5yyCLwn97xrrtt zo8A== X-Gm-Message-State: AOAM533D3opI9LdXjxDmWhUyDY/a/V17bTW7EuWWXvbQtrmUok2a9GTf WJMerMvWB2vdYYkhJmGZ6C+zSL6Gne2zig== X-Google-Smtp-Source: ABdhPJyZJgIYaSeujvwtz6WdRCqXwkypxPVd3LcRwWXaGD8o2MRECqsp92BNvPjaFuXYVq/WYHU6ug== X-Received: by 2002:a19:8b83:: with SMTP id n125mr2442454lfd.75.1610134976730; Fri, 08 Jan 2021 11:42:56 -0800 (PST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id v10sm2309889lji.130.2021.01.08.11.42.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jan 2021 11:42:55 -0800 (PST) Received: by mail-lf1-f42.google.com with SMTP id 23so25580143lfg.10 for ; Fri, 08 Jan 2021 11:42:55 -0800 (PST) X-Received: by 2002:a2e:6f17:: with SMTP id k23mr2233926ljc.411.1610134974839; Fri, 08 Jan 2021 11:42:54 -0800 (PST) MIME-Version: 1.0 References: <20210108171517.5290-1-will@kernel.org> In-Reply-To: From: Linus Torvalds Date: Fri, 8 Jan 2021 11:42:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/3] Create 'old' ptes for faultaround mappings on arm64 with hardware access flag To: Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_144259_581039_F493012E X-CRM114-Status: GOOD ( 13.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , Linux Kernel Mailing List , Linux-MM , Vinayak Menon , "Kirill A . Shutemov" , Andrew Morton , Android Kernel Team , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 8, 2021 at 11:34 AM Linus Torvalds wrote: > > Yeah, I think that's a side effect of "now the code really makes a lot > more sense". Your subsequent patches 2-3 certainly are much simpler > now On that note - they could be simpler still if this was just done entirely unconditionally.. I'm taking your word for "it makes sense", but when you say On CPUs with hardware AF/DBM, initialising prefaulted PTEs as 'old' improves vmscan behaviour and does not appear to introduce any overhead. in the description for patch 3, it makes me wonder how noticeable the overhead is on the hardware that _does_ take a fault on old pte's.. IOW, it would be lovely to see numbers if you have any like that.. Both ways, actually. Because I also wonder how noticeable the vmscan improvement is. You say there's no measurable overhead for platforms with hardware dirty/accessed bits, but maybe there's not a lot of measurable improvements from a more exact accessed bit either? Linus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel