From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752ABC56201 for ; Fri, 20 Nov 2020 17:32:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05C9022210 for ; Fri, 20 Nov 2020 17:32:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hAgisy7o"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="BFMI34mC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05C9022210 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k6R+OPf+tPpH1+QgO+e++PQ1bRE5eu1llnJIHT+GjWI=; b=hAgisy7ojTrXrvBMdUGhmj/yB MSLQ5iMUM0gEOiUMll++9pxQKNMBXi3jkKZO63EHNVEzvxBlEKqQzej9BpGFAolnLpvTjb7Smbg8z g+uRBpOxnUsP1huxUBJGsmpJC9YNGJP2kSbJ1TvxDhYfMCiwSLqnWrg/WYUe9UrrFMdroHhhf3uNK u0ylLjqd1dT9RFZgQ+TnqpTE1pdgKpsxhiFgefDfTWCMBrqPfRJ22QcmYEz7eFmMhlqa+8z3TLsiH iWayHuWsbkgSoHJaa1gojOdhP2ulBQu3XHhmrYiuAzzr9uXZK/CXDUTVK5nMKtndzUKMg6ZUaikBC xD77lf4KQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgAFy-0001U2-6k; Fri, 20 Nov 2020 17:31:34 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgAFv-0001Sp-7d for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 17:31:32 +0000 Received: by mail-lf1-x143.google.com with SMTP id d17so14535859lfq.10 for ; Fri, 20 Nov 2020 09:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lItF3xfzrkMwAcEP2AiG8imrdLGggrsmJi1buDvkPRQ=; b=BFMI34mCS8datX5bZPIO32Ia6Z0khqyvljC/F2ipby+FA8y7zjtEPDzufwkKCXsjGY 0SEsiwdU89ifjQNP6kPAg5YDmJ1pPYqqdG3Ywcja1hlPVrYYsR7s+pMKUtp9768p9l63 Pt/TtziP5KCnD3DRevsTzPb9SNDDLTK2uFSEQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lItF3xfzrkMwAcEP2AiG8imrdLGggrsmJi1buDvkPRQ=; b=WvjEiHnDJ6aksFdG4NOgLoK2KV4/0h9YKtXMbYG+weR6r7tPiXi93If8DvPfleMcZR rhUwO+eGxeFe1jH/LpV56Q0iL5QaUMu0oma59aqMHH+vHdzEEUk7A4lEVZ1EiaSFjaTT pYeS6t/Fd2dYlCdfA0Bqv/donu4HNk8SsY3bIznO+CrQwjE1VHhjuHk6J1BWZPkHPLHR tbhGYAvt3bAR7WfFCCur9tdmtugp9cM30ihZj7w/IhTreNrBErDy5DojRv2Vb2xNjC7F WYnZ2lVfcIs95WKtT2IEiFPiGT9nuZwlbho9f6sfsj9ZsNV9Zn9HX7By0lWuWI49ScjK reOQ== X-Gm-Message-State: AOAM5338c5EdVpZFzH0dLwef9BNvLpvhZDUexVIPFYrf21CfoSVTA+sx YD3rwsK7heh4cL9049erA1nuvgyluV97Pw== X-Google-Smtp-Source: ABdhPJxilQPh2L2iMCx+31gy6XVIGrFvXAeZQNIAf8t249wduUmfOrfVw/q9Zoutwk61CjQEHzZpsg== X-Received: by 2002:a05:6512:3118:: with SMTP id n24mr8048598lfb.292.1605893488974; Fri, 20 Nov 2020 09:31:28 -0800 (PST) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id u4sm340919ljj.104.2020.11.20.09.31.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2020 09:31:26 -0800 (PST) Received: by mail-lj1-f182.google.com with SMTP id o24so10859526ljj.6 for ; Fri, 20 Nov 2020 09:31:26 -0800 (PST) X-Received: by 2002:a2e:9bd2:: with SMTP id w18mr8866461ljj.312.1605893486061; Fri, 20 Nov 2020 09:31:26 -0800 (PST) MIME-Version: 1.0 References: <20201120143557.6715-1-will@kernel.org> <20201120143557.6715-6-will@kernel.org> In-Reply-To: From: Linus Torvalds Date: Fri, 20 Nov 2020 09:31:09 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm() To: Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_123131_424256_AA509618 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yu Zhao , Anshuman Khandual , Peter Zijlstra , Catalin Marinas , Linux Kernel Mailing List , Linux-MM , Minchan Kim , Android Kernel Team , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Oh - wait. Not ack. Not because this is wrong, but because I think you should remove the start/end arguments here too. The _only_ thing they were used for was that "fullmm" flag, afaik. So now they no longer make sense. Hmm? Linus On Fri, Nov 20, 2020 at 9:22 AM Linus Torvalds wrote: > > On Fri, Nov 20, 2020 at 6:36 AM Will Deacon wrote: > > > > Introduce tlb_gather_mmu_fullmm() to make it clearer that this is for the > > entire mm and WARN() if tlb_gather_mmu() is called with an 'end' address > > greated than TASK_SIZE. > > Ack (but with a spello note - "greated"). > > Linus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel