From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E5DC433DB for ; Fri, 19 Mar 2021 10:22:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3076064F40 for ; Fri, 19 Mar 2021 10:21:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3076064F40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+5zqZMn0+pLcYngM/oeEpsmA1iY5CoWN68eoYqBSvwo=; b=hbkVc5BI5JJpUvcp7eQA9j98Z tqzod2uCkj9jjM77kqNOg2HTyHmEBmZTiD5Xa3qzYX1OdxGepYpqp3fDBolsZKL3i2k9VTyuccjV2 UNkjKHlhn2La4R6fS7WFXaEC2vMYTT3kpc4pCoZYNa6fvSxZRYoXNHuA0LQWMoYPaRaJki8MjUCdV uYi31WeY1Y700odxNvT9nWx+BRgTvczdV610vWKH5XR5WHCQ/S4tjU9/ROzjAGPrbuf+4NNP6UwBp h6bk3BI0QSt8I0CKj3mOweCOGqfbEjata5iIutaQgXT39FMGjYzDM/XSoyKUZieQpNhjN7G+v2a6Q i+mu0bZvA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lNCEc-0076fr-3O; Fri, 19 Mar 2021 10:20:02 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lNBzW-0071E1-Vc for linux-arm-kernel@lists.infradead.org; Fri, 19 Mar 2021 10:04:29 +0000 Received: by mail-pf1-x429.google.com with SMTP id b184so5534204pfa.11 for ; Fri, 19 Mar 2021 03:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cIF840WHHbMimxYNljpuxfKSY2LGH6W0yrfdQOXK+HY=; b=W4sLJB0lgpMy0BvORgwtEupsCMdBI157b42/+emInFb3Bc09VDbS+fWcmDegZgSXVe NQJ1sgjjophd9NNS2QUpwoHEOe8YeyFFS4BO02XtbO5TRvrjAg/85AsK0HZOf1yf2YSv SCXFxZUyI2H7KgdD6jy+AeaP5GlW2S2Q/KyCdwQ9evvWzoZgEGMYdFE4jIDNbBImWJ4b 8qmV28c5xQpm0XcpSXGvCFlqCPe72L0nd9yTg5R7N/EAAwb6yGg9QO15MgdecBNArorE lmY1FqVrhOBvr6rgNrcUvLTZXzXYgc6zWJitE9bn8xaeyUdi6N9wa4OPfVxwvJ5RYFwA CCZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cIF840WHHbMimxYNljpuxfKSY2LGH6W0yrfdQOXK+HY=; b=lHOyt1v5Oq31bPdLBvvRIN7loU8oKP3h9nJSRgqd/jRO3ASttopc0CHi/7L5t972fa XuJdtc0OWsHvSrvRfUpgjO2DGGBfzOHFTdIMtdfeFxZ2ferNirst2FEg7+AJcQ/PugXp tRJpMjYaQ5dcVoYkMBOMSM5irkFts+l06vAHCCCOrevrhrol2KH2T/mqrCziyny3ux8p wmyQ3spbrKLG+XkpsjFeqQLYDThpAFTA4DcD5yrEH38LugHDgKv13RrRuRLQK/DJW1Pi Rh/jLaW25MZIn7UXecLgEieFH2YclykVxr0fS1ZogUW37RKPmpxGtz2HbIUG0IKTL9sx 4H0Q== X-Gm-Message-State: AOAM530PGc/GMtpxfoB/DNvYvuYqDEe4YEA3/bSuKvAby9kGcRSE4aZi Uv30bzsAYB4CR1LxmYtD/+ZMtEE0HCzD3idWAFo= X-Google-Smtp-Source: ABdhPJyDF4yPgnd7NSChPy3uWStR7M7wOgJ4TrxefxNZK4ex35+euO+4Ypr8whrISkbSiTrIiJnM7s7yO5WP8Ddas0A= X-Received: by 2002:a62:7c43:0:b029:1ef:20ce:ba36 with SMTP id x64-20020a627c430000b02901ef20ceba36mr8556469pfc.40.1616148264353; Fri, 19 Mar 2021 03:04:24 -0700 (PDT) MIME-Version: 1.0 References: <20210317214149.20833-1-hhhawa@amazon.com> <20210317214149.20833-4-hhhawa@amazon.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 19 Mar 2021 12:04:08 +0200 Message-ID: Subject: Re: [PATCH v3 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero To: "Hawa, Hanna" Cc: Tony Lindgren , Haojian Zhuang , Linus Walleij , David Woodhouse , benh@amazon.com, ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com, tgershi@amazon.com, linux-arm Mailing List , Linux OMAP Mailing List , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210319_100427_317584_AF051178 X-CRM114-Status: GOOD ( 19.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 19, 2021 at 9:53 AM Hawa, Hanna wrote: > On 3/18/2021 2:15 PM, Andy Shevchenko wrote: > > On Wed, Mar 17, 2021 at 11:42 PM Hanna Hawa wrote: > >> An SError was detected when trying to print the supported pins in a > > What is SError? Yes, I have read a discussion, but here is the hint: > > if a person sees this as a first text due to, for example, bisecting > > an issue, what she/he can get from this cryptic name? > > What you suggest? > s/An SError/A kernel-panic/? Not below, but something which makes clear what SError is. Like "A System Error (SError, followed by kernel panic) ..." > Or remove the sentence and keep the below: > " > This change fixes the pcs_pin_dbg_show() in pinctrl-single driver when > bits_per_mux is not zero. In addition move offset calculation and pin > offset in register to common function. > " -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel