From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Terry Bowman <terry.bowman@amd.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Wolfram Sang <wsa@kernel.org>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
katie.morris@in-advantage.com
Subject: Re: [PATCH v14 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi
Date: Tue, 2 Aug 2022 10:47:04 +0200 [thread overview]
Message-ID: <CAHp75VcHU+Rh2ROjMcK+Yuyu1Ty9C0Dcx2SjrnrM4BV9NuMZig@mail.gmail.com> (raw)
In-Reply-To: <YuiJLK8ncbHH3OhE@euler>
On Tue, Aug 2, 2022 at 4:17 AM Colin Foster
<colin.foster@in-advantage.com> wrote:
...
> > I'm wondering if you can use in both cases
> > spi_message_init_with_transfers().
>
> > > +static int ocelot_spi_regmap_bus_read(void *context, const void *reg, size_t reg_size,
> > > + void *val, size_t val_size)
> > > +{
> > > + struct spi_transfer tx, padding, rx;
>
> struct spi_transfer xfers[3] = {0};
> struct spi_transfer *xfer_tok = xfers;
unsigned int index;
> > > + struct device *dev = context;
> > > + struct ocelot_ddata *ddata;
> > > + struct spi_device *spi;
> > > + struct spi_message msg;
> > > +
> > > + ddata = dev_get_drvdata(dev);
> > > + spi = to_spi_device(dev);
> > > +
> > > + spi_message_init(&msg);
> > > +
> > > + memset(&tx, 0, sizeof(tx));
> > > +
> > > + tx.tx_buf = reg;
> > > + tx.len = reg_size;
index = 0;
> xfer_tok->tx_buf = reg;
> xfer_tok->len = reg_size;
tok[index] = ...;
index++;
> xfer_tok++;
>
> > > + spi_message_add_tail(&tx, &msg);
> > > +
> > > + if (ddata->spi_padding_bytes) {
> > > + memset(&padding, 0, sizeof(padding));
> > > +
> > > + padding.len = ddata->spi_padding_bytes;
> > > + padding.tx_buf = ddata->dummy_buf;
> > > + padding.dummy_data = 1;
>
> xfer_tok->len
> xfer_tok->tx_buf
> xfer_tok->dummy_data
tok[index] = ...
> xfer_tok++;
index++;
> > > + spi_message_add_tail(&padding, &msg);
> > > + }
> > > +
> > > + memset(&rx, 0, sizeof(rx));
> > > + rx.rx_buf = val;
> > > + rx.len = val_size;
>
> xfer_tok->rx_buf
> xfer_tok->len
tok[index] = ...
> xfer_tok++;
index++;
> > > + spi_message_add_tail(&rx, &msg);
>
> spi_message_init_with_transfers(&msg, xfers, xfer_tok - xfers);
..., index);
> > I'm wondering if you can use in both cases
> > spi_message_init_with_transfers().
>
> I could see that implementation getting the response of "what the heck
> were you thinking" or "that looks alright" and I honestly have no idea
> which pool it will fall into.
See above. I.o.w. use index based assignments.
> > > + return spi_sync(spi, &msg);
> > > +}
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-02 8:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 4:06 [PATCH v14 mfd 0/9] add support for VSC7512 control over SPI Colin Foster
2022-07-22 4:06 ` [PATCH v14 mfd 1/9] mfd: ocelot: add helper to get regmap from a resource Colin Foster
2022-07-25 9:39 ` Andy Shevchenko
2022-07-25 15:46 ` Colin Foster
2022-08-01 14:45 ` Lee Jones
2022-07-22 4:06 ` [PATCH v14 mfd 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Colin Foster
2022-07-22 4:06 ` [PATCH v14 mfd 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module Colin Foster
2022-07-22 4:06 ` [PATCH v14 mfd 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration Colin Foster
2022-07-22 4:06 ` [PATCH v14 mfd 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module Colin Foster
2022-07-22 4:06 ` [PATCH v14 mfd 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Colin Foster
2022-07-22 4:06 ` [PATCH v14 mfd 7/9] resource: add define macro for register address resources Colin Foster
2022-07-22 4:06 ` [PATCH v14 mfd 8/9] dt-bindings: mfd: ocelot: add bindings for VSC7512 Colin Foster
2022-07-22 4:06 ` [PATCH v14 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Colin Foster
2022-07-25 20:00 ` Andy Shevchenko
2022-08-02 2:17 ` Colin Foster
2022-08-02 8:47 ` Andy Shevchenko [this message]
2022-08-03 1:28 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcHU+Rh2ROjMcK+Yuyu1Ty9C0Dcx2SjrnrM4BV9NuMZig@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=katie.morris@in-advantage.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=terry.bowman@amd.com \
--cc=vladimir.oltean@nxp.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).