From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Ondrej Jirman <x@xff.cz>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Chen-Yu Tsai <wens@csie.org>,
Colin Ian King <colin.king@intel.com>,
David Gow <davidgow@google.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Marco Felsch <m.felsch@pengutronix.de>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Stephen Boyd <swboyd@chromium.org>,
Yassine Oudjana <y.oudjana@protonmail.com>,
"fengping.yu" <fengping.yu@mediatek.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v4 2/4] Input: pinephone-keyboard - Add PinePhone keyboard driver
Date: Sun, 19 Jun 2022 13:43:59 +0200 [thread overview]
Message-ID: <CAHp75VcXNTxusT5N_8JvYWMhUyY_sAUzTcT3h0hz2bAawv6ThQ@mail.gmail.com> (raw)
In-Reply-To: <20220618165747.55709-3-samuel@sholland.org>
On Sat, Jun 18, 2022 at 7:10 PM Samuel Holland <samuel@sholland.org> wrote:
>
> The official Pine64 PinePhone keyboard case contains a matrix keypad and
> a MCU which runs a libre firmware. Add support for its I2C interface.
...
> +#include <linux/crc8.h>
> +#include <linux/i2c.h>
> +#include <linux/input/matrix_keypad.h>
> +#include <linux/interrupt.h>
> +#include <linux/module.h>
> +#include <linux/regulator/consumer.h>
Missed
types.h
...
> +#define PPKB_ROWS 6
> +#define PPKB_COLS 12
...
> + for (col = 0; col < PPKB_COLS; ++col) {
> + u8 old = old_buf[1 + col];
> + u8 new = new_buf[1 + col];
> + u8 changed = old ^ new;
> +
> + if (!changed)
> + continue;
> +
> + for (row = 0; row < PPKB_ROWS; ++row) {
> + u8 mask = BIT(row);
> + u8 value = new & mask;
> + unsigned short code;
> + bool fn_state;
> +
> + if (!(changed & mask))
> + continue;
> +
> + /*
> + * Save off the FN key state when the key was pressed,
> + * and use that to determine the code during a release.
> + */
> + fn_state = value ? ppkb->fn_pressed : ppkb->fn_state[col] & mask;
> + if (fn_state)
> + ppkb->fn_state[col] ^= mask;
Can't it be converted to use bitmap APIs?
> + }
> + }
...
> +static int ppkb_set_scan(struct i2c_client *client, bool enable)
> +{
> + struct device *dev = &client->dev;
> + int ret, val;
> +
> + ret = i2c_smbus_read_byte_data(client, PPKB_SYS_CONFIG);
> + if (ret < 0) {
> + dev_err(dev, "Failed to read config: %d\n", ret);
> + return ret;
> + }
> +
> + if (enable)
> + val = ret & ~PPKB_SYS_CONFIG_DISABLE_SCAN;
> + else
> + val = ret | PPKB_SYS_CONFIG_DISABLE_SCAN;
> + ret = i2c_smbus_write_byte_data(client, PPKB_SYS_CONFIG, val);
> + if (ret) {
> + dev_err(dev, "Failed to write config: %d\n", ret);
> + return ret;
> + }
> +
> + return 0;
return ret;
> +}
...
> +static int ppkb_open(struct input_dev *input)
> +{
> + struct i2c_client *client = input_get_drvdata(input);
> + int ret;
> +
> + ret = ppkb_set_scan(client, true);
> + if (ret)
> + return ret;
> +
> + return 0;
return ppkb_set_scan(...);
> +}
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-19 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 16:57 [PATCH v4 0/4] Pine64 PinePhone keyboard support Samuel Holland
2022-06-18 16:57 ` [PATCH v4 1/4] dt-bindings: input: Add the PinePhone keyboard binding Samuel Holland
2022-06-18 16:57 ` [PATCH v4 2/4] Input: pinephone-keyboard - Add PinePhone keyboard driver Samuel Holland
2022-06-19 11:43 ` Andy Shevchenko [this message]
2022-06-21 4:12 ` Samuel Holland
2022-10-01 6:28 ` Dmitry Torokhov
2022-06-18 16:57 ` [PATCH v4 3/4] Input: pinephone-keyboard - Support the proxied I2C bus Samuel Holland
2022-06-19 11:34 ` Andy Shevchenko
2022-06-18 16:57 ` [PATCH v4 4/4] [DO NOT MERGE] arm64: dts: allwinner: pinephone: Add keyboard Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcXNTxusT5N_8JvYWMhUyY_sAUzTcT3h0hz2bAawv6ThQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=colin.king@intel.com \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=m.felsch@pengutronix.de \
--cc=mkorpershoek@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=swboyd@chromium.org \
--cc=wens@csie.org \
--cc=x@xff.cz \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).