From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75355C3A589 for ; Tue, 20 Aug 2019 08:53:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43FF522DCB for ; Tue, 20 Aug 2019 08:53:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W59G2Ij+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eId2nnkA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43FF522DCB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3sxGN3E9pgcG/eLVGqCPJ2+ZCyvV4I5zQR9OkDFzkZY=; b=W59G2Ij+n7D2xF tbPMlTq3uciDGgxDdKd/ePgpFbS+ZcYqP1o/FPUt9yDnBk02fyrd0WdVpY5JA/eHKb89Ibe7TJnZz LURheLD9mqYkYWZjxyyyvU/cqvrXixWv5Bh149l4xYnm1+SjciNtZop6quIb3Ccb7wqfs7Nf7p6hA 5dqkiu3Ot2WSU4lK0Me6l2ZWcQmezowlw4H3D9AWlUj9Hkv3aBp/GPm4FDn/sn4Ijyg55Qy7O4lU/ i3JmeTurPeTgDRXEy7tUv38PsKlkRVPmU5L4+bqcGRSrfJEdT9Lx4r6RC4fYR9V7bSP7bhrxB0t1D 5e2JkDtlWCf63aEyfwSA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzztP-0003iY-QY; Tue, 20 Aug 2019 08:53:27 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzzrH-0001ix-6p for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2019 08:51:17 +0000 Received: by mail-pf1-x443.google.com with SMTP id g2so2976260pfq.0 for ; Tue, 20 Aug 2019 01:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F8ZkO1elV3VOIo0K30JacS/YJHIWCmxOiyDVl2xJliM=; b=eId2nnkAbmSborZ14m9x5Eg3s55XQW5KuqyexFm/5IxvHBsrRv+KWoTfnOtu+EW6r9 l/IRpKx5z37MdpptvqDXMu/rHXGsNaFsLZ2Aemm4WDxRuya1HGSJYS3rhx8TkQWyJ2zR qKQDBlSJLpfITyhCzjSSqK+JdTR8HDNFpX3zgUxRAjs0cvhPMEFHJiHYgcfY8LfjBJKg SiHA49PB2jRLP8Ezc3uN2bA1bvtqOO3x0TKu6vVrUbw8kb6eeLFBEguQt21Mhp4Gs5Ac DPPgVR9kg0aQJ8UhPnO6Gh+Xl83t/WVwffpkO1LcqkAHNsF/sYGZAwyBPAddpOB9RUqo vmSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F8ZkO1elV3VOIo0K30JacS/YJHIWCmxOiyDVl2xJliM=; b=baXlVFhZxtLrEmwtWKg/hzzHjQr8YqRgrzeCNmV51+TV9zM15mzeu0Dk9Fdzzzcsu3 cCteYt6afvlW/rf+e66g2dPatdMNS8Cy6HplWMhfx3WcvZi3H+Nko9GbKsJxEDLr8NP/ VrTzl0/Ygu85fwKz5xcU1h4rDLeexc4oNPWPJBLEVC1E/MlqyC8L/WrP8YIot0ljyl8C VDBciJxv6lpIoE3nEukiC3sWxx6hw/OZWyFsZ0ScNzLqsAMFqzIsxCxOzPStGQWMQ7zE TXSc8zbXNyz+FdpWy/i6Uu6dZYBADQ7jUit+KrAwhqVE9jZzXpSwKgZRAH7dP5R+/U1i Y/Gw== X-Gm-Message-State: APjAAAV/XVo/zmBCxJ5oWoibvOoG0zIkG6Qt0SSoOAlcJSYz8teNld9Q HgCR65Y7OoQKVujMUXBwCad1cH+pDsICpbgb8PI= X-Google-Smtp-Source: APXvYqzUg/wVcQbACT0z4VVsJ/hlgqRibUCwwz5eBIC3Ei4+518/wQLbSrJhkxetJKEWr9wqGNsdgSFW1JJnejnvQuc= X-Received: by 2002:a05:6a00:8e:: with SMTP id c14mr28096166pfj.241.1566291074329; Tue, 20 Aug 2019 01:51:14 -0700 (PDT) MIME-Version: 1.0 References: <1566221225-5170-1-git-send-email-xuwei5@hisilicon.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 20 Aug 2019 11:51:01 +0300 Message-ID: Subject: Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion To: Linus Walleij X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_015115_306538_D27E636B X-CRM114-Status: GOOD ( 21.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Salil Mehta , jinying@hisilicon.com, Tangkunshan , "Liguozhu \(Kenneth\)" , John Garry , "Rafael J. Wysocki" , Linux Kernel Mailing List , Wei Xu , Linuxarm , "open list:GPIO SUBSYSTEM" , Shiju Jose , Shameerali Kolothum Thodi , huangdaode , Jonathan Cameron , Thierry Reding , Mika Westerberg , Zhangyi ac , linux-arm Mailing List , Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 20, 2019 at 10:12 AM Linus Walleij wrote: > On Mon, Aug 19, 2019 at 5:07 PM Andy Shevchenko > wrote: > > > The proper fix is to revert the culprit since we call > > acpi_gpiochip_request_interrupts() for all controllers. > > Linus, please re-do the approach with IRQ handling, > > Exactly what do you refer to when you want me to > "re-do the approach for IRQ handling"? Do you mean > this driver or are you referring to: > > commit e0d89728981393b7d694bd3419b7794b9882c92d > Author: Thierry Reding > Date: Tue Nov 7 19:15:54 2017 +0100 > > gpio: Implement tighter IRQ chip integration > > Currently GPIO drivers are required to add the GPIO chip and its > corresponding IRQ chip separately, which can result in a lot of > boilerplate. Use the newly introduced struct gpio_irq_chip, embedded in > struct gpio_chip, that drivers can fill in if they want the GPIO core > to automatically register the IRQ chip associated with a GPIO chip. > > Signed-off-by: Thierry Reding > Acked-by: Grygorii Strashko > Signed-off-by: Linus Walleij Yes. > The new API introduced by this patch is what I am trying to switch > everything over to, because the forked paths inside of gpiolib > is causing me a maintenance headache and also increasing > the footprint of the library. Yes, I understand. > > it seems broadly > > regress with ACPI enabled platforms. > > It only becomes a problem if the platform uses ACPI right? Unfortunately yes. Though in this case it was working and stopped working. > But it's a problem if I can't really tell if a driver is using > ACPI or not, there is no sign in the pl061 driver that it would > be used on ACPI systems until now, so how do I design > for it? It's hidden under amba_driver_register() which works for all registered thru drivers/acpi/acpi_amba.c. I agree this is not straightforward. > The problem comes from the problem/mess I am trying to > clean up in the first place. So if the new way of registering GPIO > irqchips is not working for ACPI, then we have to fix that instead > of reverting all attempts to use the new API IMO. Sorry for me being impatient and asking for a groundless requests. I'll help you with cleaning this. -- With Best Regards, Andy Shevchenko -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel