From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A8CECA9EA1 for ; Fri, 18 Oct 2019 09:35:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D72821852 for ; Fri, 18 Oct 2019 09:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N5Rezxfc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RAcZMOWD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D72821852 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O50phqk2mor4+eYbD2Wd01iobIQIAh79gOW0B4OeEdI=; b=N5Rezxfce53ryX CZIUeiqXYnswOO4DttBSm/+Q+ubuTJD8osCsd3F4F+YoELJd0J9L81Pb9hLglFthLBVhBY02wlyFc HD2Twh6CD7Utk7NRg6lMR/FuMp6yF2eJkSIVVnK7gB5UrJskvY0Y+KdJ4O3uhtmZ1IZ01x9P7+Ydd v3HwqBIF5s1z/I6OBkvmONhgLlTMn+kcjwFUtMQniaA0jLsVU1qgKH8aznDYgbkIUa6M543GiJroe ROKoKm77kZJAcJyyz0dmKF1ZCd1u/ORx4DcW/b3snLUBr8R7hHIUV6mfrGQu0ZsSlUrvqAoLXCUVJ e3QZDxtfx8ALe/bcDIbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLOf5-0001n7-RJ; Fri, 18 Oct 2019 09:35:07 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLOf1-0001Lf-Sn for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2019 09:35:05 +0000 Received: by mail-pl1-x642.google.com with SMTP id j11so2586456plk.3 for ; Fri, 18 Oct 2019 02:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zr8X80FCYGX3NS6q9lz/ERKNDbQdTzcOLi07a/VkvfQ=; b=RAcZMOWD82a0s6I1gcxzhmBdLU4sVZdK3yGz6Jjs25y3EznSN5eVKpll2358Hrj84u APlxx26N4fwfgRJiFJ3sc5LoxBXcNQRTt/vElvG+W7kkosg66YwJWoZkFCz0xTfMvR6f Cbjd+SgRLI8/CUJ1oQ20/w7/U3I+PL006t8sQWvLz38Yc2tf9QieGrjd592HdCGX69Cg 74loV0t60w65irSxdkjPdEWFSMhshoRMFOVGmFBnebKIMvqsp5MvdTjjjRGoCG0iFtiU h1wO5yRg6ve6/4y64whxVgtn/1JdbbSxx2ZSNWTw0Q0U4by3x1tJ6j6655oXad9I+dDE rJ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zr8X80FCYGX3NS6q9lz/ERKNDbQdTzcOLi07a/VkvfQ=; b=BcJq+i769byJu8v7xlDvoub01vrzy8kW9q1arX1KHBJcyjA/tn8EtjJ7N5JJQzTk67 xlu0kCZyujQNflSQi22WfSYHAIJgr5bJbYHTybpnjekrEFfB/UPqlYrV3tldv/y9uvdn CuRgmTr/hBbQH5PPrQIIN0Ozhvo+TJNojHqltK7x3eZl2Ekt2EEjfMfGFuJTwpSVT19h XXcGTbiPlrNxki3Zd2SpfS5450bDIkmhNgOStrLkFIBr4mvkIg/Rre62IAfYaNCkl9td 62e4md99A4/KHI/o4oprOu6nikZchuqaZ+fiqaJL2/H8Gi1k1CDpBIfHN2i/eV8Oo0HS Mxzw== X-Gm-Message-State: APjAAAWgODXEd250flkKtfHZEsfMePRs6c5mLIKLLVFTN/U57xtetEab 3slT/XgY2b9r3tr2NL3g2y3JmSnsXJaFn5jEHGOX233Zq94= X-Google-Smtp-Source: APXvYqw4nAZfs4DJx1QtvaqZHEiRDgYXllfSaC8wgJ0IuaKqJS3EAvQxq6VuFyH8PluuguPVcRUER8YMtjWt98dTnbE= X-Received: by 2002:a17:902:b110:: with SMTP id q16mr8804423plr.262.1571391302793; Fri, 18 Oct 2019 02:35:02 -0700 (PDT) MIME-Version: 1.0 References: <20191017025058.31528-1-hslester96@gmail.com> In-Reply-To: <20191017025058.31528-1-hslester96@gmail.com> From: Andy Shevchenko Date: Fri, 18 Oct 2019 12:34:52 +0300 Message-ID: Subject: Re: [PATCH] spi: pxa2xx: Add missed security checks To: Chuhong Yuan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191018_023503_958817_7520B65C X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Mailing List , Haojian Zhuang , linux-spi , Mark Brown , Daniel Mack , Robert Jarzmik , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2019 at 8:59 AM Chuhong Yuan wrote: > > pxa2xx_spi_init_pdata misses checks for devm_clk_get and > platform_get_irq. > Add checks for them to fix the bugs. > > Signed-off-by: Chuhong Yuan > --- > drivers/spi/spi-pxa2xx.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c > index bb6a14d1ab0f..2e73d75a6ac5 100644 > --- a/drivers/spi/spi-pxa2xx.c > +++ b/drivers/spi/spi-pxa2xx.c > @@ -1565,7 +1565,13 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) > #endif > > ssp->clk = devm_clk_get(&pdev->dev, NULL); > + if (IS_ERR(ssp->clk)) > + return NULL; > + > ssp->irq = platform_get_irq(pdev, 0); > + if (ssp->irq < 0) > + return NULL; I'm not sure they are mandatory for all platforms. To be on the safe side, you simple need to add _optional() to the both call along with above change. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel