From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A9BC2B9F4 for ; Thu, 17 Jun 2021 07:20:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 086A161241 for ; Thu, 17 Jun 2021 07:20:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 086A161241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yfQJKRuXsdQRJ84J/1kT6u/OocXBx3VAUt0KTGrdAAk=; b=TaOxViYqN7kob9 PcP8XXBBXzQAzGkHoGLdqOGMlUPDlowAA2zI5o7cD2FmKD/L6CtL/4S8WI/5qwrRJQmMDSi7tW7Jm F2NFZhpjoEavInkKDD1kFZs6pbU0wvjNoqRry01K9IBehq1CvDVL3eOkUgwcNnF36a/CZVsBeTJMW L03/iceo/QFprGdhczJ4faC4lUwi460TY1YXaqvN1BFxCYVhzTAExmDgXgrt+4HSAi/huCg/bmzw8 ZqkGtpiHQN/lAr8MlsKSf8+YXqrxsZXtaFNiUO8WfXkKYdjBdi/zVXMP0qvxh3znbqzmak4t06bS7 PVtFQRu7AilxNKwZ4tBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltmIl-009EpR-4x; Thu, 17 Jun 2021 07:18:59 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltmIc-009Enj-Vu for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 07:18:52 +0000 Received: by mail-pg1-x52e.google.com with SMTP id v7so4231000pgl.2 for ; Thu, 17 Jun 2021 00:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=urMPTkRkijNnq1YTyn7+SteYdXmaIXj2TQZnikbLXEs=; b=QqObbYwhOZtqYEGImDxe+JckngZqWKDW5ifZeQZHpAT2cUvDYK9vPjzhVmpB/kqK52 2X3S9uCa7ue7j8/8gfXNgSPHy1sxELuEscsFso3LNqZzVFY0+NDKXrrHjOSxMf+r2exn QbJNxB60BtXOkBCpuHrrI8uct9Dllx7DkRCqcMBPaKaCp35J67z/suX2RPxAK2gJh756 GWaULDDll06gMPHK98NYmCIyZoveoTay00oiUrhIoASXFYKPNWcOF2ULvow+OO+c+Uki yaNCUAPaNywRt4FccsYisu7PauB8M2yLH1c1bIeeLIsUODO13oioO66Gvc02yJA6WWVp 3kBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=urMPTkRkijNnq1YTyn7+SteYdXmaIXj2TQZnikbLXEs=; b=behvnz3IEg2di05eHtfaQ7CxWxxbKApwEDbFp0Lrb+BIwgzacHKoH5MawfiS3Cbo/2 /IEPRaJVROIpt5mUPdS+YkwgauSpCbze7jQJQvN1jR+3jnd1iUDkIQA/wcuiE7GRx23h Kb5uQ/oP+sT/Dhlv0agnQZYqTIH0DVSRKblw2FO4KKST6Lu+GjJdPC/FCAgS07TxNLCS pSpviT7Z1pYw3NzhNMwuF0SperjmEkmAlgSwd6B6p70laIBjuC4cBiNvyDU/2vrVSZ4Z txcpzrgqyavOg2jB64uQ6texETr3NYDhnisXnDUj7zEAPk2q1fOz1Zr61fTeJElW0UHd JCTw== X-Gm-Message-State: AOAM533wZ8Jl5iSO6QyHIlhzB6OqEMgAw3XhmqZaIN4qN7xncqITDlkx PXzelZ2QC/ywttJYKuWMCXPvhVag5BbjWYbEt48= X-Google-Smtp-Source: ABdhPJx2RTT5n7WoD6XIYmdUVuUkAr7Ak0SI+3gHXobSWPWtgaEpjpZDq+n+Q8TxsRLysqNXPXyy3uccfjbLXXtvYTA= X-Received: by 2002:a63:b00d:: with SMTP id h13mr3732496pgf.74.1623914329647; Thu, 17 Jun 2021 00:18:49 -0700 (PDT) MIME-Version: 1.0 References: <1619080202-31924-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1619080202-31924-4-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> In-Reply-To: From: Andy Shevchenko Date: Thu, 17 Jun 2021 10:18:33 +0300 Message-ID: Subject: Re: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support To: Sai Krishna Potthuri Cc: Linus Walleij , Rob Herring , Michal Simek , Greg Kroah-Hartman , linux-arm Mailing List , Linux Kernel Mailing List , devicetree , "open list:GPIO SUBSYSTEM" , git , "saikrishna12468@gmail.com" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_001851_079823_71419240 X-CRM114-Status: GOOD ( 25.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 17, 2021 at 9:37 AM Sai Krishna Potthuri wrote: > Ping! Do not top-post. Do not ping for the sake of pings. > > From: Sai Krishna Potthuri > > Sent: Tuesday, May 11, 2021 6:08 PM > > > From: Sai Krishna Potthuri > > > Sent: Wednesday, April 28, 2021 11:04 AM > > > > From: Andy Shevchenko > > > > Sent: Monday, April 26, 2021 7:35 PM ... > > > > > > > + ret = zynqmp_pm_pinctrl_get_config(pin, param, &arg); > > > > > > > + if (arg != PM_PINCTRL_BIAS_PULL_UP) > > > > > > > + return -EINVAL; > > > > > > > > > > > > Error code being shadowed. Instead check it here properly. > > > > > > > > > Are you mentioning the case where ret is also a non-zero? > > > > > If yes, then I will update this check to if (!ret && arg != > > > > > PM_PINCTRL_BIAS_PULL_UP) > > > > > return -EINVAL; > > > > > > > > No, this is wrong in the same way. > > > > > > > > > ret non-zero case, we are handling at the end of switch case. > > > > > > > > I meant that you need to pass the real return code to the (upper) caller. > > > Here we are checking for valid argument and not the return value of the > > API. > > > If the read value(argument) is not valid and return value of the API > > > is zero (SUCCESS) then framework expects driver to be returned with > > > '-EINVAL' and it is a legal error code in this case. > > Do you agree on this? > > I am ready with the other changes, will send out the patch to address your > > comments. If you are ready, drop a new version (note, ~1w is a good time to send a new version if no one answered the doubts in your previous one, which means "silent agreement"). -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel